* [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions
@ 2016-06-18 9:31 Hans de Goede
2016-06-18 11:33 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2016-06-18 9:31 UTC (permalink / raw)
To: linux-arm-kernel
commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
changed the condition under which irqs are requested, but omitted matching
changes to sun4i_usb_phy_remove(). This commit fixes this.
Fixes: commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/phy/phy-sun4i-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index 8c2570d..8c7eb33 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -548,9 +548,9 @@ static int sun4i_usb_phy_remove(struct platform_device *pdev)
if (data->vbus_power_nb_registered)
power_supply_unreg_notifier(&data->vbus_power_nb);
- if (data->id_det_irq >= 0)
+ if (data->id_det_irq > 0)
devm_free_irq(dev, data->id_det_irq, data);
- if (data->vbus_det_irq >= 0)
+ if (data->vbus_det_irq > 0)
devm_free_irq(dev, data->vbus_det_irq, data);
cancel_delayed_work_sync(&data->detect);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions
2016-06-18 9:31 [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions Hans de Goede
@ 2016-06-18 11:33 ` Sergei Shtylyov
2016-06-22 6:05 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2016-06-18 11:33 UTC (permalink / raw)
To: linux-arm-kernel
On 6/18/2016 12:31 PM, Hans de Goede wrote:
> commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
> changed the condition under which irqs are requested, but omitted matching
> changes to sun4i_usb_phy_remove(). This commit fixes this.
>
> Fixes: commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
"Commit" not needed here, this tag has a standardized format.
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions
2016-06-18 11:33 ` Sergei Shtylyov
@ 2016-06-22 6:05 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2016-06-22 6:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Saturday 18 June 2016 05:03 PM, Sergei Shtylyov wrote:
> On 6/18/2016 12:31 PM, Hans de Goede wrote:
>
>> commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
>> changed the condition under which irqs are requested, but omitted matching
>> changes to sun4i_usb_phy_remove(). This commit fixes this.
>>
>> Fixes: commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing
>> probe")
>
> "Commit" not needed here, this tag has a standardized format.
Fixed it myself and applied.
Thanks
Kishon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-22 6:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-18 9:31 [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions Hans de Goede
2016-06-18 11:33 ` Sergei Shtylyov
2016-06-22 6:05 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).