linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes
Date: Sun, 26 Jun 2016 10:26:43 -0700	[thread overview]
Message-ID: <57701053.9090903@gmail.com> (raw)
In-Reply-To: <20160626080550.GG4000@lukather>

Le 26/06/2016 01:05, Maxime Ripard a ?crit :
> Hi Florian,
> 
> On Sat, Jun 25, 2016 at 07:59:23PM -0700, Florian Fainelli wrote:
>> Le 23/06/2016 22:48, Chen-Yu Tsai a ?crit :
>>>> diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>>>> index 5ee43d8bf174..697582397dcf 100644
>>>> --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>>>> +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>>>> @@ -110,13 +110,67 @@
>>>>  &gmac {
>>>>         pinctrl-names = "default";
>>>>         pinctrl-0 = <&gmac_pins_rgmii_a>;
>>>> -       phy = <&phy1>;
>>>>         phy-mode = "rgmii";
>>>>         phy-supply = <&reg_gmac_3v3>;
>>>>         status = "okay";
>>>>
>>>> -       phy1: ethernet-phy at 1 {
>>>> -               reg = <1>;
>>>> +       fixed-link {
>>>> +               speed = <1000>;
>>>> +               full-duplex;
>>>> +       };
>>>> +
>>>> +       mdio1 {
>>>
>>> mdio will suffice.
>>
>> There is another label in sun7i-a20.dtsi named mdio which is for the
>> MDIO controller node matching allwinner,sun4i-a10-mdio, which is not the
>> one we want here, we want the MDIO controller associated with the
>> Synopsys GMAC.
> 
> Yes, but it's in a different node, and you're not using any labels, so
> I don't really see how that would conflict.

Fair enough, I sent a v2 which uses "mdio-gmac" as a label, should I
respin a v3 which just uses "mdio"?

v2 is here;
http://www.spinics.net/lists/arm-kernel/msg514007.html
-- 
Florian

  reply	other threads:[~2016-06-26 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12  0:14 [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes Florian Fainelli
2016-06-12  0:14 ` Florian Fainelli
2016-06-24  5:48   ` Chen-Yu Tsai
2016-06-24  5:51     ` Chen-Yu Tsai
2016-06-26  2:59     ` Florian Fainelli
2016-06-26  8:05       ` Maxime Ripard
2016-06-26 17:26         ` Florian Fainelli [this message]
2016-06-27  8:09           ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57701053.9090903@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).