From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE72CC4345F for ; Wed, 24 Apr 2024 18:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yIR14gSaxNkzb6xRgLA/UwlOZtCSDvDl1aFzNKkjoZY=; b=RAOS8yYaJKlVUw ns46cgWyalCt7kLnkUFqKPaZcgiwTggLyXeqc+ehee46FS9YZYIczYQqYdKsNJGnCnXK6hOv6JTXe SlJmseGtjy9hkyYXMgEt1ogYKmwnyVzZHQhlMxs4zHvJsStWA5uSd3zE4gnj0e9d3M7DLVaHhB6TS 2MKOBWu7EdtuTxZBVqCr/tvAL6+yfDgIUK3cGkK6CCwo+4/CTI+uDfpbVrkXBWB/0kKpWU7aSQswB XY8tap1/nmOZAXK54p8ll3tcEJE3PKFAVaQBT36YcqsGES2NrclRM8hyBsLc48WffNPjbiZygf1A7 Hl0SHLcqtrwaE2nC8RSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzhZo-00000005Qp2-0bUj; Wed, 24 Apr 2024 18:42:40 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzhZh-00000005QmK-3gW0 for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 18:42:38 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-572347c2c16so165753a12.2 for ; Wed, 24 Apr 2024 11:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713984151; x=1714588951; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ol9krzBmTOyIuy1ft27l71rabBxmYrw1+e+89jby570=; b=I6TjpWN/Fefab5y6gxDQvMFU+SlTl0oBj18pXk4V0X2sCUM7fNce7czBkuydRL52oh A4RubqiQG4WRKHFyJLHUPa951tBABA3mOi1i8/4WjhJAqyqmfPFURI2PZu3p1lwRXyWo OF2g4OlEmqyuZA7YpEvPX6A/keNHsYF/nNlY3P4b54HfBzm78vfSU6AeQKkY/syJQv+P HM3tOx5SjFNWJQugKOr5I4CRwPf/ARVjgvSHkEf/FjkMbPyi8VesYTrq3sAz+Di1VEKb pn5+XPv4PEVN4EVuwydw8KrlKHTTwZqa7JpWGAGJQHQkdbn10ElDuekyjk+j5CmtcTGW AbaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713984151; x=1714588951; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ol9krzBmTOyIuy1ft27l71rabBxmYrw1+e+89jby570=; b=wCwGaxkQ3W4ViUwnaXwNQR+obKuYTV2zuGyyZqd01hfyv5j10Xf98qht0YPP7s6Cw3 6w4or/HblY5x7UB2l4XhXJxZ8pZll1zhZmqhRUFQkvS+Ubciu/qnoxdsQLOASrHKL8C7 CJmNyz/+akPtW6sZya1W/GqfgvT4rXkiHZU3ToAbfTOdo2a2wU04hpJDYP49xQXElgjB ajJLcD9XCg4xvs/ww/nHW9miHIzJ4Ww/39fYYovJiPmfRWW/iw7P++gjuaaKWeJ9egah FFG4EtgOE+WzxkAIW1wF716ncvWXaaproYV9ZIwzJS6TifcSsmy9dz2haq2eh5clNDPB eu+g== X-Forwarded-Encrypted: i=1; AJvYcCW0/+r2ZXCUj2NEFYh+CUZEQ+0uHAZQ0Slw3Y1VJwcwRNGYqtI3nO/tUj8AIT072yXTKlRoIlGvYDI4J6RztwawWzaV2cOuQVST1W056guPzQ2B4J8= X-Gm-Message-State: AOJu0YzheYxyjBZW29YkXzDwiKmFbtHM7SVJW+IEgMop7lyyInfa3/KR coWJ3QFsWUje8zbaEQICKT6SR8UcUDQG4Ml0KiRc3cgaWMoVjMcD X-Google-Smtp-Source: AGHT+IFJqfBO5mQOjDTG16NEhTc1tvbEXpcR5UL3y/xbDmPZLBWl1fVr9z9AG8k1xyje5QaUGr0gWw== X-Received: by 2002:a50:9e64:0:b0:566:2f24:b063 with SMTP id z91-20020a509e64000000b005662f24b063mr2220945ede.23.1713984150928; Wed, 24 Apr 2024 11:42:30 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id j2-20020aa7de82000000b005720e083878sm3644714edv.49.2024.04.24.11.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 11:42:30 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Ban Tao , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , Joao Schim Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: sunxi: DMIC: Add controls for adjusting the mic gains Date: Wed, 24 Apr 2024 20:42:29 +0200 Message-ID: <5772237.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20240422150213.4040734-1-joao@schimsalabim.eu> References: <20240422150213.4040734-1-joao@schimsalabim.eu> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_114233_966981_1F63F901 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joao, Dne ponedeljek, 22. april 2024 ob 17:02:13 GMT +2 je Joao Schim napisal(a): > The AllWinner H6 and later SoCs that sport a DMIC block contain a set of registers to control > the gain (left + right) of each of the four supported channels. > > Add ASoC controls for changing each of the stereo channel gains using alsamixer and alike Add SoB tag. > --- > sound/soc/sunxi/sun50i-dmic.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c > index c76628bc86c6..f8613d8c3462 100644 > --- a/sound/soc/sunxi/sun50i-dmic.c > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #define SUN50I_DMIC_EN_CTL (0x00) > #define SUN50I_DMIC_EN_CTL_GLOBE BIT(8) > @@ -43,6 +44,17 @@ > #define SUN50I_DMIC_CH_NUM_N_MASK GENMASK(2, 0) > #define SUN50I_DMIC_CNT (0x2c) > #define SUN50I_DMIC_CNT_N (1 << 0) > +#define SUN50I_DMIC_D0D1_VOL_CTR (0x30) > + #define SUN50I_DMIC_D0D1_VOL_CTR_0R (0) > + #define SUN50I_DMIC_D0D1_VOL_CTR_0L (8) > + #define SUN50I_DMIC_D0D1_VOL_CTR_1R (16) > + #define SUN50I_DMIC_D0D1_VOL_CTR_1L (24) > +#define SUN50I_DMIC_D2D3_VOL_CTR (0x34) > + #define SUN50I_DMIC_D2D3_VOL_CTR_2R (0) > + #define SUN50I_DMIC_D2D3_VOL_CTR_2L (8) > + #define SUN50I_DMIC_D2D3_VOL_CTR_3R (16) > + #define SUN50I_DMIC_D2D3_VOL_CTR_3L (24) > + > #define SUN50I_DMIC_HPF_CTRL (0x38) > #define SUN50I_DMIC_VERSION (0x50) > > @@ -273,8 +285,30 @@ static const struct of_device_id sun50i_dmic_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, sun50i_dmic_of_match); > > +static const DECLARE_TLV_DB_SCALE(sun50i_dmic_vol_scale, -12000, 75, 1); DECLARE_TLV_DB_SCALE is old name, SNDRV_CTL_TLVD_DECLARE_DB_SCALE should be used instead. Other than that, it looks fine. Best regards, Jernej > + > +static const struct snd_kcontrol_new sun50i_dmic_controls[] = { > + > + SOC_DOUBLE_TLV("DMIC Channel 0 Capture Volume", SUN50I_DMIC_D0D1_VOL_CTR, > + SUN50I_DMIC_D0D1_VOL_CTR_0L, SUN50I_DMIC_D0D1_VOL_CTR_0R, > + 0xFF, 0, sun50i_dmic_vol_scale), > + SOC_DOUBLE_TLV("DMIC Channel 1 Capture Volume", SUN50I_DMIC_D0D1_VOL_CTR, > + SUN50I_DMIC_D0D1_VOL_CTR_1L, SUN50I_DMIC_D0D1_VOL_CTR_1R, > + 0xFF, 0, sun50i_dmic_vol_scale), > + SOC_DOUBLE_TLV("DMIC Channel 2 Capture Volume", SUN50I_DMIC_D2D3_VOL_CTR, > + SUN50I_DMIC_D2D3_VOL_CTR_2L, SUN50I_DMIC_D2D3_VOL_CTR_2R, > + 0xFF, 0, sun50i_dmic_vol_scale), > + SOC_DOUBLE_TLV("DMIC Channel 3 Capture Volume", SUN50I_DMIC_D2D3_VOL_CTR, > + SUN50I_DMIC_D2D3_VOL_CTR_3L, SUN50I_DMIC_D2D3_VOL_CTR_3R, > + 0xFF, 0, sun50i_dmic_vol_scale), > + > + > +}; > + > static const struct snd_soc_component_driver sun50i_dmic_component = { > .name = "sun50i-dmic", > + .controls = sun50i_dmic_controls, > + .num_controls = ARRAY_SIZE(sun50i_dmic_controls), > }; > > static int sun50i_dmic_runtime_suspend(struct device *dev) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel