linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: s3c64xx: Add missing head file
Date: Wed, 29 Jun 2016 10:29:35 +0200	[thread overview]
Message-ID: <577386EF.1070400@samsung.com> (raw)
In-Reply-To: <1467187835-25660-1-git-send-email-wangkefeng.wang@huawei.com>

On 06/29/2016 10:10 AM, Kefeng Wang wrote:
> The building reports warning after patch "arm: Remove unnecessary
> of_platform_populate with default match table",
> 
> "arch/arm/mach-s3c64xx/common.h:28:2: warning: 'struct device_node' declared inside parameter list"
> 
> Add the missing of.h for device_node struct in common.h, and kill common.h
> from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c, because no function need it.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> 
> Hi Krzysztof, 
> 
> Thanks for your points, add "Reported-by" tag in v2, and Rob can directly
> pick it up if necessary.
> 
> Thanks,
> Kefeng
> 
>  arch/arm/mach-s3c64xx/common.h          | 1 +
>  arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

      reply	other threads:[~2016-06-29  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201606290335.vfTSIIB7%fengguang.wu@intel.com>
2016-06-29  1:45 ` [linux-next:master 5450/6660] arch/arm/mach-s3c64xx/common.h:28:2: warning: 'struct device_node' declared inside parameter list Kefeng Wang
2016-06-29  7:33   ` Krzysztof Kozlowski
2016-06-29  8:10     ` [PATCH v2] ARM: s3c64xx: Add missing head file Kefeng Wang
2016-06-29  8:29       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577386EF.1070400@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).