[PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers

[PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers

[Stefan Wahren]

Hi,

this small patch series should make the sdhci-iproc platform data easier
to read. Since i don't have the adequate hardware it's only compile tested.

Stefan

Stefan Wahren (2):
  mmc: sdhci: add define for suspend/resume capability
  mmc: sdhci-iproc: Use defines instead of magic numbers

 drivers/mmc/host/sdhci-iproc.c |   13 +++++++++++--
 drivers/mmc/host/sdhci.h       |    1 +
 2 files changed, 12 insertions(+), 2 deletions(-)

-- 
1.7.9.5

[PATCH 1/2] mmc: sdhci: add define for suspend/resume capability

[Stefan Wahren]

This patch adds the missing define for the suspend/resume
capability (according to SD Host Controller spec).

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 drivers/mmc/host/sdhci.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 609f87c..42584f0 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -186,6 +186,7 @@
 #define  SDHCI_CAN_DO_ADMA1	0x00100000
 #define  SDHCI_CAN_DO_HISPD	0x00200000
 #define  SDHCI_CAN_DO_SDMA	0x00400000
+#define  SDHCI_CAN_DO_SUSPEND	0x00800000
 #define  SDHCI_CAN_VDD_330	0x01000000
 #define  SDHCI_CAN_VDD_300	0x02000000
 #define  SDHCI_CAN_VDD_180	0x04000000
-- 
1.7.9.5

[PATCH 2/2] mmc: sdhci-iproc: Use defines instead of magic numbers

[Stefan Wahren]

The capabilities in iproc platform data are magic numbers. So
replace them with the proper capability defines to make it
readable.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 drivers/mmc/host/sdhci-iproc.c |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 1110f73..53abecc 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -164,8 +164,17 @@ static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
 
 static const struct sdhci_iproc_data iproc_data = {
 	.pdata = &sdhci_iproc_pltfm_data,
-	.caps = 0x05E90000,
-	.caps1 = 0x00000064,
+	.caps = ((0x1 << SDHCI_MAX_BLOCK_SHIFT)
+			& SDHCI_MAX_BLOCK_MASK) |
+		SDHCI_CAN_VDD_330 |
+		SDHCI_CAN_VDD_180 |
+		SDHCI_CAN_DO_SUSPEND |
+		SDHCI_CAN_DO_HISPD |
+		SDHCI_CAN_DO_ADMA2 |
+		SDHCI_CAN_DO_SDMA,
+	.caps1 = SDHCI_DRIVER_TYPE_C |
+		 SDHCI_DRIVER_TYPE_D |
+		 SDHCI_SUPPORT_DDR50,
 	.mmc_caps = MMC_CAP_1_8V_DDR,
 };
 
-- 
1.7.9.5

[PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers

[Scott Branden]

Hi Stefan,

On 16-07-02 12:23 PM, Stefan Wahren wrote:
> Hi,
>
> this small patch series should make the sdhci-iproc platform data easier
> to read. Since i don't have the adequate hardware it's only compile tested.
>
> Stefan
>
> Stefan Wahren (2):
>    mmc: sdhci: add define for suspend/resume capability
>    mmc: sdhci-iproc: Use defines instead of magic numbers
>
>   drivers/mmc/host/sdhci-iproc.c |   13 +++++++++++--
>   drivers/mmc/host/sdhci.h       |    1 +
>   2 files changed, 12 insertions(+), 2 deletions(-)
>
Patch series looks fine.

Acked-by: Scott Branden <scott.branden@broadcom.com>

[PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers

[Adrian Hunter]

On 04/07/16 20:02, Scott Branden wrote:
> Hi Stefan,
> 
> On 16-07-02 12:23 PM, Stefan Wahren wrote:
>> Hi,
>>
>> this small patch series should make the sdhci-iproc platform data easier
>> to read. Since i don't have the adequate hardware it's only compile tested.
>>
>> Stefan
>>
>> Stefan Wahren (2):
>>    mmc: sdhci: add define for suspend/resume capability
>>    mmc: sdhci-iproc: Use defines instead of magic numbers
>>
>>   drivers/mmc/host/sdhci-iproc.c |   13 +++++++++++--
>>   drivers/mmc/host/sdhci.h       |    1 +
>>   2 files changed, 12 insertions(+), 2 deletions(-)
>>
> Patch series looks fine.
> 
> Acked-by: Scott Branden <scott.branden@broadcom.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

[PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers

[Ulf Hansson]

On 2 July 2016 at 21:23, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi,
>
> this small patch series should make the sdhci-iproc platform data easier
> to read. Since i don't have the adequate hardware it's only compile tested.
>
> Stefan
>
> Stefan Wahren (2):
>   mmc: sdhci: add define for suspend/resume capability
>   mmc: sdhci-iproc: Use defines instead of magic numbers
>
>  drivers/mmc/host/sdhci-iproc.c |   13 +++++++++++--
>  drivers/mmc/host/sdhci.h       |    1 +
>  2 files changed, 12 insertions(+), 2 deletions(-)
>
> --
> 1.7.9.5
>

Thanks, applied for next!

Kind regards
Uffe