From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF9AC4338F for ; Thu, 5 Aug 2021 14:43:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C20B6113E for ; Thu, 5 Aug 2021 14:43:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2C20B6113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wZRXHdYYp4C05uL+Awu8DAAJydot5tZ5KuO1QqGmpaI=; b=lDIR6ZuJV73ZgGpYsYK+WISkuW FqmtVU/MhnWelrahjK9NUlwHEWlrynIY1SvVqYlaXBtKE5Eftx9RWehMZufQExeyLKeK2GsnYca2I 89lxmYCw8nydfOpoGUnVM3CgqUE6Ixa7py1qAfXYOoR+Ttz8MOLjOO4hJnt/GWD0CLpescbrKSOCh 3OssyL5Q0gRSyXmWth2vVmWjFerOC3/CItn/00uX7w0wapsrXJR1zsNtkVSlnJbaSEPQIyLdclr7d AhpsQ1f1CRgZbKIWegt2UhUoRJJ1+V6T1R9kxKp+s8WbFlYX2QoaEjKuyqPOY5Ws8mCXFMRIuUw/1 xE7g1G0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBeZW-009scf-E5; Thu, 05 Aug 2021 14:42:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBeZS-009scB-Rg for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 14:42:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C9A531B; Thu, 5 Aug 2021 07:42:04 -0700 (PDT) Received: from [10.57.36.146] (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 59A733F66F; Thu, 5 Aug 2021 07:42:03 -0700 (PDT) Subject: Re: [PATCH] iommu/arm-smmu-v3: Remove some unneeded init in arm_smmu_cmdq_issue_cmdlist() To: John Garry , will@kernel.org Cc: joro@8bytes.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com References: <1624293394-202509-1-git-send-email-john.garry@huawei.com> <45a8af4f-4202-ecd8-0882-507acf9b2eb2@huawei.com> From: Robin Murphy Message-ID: <577a625a-4fc5-7402-8e4f-4e0e5be93144@arm.com> Date: Thu, 5 Aug 2021 15:41:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <45a8af4f-4202-ecd8-0882-507acf9b2eb2@huawei.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_074207_036635_11FE6439 X-CRM114-Status: GOOD ( 30.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wOC0wNSAxNDo0MCwgSm9obiBHYXJyeSB3cm90ZToKPiBPbiAwNS8wOC8yMDIxIDEy OjI0LCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4+IE9uIDIwMjEtMDYtMjEgMTc6MzYsIEpvaG4gR2Fy cnkgd3JvdGU6Cj4+PiBNZW1iZXJzIG9mIHN0cnVjdCAibGxxIiB3aWxsIGJlIHplcm8taW5pdGVk LCBhcGFydCBmcm9tIG1lbWJlciAKPj4+IG1heF9uX3NoaWZ0Lgo+Pj4gQnV0IHdlIHdyaXRlIGxs cS52YWwgc3RyYWlnaHQgYWZ0ZXIgdGhlIGluaXQsIHNvIGl0IHdhcyBwb2ludGxlc3MgdG8gCj4+ PiB6ZXJvCj4+PiBpbml0IHRob3NlIG90aGVyIG1lbWJlcnMuIEFzIHN1Y2gsIHNlcGFyYXRlbHkg aW5pdCBtZW1iZXIgbWF4X25fc2hpZnQKPj4+IG9ubHkuCj4+Pgo+Pj4gSW4gYWRkaXRpb24sIHN0 cnVjdCAiaGVhZCIgaXMgaW5pdGlhbGlzZWQgdG8gImxscSIgb25seSBzbyB0aGF0IG1lbWJlcgo+ Pj4gbWF4X25fc2hpZnQgaXMgc2V0LiBCdXQgdGhhdCBtZW1iZXIgaXMgbmV2ZXIgcmVmZXJlbmNl ZCBmb3IgImhlYWQiLCBzbwo+Pj4gcmVtb3ZlIGFueSBpbml0IHRoZXJlLgo+Pj4KPj4+IFJlbW92 aW5nIHRoZXNlIGluaXRpYWxpemF0aW9ucyBpcyBzZWVuIGFzIGEgc21hbGwgcGVyZm9ybWFuY2Ug Cj4+PiBvcHRpbWlzYXRpb24sCj4+PiBhcyB0aGlzIGNvZGUgaXMgKHZlcnkpIGhvdCBwYXRoLgo+ Pgo+PiBJIGxvb2tlZCBhdCB0aGlzIGFuZCBpbW1lZGlhdGVseSB0aG91Z2h0ICJzdXJlbHkgdGhl IGNvbXBpbGVyIGNhbiBzZWUgCj4+IHRoYXQgYWxsIHRoZSBwcm9kL2NvbnMvdmFsIGZpZWxkcyBh cmUgd3JpdHRlbiBhbnl3YXkgYW5kIGVsaWRlIHRoZSAKPj4gaW5pdGlhbGlzYXRpb24/Iiwgc28g SSBkdW1wZWQgdGhlIGJlZm9yZSBhbmQgYWZ0ZXIgZGlzYXNzZW1ibHksIGFuZC4uLiAKPj4gb2gu Cj4+Cj4+IFlvdSBzaG91bGQgcHJvYmFibHkgY2xhcmlmeSB0aGF0IGl0J3MgemVyby1pbml0aWFs aXNpbmcgYWxsIHRoZSAKPj4gY2FjaGVsaW5lIHBhZGRpbmcgd2hpY2ggaXMgYm90aCBwb2ludGxl c3MgYW5kIHBhaW5mdWwuIFdpdGggdGhhdCwKPj4KPj4gUmV2aWV3ZWQtYnk6IFJvYmluIE11cnBo eSA8cm9iaW4ubXVycGh5QGFybS5jb20+Cj4+Cj4+IEhvd2V2ZXIsIGhhdmluZyBsb29rZWQgdGhp cyBjbG9zZWx5IEknbSBub3cgdGFuZ2VudGlhbGx5IHdvbmRlcmluZyB3aHkgCj4+IG1heF9uX3No aWZ0IGlzbid0IGluc2lkZSB0aGUgcGFkZGVkIHVuaW9uPyBJdCdzIHJlYWQgYXQgdGhlIHNhbWUg dGltZSAKPj4gYXMgYm90aCBwcm9kIGFuZCBjb25zIGJ5IHF1ZXVlX2hhc19zcGFjZSgpLCBhbmQg bmV2ZXIgdXBkYXRlZCwgc28gCj4+IHRoZXJlIGRvZXNuJ3QgYXBwZWFyIHRvIGJlIGFueSBiZW5l Zml0IHRvIGl0IGJlaW5nIGluIGEgc2VwYXJhdGUgCj4+IGNhY2hlbGluZSBhbGwgYnkgaXRzZWxm LCBhbmQgbGxxIGlzIGFscmVhZHkgdHdpY2UgYXMgYmlnIGFzIGl0IG5lZWRzIAo+PiB0byBiZS4K PiAKPiBJIHRoaW5rIHRoYXQgdGhlIHByb2JsZW0gaXMgaWYgdGhlIHByb2QrY29ucyA2NGIgdmFs dWUgYW5kIHRoZSBzaGlmdCBhcmUgCj4gb24gdGhlIHNhbWUgY2FjaGVsaW5lLCB0aGVuIHdlIGhh dmUgYSBjaGFuY2Ugb2YgYWNjZXNzaW5nIGEgc3RhbGUgCj4gY2FjaGVsaW5lIHR3aWNlOgo+IAo+ IHN0YXRpYyBpbnQgYXJtX3NtbXVfY21kcV9pc3N1ZV9jbWRsaXN0KHN0cnVjdCBhcm1fc21tdV9k ZXZpY2UgKnNtbXUsCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHU2NCAqY21kcywgaW50IG4sIGJvb2wgc3luYykKPiB7Cj4gIMKgwqDCoMKgdTY0IGNtZF9z eW5jW0NNRFFfRU5UX0RXT1JEU107Cj4gIMKgwqDCoMKgdTMyIHByb2Q7Cj4gIMKgwqDCoMKgdW5z aWduZWQgbG9uZyBmbGFnczsKPiAgwqDCoMKgwqBib29sIG93bmVyOwo+ICDCoMKgwqDCoHN0cnVj dCBhcm1fc21tdV9jbWRxICpjbWRxID0gJnNtbXUtPmNtZHE7Cj4gIMKgwqDCoMKgc3RydWN0IGFy bV9zbW11X2xsX3F1ZXVlIGxscSA9IHsKPiAgwqDCoMKgwqDCoMKgwqAgLm1heF9uX3NoaWZ0ID0g Y21kcS0+cS5sbHEubWF4X25fc2hpZnQswqDCoMKgIC8vIGhlcmUKPiAgwqDCoMKgwqB9LCBoZWFk ID0gbGxxOwo+ICDCoMKgwqDCoGludCByZXQgPSAwOwo+IAo+ICDCoMKgwqDCoC8qIDEuIEFsbG9j YXRlIHNvbWUgc3BhY2UgaW4gdGhlIHF1ZXVlICovCj4gIMKgwqDCoMKgbG9jYWxfaXJxX3NhdmUo ZmxhZ3MpOwo+ICDCoMKgwqDCoGxscS52YWwgPSBSRUFEX09OQ0UoY21kcS0+cS5sbHEudmFsKTvC oMKgwqAgLy8gYW5kIGFnYWluIGhlcmUKPiAKPiAKPiBzaW5jZSBjbWRxLT5xLmxscSBpcyBwZXIt U01NVS4gSWYgbWF4X25fc2hpZnQgaXMgb24gYSBzZXBhcmF0ZSAKPiBjYWNoZWxpbmUsIHRoZW4g aXQgc2hvdWxkIG5ldmVyIGJlIHN0YWxlLgoKQWgsIHJpZ2h0LCBldmVuIHRob3VnaCB0aGUgYWNj ZXNzZXMgYXJlIGFsd2F5cyBnb2luZyB0byBiZSBjbG9zZSAKdG9nZXRoZXIsIEkgc3VwcG9zZSBp dCBjb3VsZCBzdGlsbCB0ZWNobmljYWxseSBjYXVzZSBzb21lIGZhbHNlIHNoYXJpbmcgCmlmIHNv bWVvbmUgZWxzZSBpcyB0cnlpbmcgdG8gdXBkYXRlIHByb2QgYXQgZXhhY3RseSB0aGUgcmlnaHQg dGltZS4gSSAKZ3Vlc3MgdGhhdCBtaWdodCBiZSB3aHkgd2UgbmVlZCB0aGUgZXhwbGljaXQgcGFk ZGluZyB0aGVyZSBpbiB0aGUgZmlyc3QgCnBsYWNlLCBpdCdzIGp1c3QgYSBzaGFtZSB0aGF0IGl0 IGVuZHMgdXAgd2FzdGluZyBldmVuIG1vcmUgc3BhY2Ugd2l0aCAKaW1wbGljaXQgcGFkZGluZyBh dCB0aGUgZW5kIHRvbyAoYW5kIEkgaGF2ZSBhIHZhZ3VlIG1lbW9yeSB0aGF0IHRyeWluZyAKdG8g Zm9yY2UgbWVtYmVyIGFsaWdubWVudCBhbmQgc3RydWN0dXJlIHBhY2tpbmcgYXQgdGhlIHNhbWUg dGltZSBkb2Vzbid0IAp3b3JrIHdlbGwpLiBPaCB3ZWxsLgoKPiBJIHN1cHBvc2UgdGhleSBjb3Vs ZCBiZSBjb21iaW5lZCBpbnRvIGEgc21hbGxlciBzdWItc3RydWN0IGFuZCBsb2FkZWQgaW4gCj4g YSBzaW5nbGUgb3BlcmF0aW9uLCBidXQgaXQgbG9va3MgbWVzc3ksIGFuZCBwcm9iIHdpdGhvdXQg bXVjaCBnYWluLgoKSW5kZWVkIEkgd291bGRuJ3Qgc2F5IHRoYXQgc2F2aW5nIG1lbW9yeSBpcyB0 aGUgcHJpbWFyeSBjb25jZXJuIGhlcmUsIAphbmQgYW55IG1vcmUgY29udm9sdXRlZCBjb2RlIGlz IGhhcmRseSBnb2luZyB0byBoZWxwIHBlcmZvcm1hbmNlLiBQbHVzIAppdCBzdGlsbCB3b3VsZG4n dCBoZWxwIHRoZSBvdGhlciBjYXNlcyB3aGVyZSB3ZSdyZSBqdXN0IGNvcHlpbmcgdGhlIHNpemUg CmludG8gYSBmYWtlIHF1ZXVlIHRvIGRvIHNvbWUgcHJvZCBhcml0aG1ldGljIC0gSSBoYWRuJ3Qg ZnVsbHkgY2xvY2tlZCAKd2hhdCB3YXMgZ29pbmcgb24gdGhlcmUgd2hlbiBJIHNraW1tZWQgdGhy b3VnaCB0aGluZ3MgZWFybGllci4KCkRpc3JlZ2FyZGluZyB0aGUgYm9ndXMgbGF5b3V0IGNoYW5n ZSwgdGhvdWdoLCBkbyB5b3UgcmVja29uIHRoZSByZXN0IG9mIApteSBpZGVhIG1ha2VzIHNlbnNl PwoKQ2hlZXJzLApSb2Jpbi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK