From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: plaes@plaes.org, Philip Rinn <rinni@inventati.org>
Cc: Maxime Ripard <maxime@cerno.tech>, Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
Date: Thu, 13 Jan 2022 07:59:54 +0100 [thread overview]
Message-ID: <5782735.lOV4Wx5bFT@jernej-laptop> (raw)
In-Reply-To: <2e1a6b23-e713-7f2b-3634-5aa9b7724a50@inventati.org>
Hi,
Dne sreda, 12. januar 2022 ob 16:29:51 CET je Philip Rinn napisal(a):
> Hi,
>
> On 12.01.22 at 10:09, Priit Laes wrote:
>
> > On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi
> > wrote:
>
> >> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> >> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> >
> >
> > I have similar patch in one of my "long forgotten branches", but I'm not
> > 100%
sure whether the cpvdd-supply is required for codec_analog. IIRC,
> > sound worked for me without the issues on A64-Olinuxino board (Rev D).
> >
> > 'cpvdd-supply = <®_eldo1>' for codec_analog
>
>
> I didn't test it without but as it is present for all other a64 board with
> audio and also in Olimex' tree I think it is needed.
It's not question if it works with or without it, nor if other boards have it
or not. Only deciding factor is board design. On schematic it can be seen that
cpvdd is connected to eldo1, so having this property is correct, mandatory
even.
Best regards,
Jernej
>
> > And we also need to enable these configuration options in the defconfig:
> >
> > +CONFIG_SND_SUN8I_CODEC=m
> > +CONFIG_SND_SUN50I_CODEC_ANALOG=m
>
>
> Hm, probably, but why wasn't it added when audio was added for the other a64
> boards? Or are we talking about different defconfigs here?
> Best regards
> Philip
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-13 7:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 16:28 [PATCH v3] arm64: dts: allwinner: a64: olinuxino: Enable audio Philip Rinn
2021-12-28 20:28 ` Philip Rinn
2022-01-11 20:08 ` [PATCH RESEND " Philip Rinn
2022-01-12 8:48 ` Maxime Ripard
2022-01-12 15:49 ` Philip Rinn
2022-03-24 16:28 ` [linux-sunxi] " Philip Rinn
2022-03-26 6:45 ` Jernej Škrabec
2022-04-07 2:49 ` Samuel Holland
2022-04-07 5:02 ` Jernej Škrabec
2022-04-07 15:51 ` [PATCH v4] " Philip Rinn
2022-04-07 22:06 ` Samuel Holland
2022-04-10 18:23 ` Jernej Škrabec
2022-05-08 17:38 ` Milan P. Stanić
2022-01-12 9:09 ` [linux-sunxi] [PATCH RESEND v3] " Priit Laes
2022-01-12 15:29 ` Philip Rinn
2022-01-13 6:59 ` Jernej Škrabec [this message]
2022-01-13 16:37 ` Philip Rinn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5782735.lOV4Wx5bFT@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime@cerno.tech \
--cc=plaes@plaes.org \
--cc=rinni@inventati.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).