From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0779EC433F5 for ; Thu, 13 Jan 2022 07:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JDGKjFijCV8b0/4hh7yP0zbyCnSGEgcLbV+tGKENpNE=; b=XvwXYT7L+fe9iu I9yHocERZylTpFaOcPhuu0yQx1ZmRUiPJo+36uVzMClo2605nRU3umnr4QzsmiojebRWIBq7wWV/v QGyaSvItCNW8dAOGgXvl68j9igNjIH+AYRtl5ukZaLxpGkGFQiD4eGnrcG4c5SQxBC90X1teTbe6d HamrCxDi0GIeqzGikWXLVetH6FervWyNZxYug/iu1MnJ1X2waCjnoJv52EtDiwS/XanllfVEyln5v OO5L5HUhtgAAU2QyzDeX0ZVaYGRIy2td8aUNwgTcB5VS4XdosY/pIElLTK3vC6jrxWZ9VFtuCep87 IzXRgdQNH3eNOl8mh74g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7u5a-004tmx-Iy; Thu, 13 Jan 2022 07:00:02 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7u5W-004tl8-Ei for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 06:59:59 +0000 Received: by mail-wm1-x32e.google.com with SMTP id w26so3170113wmi.0 for ; Wed, 12 Jan 2022 22:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S6xUDskMCJPMG1TVoDVbiPkyRynSKI/+yRX0SV9efvI=; b=WlP77oJv8QM880MZulbW3dflsXY+AVtvx3qlPyDwj2o2/MSoLBx+ziHGLikZo0sOyz JIEiVBxOPO6eebV7Cn8gR303AMGSMU7Sz1A4fAJRSPKdLf+eY0R8nSTCWYiqqI7mpIQO zqMYSFLDD7Zq7Slvqqoe80SiJOTKfBdd5aliIf1fytemaBE/kR7ZI7DW/eN8srg74LeO gCIVh61XdPctm/sJd/gaAxCmYiQzWQmeuZHQrk5+tvrfrrUMGZEJErWRUGDZEC4LyvPH uB5fKC9DNXeUMwZi3WWESNRzHe4KCLIjohZaRSMrQShuM1Mj/V7EV4Qs9PaTSdT5TacI 9fnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S6xUDskMCJPMG1TVoDVbiPkyRynSKI/+yRX0SV9efvI=; b=lVukwxaPzIGVTn60JST2JyvyL/keGb1zW4no2/MFh561ivWtOAPkxpLr0W1RZamY9j OaFFmPVgYjfjfFnEaIGBJQVLHyUkglY6sVANlZlqerzdUqyAE1O4P5owxE5IKa2pa0ff 2gJhMa+71CVOTt6XDYa0w07jmmTwjVcZ1XcBcNyHeGLWjToJ+WsRxqUMne1Uf/+AV/ZX 5FMeNSiz/GV4LDJ8b4QIrsCGmbUgPmjMegSAb9xPRI1NcADWkMgXmXBcdc+qu1jOZWbM jFXtvDP+BWyeOPRXxrJ2PfT4m0jCxkpoZdBNZzRUWQRVu5jL39xMD2GW3xSiphtG0IEl 5D6A== X-Gm-Message-State: AOAM530S8hAJYiJUN6XFOd1Vdx3kZ2kgDpLk1Jvl3TQZtZtcluriab2C tjTO0leWDigftKqyRfpElLo= X-Google-Smtp-Source: ABdhPJyGs/QwJX8VFII0uCVyyDcbawm2Rz8bTRllc9SZ+St1T8LSnOyNF8c1QNYtiojsN0Ngn6Ci4w== X-Received: by 2002:a1c:2544:: with SMTP id l65mr10008958wml.101.1642057196403; Wed, 12 Jan 2022 22:59:56 -0800 (PST) Received: from jernej-laptop.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id n4sm1763799wrc.1.2022.01.12.22.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 22:59:55 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: plaes@plaes.org, Philip Rinn Cc: Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, "linux-sunxi@googlegroups.com" Subject: Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio Date: Thu, 13 Jan 2022 07:59:54 +0100 Message-ID: <5782735.lOV4Wx5bFT@jernej-laptop> In-Reply-To: <2e1a6b23-e713-7f2b-3634-5aa9b7724a50@inventati.org> References: <2e1a6b23-e713-7f2b-3634-5aa9b7724a50@inventati.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_225958_542598_8B6D460E X-CRM114-Status: GOOD ( 21.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Dne sreda, 12. januar 2022 ob 16:29:51 CET je Philip Rinn napisal(a): > Hi, > > On 12.01.22 at 10:09, Priit Laes wrote: > > > On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi > > wrote: > > >> Enable the audio hardware on the Olimex A64-OLinuXino board family. > >> Tested on the A64-OLinuXino-2Ge8G-IND variant. > > > > > > I have similar patch in one of my "long forgotten branches", but I'm not > > 100% sure whether the cpvdd-supply is required for codec_analog. IIRC, > > sound worked for me without the issues on A64-Olinuxino board (Rev D). > > > > 'cpvdd-supply = <®_eldo1>' for codec_analog > > > I didn't test it without but as it is present for all other a64 board with > audio and also in Olimex' tree I think it is needed. It's not question if it works with or without it, nor if other boards have it or not. Only deciding factor is board design. On schematic it can be seen that cpvdd is connected to eldo1, so having this property is correct, mandatory even. Best regards, Jernej > > > And we also need to enable these configuration options in the defconfig: > > > > +CONFIG_SND_SUN8I_CODEC=m > > +CONFIG_SND_SUN50I_CODEC_ANALOG=m > > > Hm, probably, but why wasn't it added when audio was added for the other a64 > boards? Or are we talking about different defconfigs here? > Best regards > Philip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel