From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FDCA606A324 for ; Mon, 2 Nov 2026 14:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=OMrNbj2Z; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=diI04PxX DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=rrDt8/qG+jvKZq+V2MNsQBcgRe5gnhLdJ83DrJanIU0=; b=OMrNbj2Zwu++NP iggZEey8ThmyATTApn8cfkCZ1LLyBaDJooOc6TtZVqA8F+ykNXVxf6f2GylVrzdEs2n6SWO7eHhpN KwsSc3sDNsFAycjeYeThwjc0MDPsHGbngpB1rtaYLxfNJSPyj4KtmGW5ifO553bdfz49DvgQsLsrc hRzmMxsr7qqUJuZiBXPbbZkeXUbmK/uxAPeQgqadeJ32KVXXF8/HaVWqvPofQZSKWVnDosZygwPnG ZkBLHly/arKhUBOxHEAqAAdv+o9q+ZDtlfGiwwejzGdpawntmocO74G1CMS+owkO0uehlFFk0wE21 m8ONptkYxdsH8sQBglow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNscJ-0000000GhnI-08au; Mon, 02 Nov 2026 14:02:31 +0000 Received: from out-212.mta1.migadu.com ([2001:41d0:203:375::d4] helo=mta1.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNscE-0000000GhkO-1eeL for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2026 14:02:29 +0000 X-Envelope-To: linux-arm-kernel@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=+GKTSizLrrZQBsZt056y5c/KPEn+gWcclfGVamWBXAE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793628142; v=1; x=1794232942; b=diI04PxXwN1bLWx1nMktOW2LeCn+YIgEwUt2DkT3/JN4sWWuaGYkfWWEWYuAAZsvFENMJcmA B9qO3Yf5OlGidKY+VkftWe7g0rZWcqXw4OiZTME6aDAfAaut2SOH8zaQt6bvw8EPil8xbkaGAYx Kbr4JZUPTAF8cR26/HzXTLg0= X-Envelope-To: linux-arm-kernel@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 308c65e25e6731cd; Mon, 02 Nov 2026 14:02:14 +0000 X-Mizu-Trace-ID: 308c65e25e6731cd X-Migadu-Flow: FLOW_OUT Message-ID: <5782a7a2-3fb4-4d74-aae9-e1ff0d0d4393@linux.dev> Date: Mon, 2 Nov 2026 14:02:13 +0000 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/14] drm/tidss: Add support for AM62P display subsystem To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Nishanth Menon , Vignesh Raghavendra , Swamil Jain , Devarsh Thakkar , Louis Chauvet Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20261029-beagley-ai-display-v4-0-dc7f2b532478@ideasonboard.com> <20261029-beagley-ai-display-v4-12-dc7f2b532478@ideasonboard.com> Content-Language: en-US From: Aradhya Bhatia In-Reply-To: <20261029-beagley-ai-display-v4-12-dc7f2b532478@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261102_060226_586561_11A02629 X-CRM114-Status: GOOD ( 19.88 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi Tomi, On 29/10/26 10:18, Tomi Valkeinen wrote: > From: Swamil Jain > > The DSS controller on TI's AM62P SoC features two instances of the TI > DSS. Each DSS instance supports two video ports, similar to the DSS > controller found on the TI AM62X SoC. This allows three independent > video streams to be supported: OLDI, DPI, and DSI. > > Since the DSS instances on AM62P are architecturally similar to those > on the AM62X DSS controller, the existing dispc_am625_feats > configuration can be reused for the AM62P DSS support. > > This commit adds the necessary device tree compatibility entry for > "ti,am62p-dss" in the tidss driver, pointing to dispc_am625_feats, > thereby enabling DSS support on AM62P devices. > > Signed-off-by: Swamil Jain > Signed-off-by: Tomi Valkeinen Reviewed-by: Aradhya Bhatia > --- > drivers/gpu/drm/tidss/tidss_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c > index 44b0b009c29a..8e3cbfb5ef87 100644 > --- a/drivers/gpu/drm/tidss/tidss_drv.c > +++ b/drivers/gpu/drm/tidss/tidss_drv.c > @@ -240,6 +240,7 @@ static const struct of_device_id tidss_of_table[] = { > { .compatible = "ti,am625-dss", .data = &dispc_am625_feats, }, > { .compatible = "ti,am62a7-dss", .data = &dispc_am62a7_feats, }, On a separate note, Now that `vp_bus_type` support has been dropped, the only thing different `dispc_am62a7_feats` has from `dispc_am625_feats` is the subrev macro. The DSS in AM62A7 SoC is functionally same with that in AM625 SoC; the only difference being the absence of both the OLDI TXes in AM62A7. The dt-bindings enforce that rule. The only place subrev DISPC_AM625 is used, and subrev DISPC_AM62A7 is not, is for an OLDI reset done log print. if (dispc->feat->subrev == DISPC_AM625 || dispc->feat->subrev == DISPC_AM65X) dev_dbg(dispc->dev, "OLDI RESETDONE %d,%d,%d\n", REG_GET(dispc, DSS_SYSSTATUS, GENMASK(5, 5)), REG_GET(dispc, DSS_SYSSTATUS, GENMASK(6, 6)), REG_GET(dispc, DSS_SYSSTATUS, GENMASK(7, 7))); Should we consider some workaround for this print, so that we can entirely drop `dispc_am62a7_feats`? -- Regards Aradhya