From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14D1EC4345F for ; Mon, 6 May 2024 06:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y4Bqyg3btdsCaNUmqygKavRjNB1muo88bipAIJPrgN8=; b=qI/F7FnNvz/PMx medQHowmTHD4p736q+eKYeq1O4zyuRz8YU+jqQ6N1eAidTR5xpRnbT5xxapFokOAAS3GHvje4bGM7 YQx/udmJ3QiMffCWn1Xa9gOComz6m6zeoOTPQjbw13gL5+1Q5anDfYRoQPRjOL9JzgHX3ziuUoKak LuC+V3hGVLGFg6/lzT0tgAFTLBFKcfMkwKx+5KtGeSc5OWJH94GXgOTu+zc2cFbnfaEMSUfDphDx3 llhes+zRb9qHN5irACTrFKIpTeN7CBS7ENRAmmMzm1PJbL6yASlEWqHvUnHHGH0FCQWHRTGRgg9rw CJBD9NP0DRGlLD0DqTqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3rhm-00000006HRI-2jZm; Mon, 06 May 2024 06:20:06 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3rhi-00000006HPW-45vI for linux-arm-kernel@lists.infradead.org; Mon, 06 May 2024 06:20:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1714976403; x=1746512403; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2KOgeH5FtSg96AKSLg0bxhcztOJxyjb2Q/p7HPjcZGc=; b=l/yEDV0oby4QjMiZLgoDeTKZarLU4YmbcoZVTlck7+l7CDCuaLovmfHK +LWibDSUuqEVX5f8EET5eOY3Ga/RFmrAhS9k1NkNQdMAbtyd1F7pZYSB1 AwnGs+rw4Y0z/ZiwRgpaZukgLVhp00jQ4dWjRbo9gTgt09MIErREzqHcj 6BPCXKlXZ+nKQQwRv/Pfcm8xGqRm0TDR0gA91ISggsaMnKqsuSIZjOyh9 g9SfALc/c63l3f6e5I3mDr6ygEHQB6ExjngIkcjOdJpMQdxO3e0/81L6I oRaJdVmAv9/pd9TaqaHnlCzv4MoJVl8FZypTGBEn0MXDKX3o0MDgw9lw3 w==; X-CSE-ConnectionGUID: BB0jHhSwRgCSyHDG/5irEA== X-CSE-MsgGUID: oQ9oM6zfT2u9m2bUD3KvsQ== X-IronPort-AV: E=Sophos;i="6.07,257,1708383600"; d="scan'208";a="36751950" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 06 May 2024 08:19:57 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 251651700C1; Mon, 6 May 2024 08:19:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1714976393; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=2KOgeH5FtSg96AKSLg0bxhcztOJxyjb2Q/p7HPjcZGc=; b=Y4yZYrGR7Ldui6BZLOhiY3mvMYE8Mm24INnUdDW6l/9e8Q6RlUgXpky8mIok5F+BUmqhsK USI5Z6XlxvmDNXkYDYOHRkpsr7An23Hlb8s3Robrkr/BTaeTvA36mJDvQ3sYiB2XImlhjb WGmgVXciYXsHQopREcC0VeDvWxA0jfDb45POgcPWL4fiOHrUFrEhxEtTrPAH8pC98egL6K 5K/Yoaj2XLjeyjTWfK/FQNxbakvaB3e8nmzdffRhSS+TbdWGrpGks7JvKHn4PhyKjTNEl4 AshfFmN3zZuZ7EKiASvwjqFyoa49tz7+Ej6VHcJdqRAkexXEb2cGB9p2b3bedw== From: Alexander Stein To: Laurent Pinchart Cc: linux-arm-kernel@lists.infradead.org, Marek Vasut , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Paul Elder , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock Date: Mon, 06 May 2024 08:19:57 +0200 Message-ID: <5784573.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240503134557.GC13904@pendragon.ideasonboard.com> References: <20240416141914.9375-1-marex@denx.de> <3311352.aeNJFYEL58@steina-w> <20240503134557.GC13904@pendragon.ideasonboard.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240505_232003_518303_5512C8CF X-CRM114-Status: GOOD ( 29.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 3. Mai 2024, 15:45:57 CEST schrieb Laurent Pinchart: > On Fri, May 03, 2024 at 02:58:19PM +0200, Alexander Stein wrote: > > Am Mittwoch, 17. April 2024, 11:12:04 CEST schrieb Alexander Stein: > > > Am Dienstag, 16. April 2024, 16:19:10 CEST schrieb Marek Vasut: > > > > Configure both CSI2 assigned-clock-rates the same way. > > > > There does not seem to be any reason for keeping the > > > > two CSI2 pixel clock set to different frequencies. > > > > = > > > > This also reduces first CSI2 clock from overdrive mode > > > > frequency which is 500 MHz down below the regular mode > > > > frequency of 400 MHz. > > > > = > > > > Signed-off-by: Marek Vasut > > > = > > > Apparently there is no difference when using imx415 (3840x2160) senso= r. > > = > > Just for the records: While this change does not affect imx415 (3840x21= 60) > > processing, reducing clock-frequency as well (v3) imx415 does not work. > > So I assume that for this image size a higher than default frequency is > > required. > = > For the time being I expect sensor overlays to override the default > clock setup. Yep, that's what I did in the end. > Ideally the clock frequencies should be configured > automatically at runtime by the CSI-2 RX driver. Ideally, yes. In this case it depends on whether it is MIPI-CSI 1 in normal or overdrive mode, if it is MIPI-CSI 2 or if both cameras a run simultaneously. I wonder if it really worth to add that much infrastructure for a use case which is essentially fixed setup. Best regards, Alexander > > > Reviewed-by: Alexander Stein > > > = > > > > --- > > > > Cc: Conor Dooley > > > > Cc: Fabio Estevam > > > > Cc: Krzysztof Kozlowski > > > > Cc: Laurent Pinchart > > > > Cc: Paul Elder > > > > Cc: Pengutronix Kernel Team > > > > Cc: Rob Herring > > > > Cc: Sascha Hauer > > > > Cc: Shawn Guo > > > > Cc: devicetree@vger.kernel.org > > > > Cc: imx@lists.linux.dev > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > --- > > > > V2: Align both clock to 266 MHz and update commit message > > > > --- > > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > = > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64= /boot/dts/freescale/imx8mp.dtsi > > > > index 1bb96e96639f2..7883f5c056f4e 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > @@ -1667,7 +1667,7 @@ mipi_csi_0: csi@32e40000 { > > > > <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > > > > assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL2_1000M>, > > > > <&clk IMX8MP_CLK_24M>; > > > > - assigned-clock-rates =3D <500000000>; > > > > + assigned-clock-rates =3D <266000000>; > > > > power-domains =3D <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI= 2_1>; > > > > status =3D "disabled"; > > > > = > > > > = > = > = -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel