From: stillcompiling@gmail.com (Joshua Clayton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/3] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK
Date: Thu, 14 Jul 2016 10:01:12 -0700 [thread overview]
Message-ID: <5787C558.5060904@gmail.com> (raw)
In-Reply-To: <1468235521-3163-3-git-send-email-p.zabel@pengutronix.de>
Hi Philipp,
My team is testing this morning on a board that exhibits
intermittent lvds failures that seem to match this problem.
(black screen and a "dc stop timeout" message in the kernel log)
With this patch set, the screen failed to come up on the second boot :(
But...
On 07/11/2016 04:12 AM, Philipp Zabel wrote:
> +static void init_ldb_clks(struct device_node *np, void __iomem *ccm_base)
> +{
> + unsigned int reg;
> + unsigned int sel[2][4];
> + int i;
> +
to feel confident the new code was running, one of our engineers added the line
pr_warn("ccm: In init_ldb_clks\n");
right here.
> + reg = readl_relaxed(ccm_base + CCM_CS2CDR);
> + sel[0][0] = (reg >> CS2CDR_LDB_DI0_CLK_SEL_SHIFT) & 7;
> + sel[1][0] = (reg >> CS2CDR_LDB_DI1_CLK_SEL_SHIFT) & 7;
> +
> + sel[0][3] = sel[0][2] = sel[0][1] = sel[0][0];
> + sel[1][3] = sel[1][2] = sel[1][1] = sel[1][0];
> +
> + of_assigned_ldb_sels(np, &sel[0][3], &sel[1][3]);
>
...
We have now booted that same board successfully about 30 times
with your patches plus the extra printf .?!??
Not sure what that means in terms of delay and synchronization, so
even though we are not finished testing I thought I should post that result.
Thanks,
Joshua Clayton
next prev parent reply other threads:[~2016-07-14 17:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 11:11 [PATCH v5 1/3] clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and mmdc_ch1_axi_podf Philipp Zabel
2016-07-11 11:12 ` [PATCH v5 2/3] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only Philipp Zabel
2016-07-11 11:12 ` [PATCH v5 3/3] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK Philipp Zabel
2016-07-11 14:41 ` Akshay Bhat
2016-07-12 17:00 ` Fabio Estevam
2016-07-14 17:01 ` Joshua Clayton [this message]
2016-07-16 20:55 ` Joshua Clayton
2016-07-19 11:13 ` Fabio Estevam
2016-09-12 15:09 ` Akshay Bhat
2016-09-12 15:15 ` Fabio Estevam
2016-09-16 1:36 ` Shawn Guo
2016-09-16 14:33 ` Fabio Estevam
2016-09-16 14:42 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787C558.5060904@gmail.com \
--to=stillcompiling@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).