From mboxrd@z Thu Jan  1 00:00:00 1970
From: ldewangan@nvidia.com (Laxman Dewangan)
Date: Fri, 15 Jul 2016 18:39:39 +0530
Subject: [PATCH 1/3] mfd: Provide MACRO to declare commonly defined MFD
 cell attributes
In-Reply-To: <20160713112651.14539-2-lee.jones@linaro.org>
References: <20160713112651.14539-1-lee.jones@linaro.org>
 <20160713112651.14539-2-lee.jones@linaro.org>
Message-ID: <5788E093.7080405@nvidia.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org


On Wednesday 13 July 2016 04:56 PM, Lee Jones wrote:
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   include/linux/mfd/core.h | 29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index 99c0395..c6018f4 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -16,6 +16,35 @@
>   
>   #include <linux/platform_device.h>

> +#define MFD_CELL_BASIC(_name, _res, _pdata, _pdsize, _id)		\
> +	MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, NULL)	\
> +
> +#define MFD_CELL_RES(_name, _res)					\
> +	MFD_CELL_ALL(_name, _res, _pdata, 0, 0, NULL, NULL)		\
> +
Here _pdata should not be used. Instead it should be NULL.

I corrected it locally and then compiled and teste.

Once above fixed, you can take my ack and tested by

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Tested-by: Laxman Dewangan <ldewangan@nvidia.com>