linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
@ 2016-08-11 16:54 Joshua Clayton
  2016-08-11 17:09 ` Stefan Wahren
  0 siblings, 1 reply; 5+ messages in thread
From: Joshua Clayton @ 2016-08-11 16:54 UTC (permalink / raw)
  To: linux-arm-kernel

Apply hardware workaround for ethernet problem
See nxp erratum err006687

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
 arch/arm/boot/dts/imx6q-evi.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
index 49c6f61..33bd04b 100644
--- a/arch/arm/boot/dts/imx6q-evi.dts
+++ b/arch/arm/boot/dts/imx6q-evi.dts
@@ -127,6 +127,8 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii";
 	phy-reset-gpios = <&gpio1 25 0>;
+	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
+			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
 	status = "okay";
 };
 
@@ -312,6 +314,7 @@
 			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
 			MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x4001b0a8
 			MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
+			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
 		>;
 	};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
  2016-08-11 16:54 [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq Joshua Clayton
@ 2016-08-11 17:09 ` Stefan Wahren
  2016-08-11 17:23   ` Joshua Clayton
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Wahren @ 2016-08-11 17:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Joshua,

> Joshua Clayton <stillcompiling@gmail.com> hat am 11. August 2016 um 18:54
> geschrieben:
> 
> 
> Apply hardware workaround for ethernet problem
> See nxp erratum err006687

do you know this commit?

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a28eeb43ee57e0524c59e64760ed28088dd159cb

Maybe you want to add this property, too.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
  2016-08-11 17:09 ` Stefan Wahren
@ 2016-08-11 17:23   ` Joshua Clayton
  2016-08-11 17:35     ` [PATCH V2 " Joshua Clayton
  0 siblings, 1 reply; 5+ messages in thread
From: Joshua Clayton @ 2016-08-11 17:23 UTC (permalink / raw)
  To: linux-arm-kernel

Stefan,

On 08/11/2016 10:09 AM, Stefan Wahren wrote:
> Hi Joshua,
>
>> Joshua Clayton <stillcompiling@gmail.com> hat am 11. August 2016 um 18:54
>> geschrieben:
>>
>>
>> Apply hardware workaround for ethernet problem
>> See nxp erratum err006687
> do you know this commit?
>
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a28eeb43ee57e0524c59e64760ed28088dd159cb
>
> Maybe you want to add this property, too.
I missed that this change requiring (more) explicit enablement was merge to linux-next.
I'll add that.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
  2016-08-11 17:23   ` Joshua Clayton
@ 2016-08-11 17:35     ` Joshua Clayton
  2016-08-15 14:30       ` Shawn Guo
  0 siblings, 1 reply; 5+ messages in thread
From: Joshua Clayton @ 2016-08-11 17:35 UTC (permalink / raw)
  To: linux-arm-kernel

Apply hardware workaround for ethernet problem
See nxp erratum err006687

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---

Changed since V1:
- added fsl,err006687-workaround-present; so that it will continue to work

 arch/arm/boot/dts/imx6q-evi.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
index 49c6f61..33bd04b 100644
--- a/arch/arm/boot/dts/imx6q-evi.dts
+++ b/arch/arm/boot/dts/imx6q-evi.dts
@@ -127,6 +127,8 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii";
 	phy-reset-gpios = <&gpio1 25 0>;
+	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
+			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
+	fsl,err006687-workaround-present;
 	status = "okay";
 };
 
@@ -312,6 +314,7 @@
 			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
 			MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x4001b0a8
 			MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
+			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
 		>;
 	};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq
  2016-08-11 17:35     ` [PATCH V2 " Joshua Clayton
@ 2016-08-15 14:30       ` Shawn Guo
  0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2016-08-15 14:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Aug 11, 2016 at 10:35:16AM -0700, Joshua Clayton wrote:
> Apply hardware workaround for ethernet problem
> See nxp erratum err006687
> 
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-08-15 14:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-11 16:54 [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq Joshua Clayton
2016-08-11 17:09 ` Stefan Wahren
2016-08-11 17:23   ` Joshua Clayton
2016-08-11 17:35     ` [PATCH V2 " Joshua Clayton
2016-08-15 14:30       ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).