* [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
@ 2016-08-16 19:45 Linus Walleij
2016-08-16 22:19 ` Bjorn Andersson
2016-08-17 21:40 ` Jacek Anaszewski
0 siblings, 2 replies; 5+ messages in thread
From: Linus Walleij @ 2016-08-16 19:45 UTC (permalink / raw)
To: linux-arm-kernel
This adds the PM8058 LEDs as used in the platform.
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-leds at vger.kernel.org
Cc: Andy Gross <andy.gross@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
These DT bindings have been ACKed by Rob Herring and Bjorn Andersson
so I think the patch is safe to merge to the Qcom tree.
---
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
index 0abc93e5bb00..b0800b988174 100644
--- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
@@ -239,6 +239,45 @@
};
};
};
+
+ led at 48 {
+ /*
+ * The keypad LED @0x48 is routed to
+ * the sensor board where it is
+ * connected to an infrared LED
+ * SFH4650 (60mW, @850nm) next to the
+ * ambient light and proximity sensor
+ * Capella Microsystems CM3605.
+ */
+ compatible = "qcom,pm8058-keypad-led";
+ reg = <0x48>;
+ label = "proximity0";
+ default-state = "off";
+ };
+ led at 131 {
+ compatible = "qcom,pm8058-led";
+ reg = <0x131>;
+ label = "pm8058:red";
+ default-state = "off";
+ };
+ led at 132 {
+ /*
+ * This is actually green too on my
+ * board, but documented as yellow.
+ */
+ compatible = "qcom,pm8058-led";
+ reg = <0x132>;
+ label = "pm8058:yellow";
+ default-state = "off";
+ linux,default-trigger = "mmc0";
+ };
+ led at 133 {
+ compatible = "qcom,pm8058-led";
+ reg = <0x133>;
+ label = "pm8058:green";
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
2016-08-16 19:45 [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard Linus Walleij
@ 2016-08-16 22:19 ` Bjorn Andersson
2016-08-17 21:40 ` Jacek Anaszewski
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2016-08-16 22:19 UTC (permalink / raw)
To: linux-arm-kernel
On Tue 16 Aug 12:45 PDT 2016, Linus Walleij wrote:
> This adds the PM8058 LEDs as used in the platform.
>
> Cc: linux-arm-msm at vger.kernel.org
> Cc: linux-leds at vger.kernel.org
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> These DT bindings have been ACKed by Rob Herring and Bjorn Andersson
> so I think the patch is safe to merge to the Qcom tree.
> ---
> arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 0abc93e5bb00..b0800b988174 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -239,6 +239,45 @@
> };
> };
> };
> +
> + led at 48 {
> + /*
> + * The keypad LED @0x48 is routed to
> + * the sensor board where it is
> + * connected to an infrared LED
> + * SFH4650 (60mW, @850nm) next to the
> + * ambient light and proximity sensor
> + * Capella Microsystems CM3605.
> + */
> + compatible = "qcom,pm8058-keypad-led";
> + reg = <0x48>;
> + label = "proximity0";
> + default-state = "off";
> + };
> + led at 131 {
> + compatible = "qcom,pm8058-led";
> + reg = <0x131>;
> + label = "pm8058:red";
> + default-state = "off";
> + };
> + led at 132 {
> + /*
> + * This is actually green too on my
> + * board, but documented as yellow.
> + */
> + compatible = "qcom,pm8058-led";
> + reg = <0x132>;
> + label = "pm8058:yellow";
> + default-state = "off";
> + linux,default-trigger = "mmc0";
> + };
> + led at 133 {
> + compatible = "qcom,pm8058-led";
> + reg = <0x133>;
> + label = "pm8058:green";
> + default-state = "on";
> + linux,default-trigger = "heartbeat";
> + };
> };
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
2016-08-16 19:45 [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard Linus Walleij
2016-08-16 22:19 ` Bjorn Andersson
@ 2016-08-17 21:40 ` Jacek Anaszewski
2016-08-18 13:10 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Jacek Anaszewski @ 2016-08-17 21:40 UTC (permalink / raw)
To: linux-arm-kernel
On 08/16/2016 09:45 PM, Linus Walleij wrote:
> This adds the PM8058 LEDs as used in the platform.
>
> Cc: linux-arm-msm at vger.kernel.org
> Cc: linux-leds at vger.kernel.org
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> These DT bindings have been ACKed by Rob Herring and Bjorn Andersson
> so I think the patch is safe to merge to the Qcom tree.
> ---
> arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 0abc93e5bb00..b0800b988174 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -239,6 +239,45 @@
> };
> };
> };
> +
> + led at 48 {
> + /*
> + * The keypad LED @0x48 is routed to
> + * the sensor board where it is
> + * connected to an infrared LED
> + * SFH4650 (60mW, @850nm) next to the
> + * ambient light and proximity sensor
> + * Capella Microsystems CM3605.
> + */
> + compatible = "qcom,pm8058-keypad-led";
> + reg = <0x48>;
> + label = "proximity0";
In DT bindings documentation it was changed to "pm8050:white:keypad" to
adhere to the LED class device naming convention. I assume that having
it in this form is an omission here.
> + default-state = "off";
> + };
> + led at 131 {
> + compatible = "qcom,pm8058-led";
> + reg = <0x131>;
> + label = "pm8058:red";
> + default-state = "off";
> + };
> + led at 132 {
> + /*
> + * This is actually green too on my
> + * board, but documented as yellow.
> + */
> + compatible = "qcom,pm8058-led";
> + reg = <0x132>;
> + label = "pm8058:yellow";
> + default-state = "off";
> + linux,default-trigger = "mmc0";
> + };
> + led at 133 {
> + compatible = "qcom,pm8058-led";
> + reg = <0x133>;
> + label = "pm8058:green";
> + default-state = "on";
> + linux,default-trigger = "heartbeat";
> + };
> };
> };
>
>
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
2016-08-17 21:40 ` Jacek Anaszewski
@ 2016-08-18 13:10 ` Linus Walleij
2016-08-18 19:47 ` Jacek Anaszewski
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2016-08-18 13:10 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
<jacek.anaszewski@gmail.com> wrote:
>> + led at 48 {
>> + /*
>> + * The keypad LED @0x48 is routed
>> to
>> + * the sensor board where it is
>> + * connected to an infrared LED
>> + * SFH4650 (60mW, @850nm) next to
>> the
>> + * ambient light and proximity
>> sensor
>> + * Capella Microsystems CM3605.
>> + */
>> + compatible =
>> "qcom,pm8058-keypad-led";
>> + reg = <0x48>;
>> + label = "proximity0";
>
>
> In DT bindings documentation it was changed to "pm8050:white:keypad" to
> adhere to the LED class device naming convention. I assume that having
> it in this form is an omission here.
Hm right. Given the usecase here, what do you say about naming
it:
"pm8058:infrared:proximitysensor"
?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
2016-08-18 13:10 ` Linus Walleij
@ 2016-08-18 19:47 ` Jacek Anaszewski
0 siblings, 0 replies; 5+ messages in thread
From: Jacek Anaszewski @ 2016-08-18 19:47 UTC (permalink / raw)
To: linux-arm-kernel
On 08/18/2016 03:10 PM, Linus Walleij wrote:
> On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
> <jacek.anaszewski@gmail.com> wrote:
>
>>> + led at 48 {
>>> + /*
>>> + * The keypad LED @0x48 is routed
>>> to
>>> + * the sensor board where it is
>>> + * connected to an infrared LED
>>> + * SFH4650 (60mW, @850nm) next to
>>> the
>>> + * ambient light and proximity
>>> sensor
>>> + * Capella Microsystems CM3605.
>>> + */
>>> + compatible =
>>> "qcom,pm8058-keypad-led";
>>> + reg = <0x48>;
>>> + label = "proximity0";
>>
>>
>> In DT bindings documentation it was changed to "pm8050:white:keypad" to
>> adhere to the LED class device naming convention. I assume that having
>> it in this form is an omission here.
>
> Hm right. Given the usecase here, what do you say about naming
> it:
>
> "pm8058:infrared:proximitysensor"
Looks good.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-18 19:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-16 19:45 [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard Linus Walleij
2016-08-16 22:19 ` Bjorn Andersson
2016-08-17 21:40 ` Jacek Anaszewski
2016-08-18 13:10 ` Linus Walleij
2016-08-18 19:47 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).