* [PATCH] ARM: mm: pull asm/memory.h explicitly
@ 2016-08-17 16:17 Vladimir Murzin
2016-08-18 14:22 ` Russell King - ARM Linux
0 siblings, 1 reply; 4+ messages in thread
From: Vladimir Murzin @ 2016-08-17 16:17 UTC (permalink / raw)
To: linux-arm-kernel
Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when
XIP_KERNEL"") introduced a macro which lives under asm/memory.h.
Unfortunately, for MMU-less systems (like R-class) it leads to build failure:
arch/arm/mm/proc-v7.S: Assembler messages:
arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix
make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
make: *** [arch/arm/mm] Error 2
since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.
To fix it include asm/memory.h explicitly.
Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---
arch/arm/mm/proc-v7.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index d0b116c..8cb105b 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -16,6 +16,7 @@
#include <asm/hwcap.h>
#include <asm/pgtable-hwdef.h>
#include <asm/pgtable.h>
+#include <asm/memory.h>
#include "proc-macros.S"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: mm: pull asm/memory.h explicitly
2016-08-17 16:17 [PATCH] ARM: mm: pull asm/memory.h explicitly Vladimir Murzin
@ 2016-08-18 14:22 ` Russell King - ARM Linux
2016-08-18 14:32 ` Vladimir Murzin
0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux @ 2016-08-18 14:22 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 17, 2016 at 05:17:14PM +0100, Vladimir Murzin wrote:
> Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when
> XIP_KERNEL"") introduced a macro which lives under asm/memory.h.
> Unfortunately, for MMU-less systems (like R-class) it leads to build failure:
>
> arch/arm/mm/proc-v7.S: Assembler messages:
> arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix
> make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
> make: *** [arch/arm/mm] Error 2
>
> since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.
>
> To fix it include asm/memory.h explicitly.
>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
Looks fine, thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: mm: pull asm/memory.h explicitly
2016-08-18 14:22 ` Russell King - ARM Linux
@ 2016-08-18 14:32 ` Vladimir Murzin
2016-08-18 15:11 ` Russell King - ARM Linux
0 siblings, 1 reply; 4+ messages in thread
From: Vladimir Murzin @ 2016-08-18 14:32 UTC (permalink / raw)
To: linux-arm-kernel
On 18/08/16 15:22, Russell King - ARM Linux wrote:
> On Wed, Aug 17, 2016 at 05:17:14PM +0100, Vladimir Murzin wrote:
>> Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when
>> XIP_KERNEL"") introduced a macro which lives under asm/memory.h.
>> Unfortunately, for MMU-less systems (like R-class) it leads to build failure:
>>
>> arch/arm/mm/proc-v7.S: Assembler messages:
>> arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix
>> make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
>> make: *** [arch/arm/mm] Error 2
>>
>> since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.
>>
>> To fix it include asm/memory.h explicitly.
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>
> Looks fine, thanks.
>
Should I drop it into patch system?
Cheers
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: mm: pull asm/memory.h explicitly
2016-08-18 14:32 ` Vladimir Murzin
@ 2016-08-18 15:11 ` Russell King - ARM Linux
0 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2016-08-18 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 18, 2016 at 03:32:29PM +0100, Vladimir Murzin wrote:
> On 18/08/16 15:22, Russell King - ARM Linux wrote:
> > On Wed, Aug 17, 2016 at 05:17:14PM +0100, Vladimir Murzin wrote:
> >> Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when
> >> XIP_KERNEL"") introduced a macro which lives under asm/memory.h.
> >> Unfortunately, for MMU-less systems (like R-class) it leads to build failure:
> >>
> >> arch/arm/mm/proc-v7.S: Assembler messages:
> >> arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix
> >> make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
> >> make: *** [arch/arm/mm] Error 2
> >>
> >> since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.
> >>
> >> To fix it include asm/memory.h explicitly.
> >>
> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> >
> > Looks fine, thanks.
> >
>
> Should I drop it into patch system?
Yes please.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-18 15:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 16:17 [PATCH] ARM: mm: pull asm/memory.h explicitly Vladimir Murzin
2016-08-18 14:22 ` Russell King - ARM Linux
2016-08-18 14:32 ` Vladimir Murzin
2016-08-18 15:11 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).