From: jacek.anaszewski@gmail.com (Jacek Anaszewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
Date: Thu, 18 Aug 2016 21:47:13 +0200 [thread overview]
Message-ID: <57B610C1.6030000@gmail.com> (raw)
In-Reply-To: <CACRpkdYHu1rj81=_miq6Rtb+mkbdPSvULau0ojDC74wPo7hDAg@mail.gmail.com>
On 08/18/2016 03:10 PM, Linus Walleij wrote:
> On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
> <jacek.anaszewski@gmail.com> wrote:
>
>>> + led at 48 {
>>> + /*
>>> + * The keypad LED @0x48 is routed
>>> to
>>> + * the sensor board where it is
>>> + * connected to an infrared LED
>>> + * SFH4650 (60mW, @850nm) next to
>>> the
>>> + * ambient light and proximity
>>> sensor
>>> + * Capella Microsystems CM3605.
>>> + */
>>> + compatible =
>>> "qcom,pm8058-keypad-led";
>>> + reg = <0x48>;
>>> + label = "proximity0";
>>
>>
>> In DT bindings documentation it was changed to "pm8050:white:keypad" to
>> adhere to the LED class device naming convention. I assume that having
>> it in this form is an omission here.
>
> Hm right. Given the usecase here, what do you say about naming
> it:
>
> "pm8058:infrared:proximitysensor"
Looks good.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2016-08-18 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 19:45 [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard Linus Walleij
2016-08-16 22:19 ` Bjorn Andersson
2016-08-17 21:40 ` Jacek Anaszewski
2016-08-18 13:10 ` Linus Walleij
2016-08-18 19:47 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B610C1.6030000@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).