From mboxrd@z Thu Jan  1 00:00:00 1970
From: zhichang.yuan02@gmail.com (zhichang)
Date: Thu, 8 Sep 2016 17:51:25 +0800
Subject: [PATCH V2 3/4] ARM64 LPC: support serial based on low-pin-count
In-Reply-To: <5345060.9D0B4ujt5e@wuerfel>
References: <1473255233-154297-1-git-send-email-yuanzhichang@hisilicon.com>
 <1473255233-154297-4-git-send-email-yuanzhichang@hisilicon.com>
 <5345060.9D0B4ujt5e@wuerfel>
Message-ID: <57D1349D.8070905@gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi, Arnd


On 2016?09?07? 22:50, Arnd Bergmann wrote:
> On Wednesday, September 7, 2016 9:33:52 PM CEST Zhichang Yuan wrote:
>> From: "zhichang.yuan" <yuanzhichang@hisilicon.com>
>>
>> On Hip06 platform, a 16550 compatible UART is connected to low-pin-count and
>> controlled through the LPC I/O cycles. This patch drives the UART port with
>> the specific serial in/out function pair based on the indirect-IO mechanism
>> introduced by Hip06 LPC driver.
>>
>> Signed-off-by: zhichang.yuan <yuanzhichang@hisilicon.com>
> 
> Any reason this cannot just use the regular drivers/tty/serial/8250/8250_of.c
> driver?
I think two reasons for that:
1. 8250_of.c is only for devicetree, but we need to support ACPI device too;
2. It seems UPIO_PORT is not supported there.

Best,
Zhichang

> 
> 	Arnd
>