From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 324B6C433F5 for ; Mon, 10 Jan 2022 17:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c9ePAFPFcIFygt4VN5qMHXJ7avRPptjjO4usjMuIiBs=; b=KkaW1uZFM2byPsGStvgBdW2POe d6EoQCBiWkZceUeGVL9AgPDsZ3CwGhTnDE2nwJqOdp8G6Dsa80eMLxZay6R/FpYbqQICnzoJi41Sj WH9lug5Ms77bivilVIXIJ0LTvm3xE6z1scdqL90j/FOB2dQj4ndl6aRX8B2vZ0syncvag7FD9xLGr 6J/ctfVtCc15hRRkRNxcz3WO8qHstQHh23KHobroT1v3vQ1bRyUUBaUtywomIHtWaVWEjvp2JJGfM oitL4W8Exl2Gaq4F7IpNhYrYmE48htnM5OdlIHCNV1BULmgTldsLhBjtx+iLjxn02FP/zzB+3CItQ Hm4jA9eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6yC8-00CUks-4H; Mon, 10 Jan 2022 17:10:56 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6yBd-00CUWk-6e for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 17:10:26 +0000 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JXgLh2cxDz6895J; Tue, 11 Jan 2022 01:10:20 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 18:10:21 +0100 Received: from [10.47.24.251] (10.47.24.251) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 17:10:19 +0000 Subject: Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu. To: Ian Rogers , Andi Kleen , "Jiri Olsa" , Namhyung Kim , Kajol Jain , "Paul A . Clarke" , "Arnaldo Carvalho de Melo" , Riccardo Mancini , Kan Liang , Peter Zijlstra , "Ingo Molnar" , Mark Rutland , "Alexander Shishkin" , , , "Vineet Singh" , James Clark , "Mathieu Poirier" , Suzuki K Poulose , Mike Leach , Leo Yan , , , CC: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-3-irogers@google.com> From: John Garry Message-ID: <57ab982e-ecc1-3f49-c580-0a251e29698b@huawei.com> Date: Mon, 10 Jan 2022 17:10:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20220105061351.120843-3-irogers@google.com> Content-Language: en-US X-Originating-IP: [10.47.24.251] X-ClientProxiedBy: lhreml743-chm.china.huawei.com (10.201.108.193) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_091025_511214_24B2BF78 X-CRM114-Status: UNSURE ( 9.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/01/2022 06:13, Ian Rogers wrote: > > +struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx, > + void *data) > +{ > + if (idx < 0 || idx > map->nr) > + return cpu_map__empty_aggr_cpu_id(); > + > + return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data); > +} > + This is later deleted in the series. Can the series be reworked so that we don't add stuff and then later delete it? One reason for that approach is that we don't spend time reviewing something which will be deleted, especially in such a big series... If it really makes sense to do it this way then fine. Thanks, John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel