From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric.auger@redhat.com (Auger Eric) Date: Fri, 29 Jun 2018 16:51:21 +0200 Subject: [PATCH v3 06/20] kvm: arm/arm64: Remove spurious WARN_ON In-Reply-To: <1530270944-11351-7-git-send-email-suzuki.poulose@arm.com> References: <1530270944-11351-1-git-send-email-suzuki.poulose@arm.com> <1530270944-11351-7-git-send-email-suzuki.poulose@arm.com> Message-ID: <57ac04d3-0bbf-a3a4-f9a4-140dac8fa021@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Suzuki, On 06/29/2018 01:15 PM, Suzuki K Poulose wrote: > On a 4-level page table pgd entry can be empty, unlike a 3-level > page table. Remove the spurious WARN_ON() in stage_get_pud(). > > Cc: Marc Zyngier > Acked-by: Christoffer Dall > Signed-off-by: Suzuki K Poulose > --- > virt/kvm/arm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > index 061e6b3..308171c 100644 > --- a/virt/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -976,7 +976,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, struct kvm_mmu_memory_cache *cache > pud_t *pud; > > pgd = kvm->arch.pgd + stage2_pgd_index(addr); > - if (WARN_ON(stage2_pgd_none(*pgd))) { > + if (stage2_pgd_none(*pgd)) { > if (!cache) > return NULL; > pud = mmu_memory_cache_alloc(cache); > Reviewed-by: Eric Auger Thanks Eric