From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88C7EC021B8 for ; Tue, 4 Mar 2025 20:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U2sqEAxGJv2uGZqDwGrSnxcuM3qMt5QnCoz/T7iEsGY=; b=2PG+QjoR0ffzKpgMfkUf6Z5IsV ssq8nKEYrBI9MPf0X4kip3La3huI/k5K9cfTTCl0i0HHCXJS76mXe8REc6sza14QUkBrIrOXt7+RH 1dedkvmMKcxQXlX9Xobgfp8vqGOxq6DMyAZT1hm+sflM+9o5HzHPV2LKiLO7QiJeL7ut9G6uuwDQC lian7DZWyjeB4e+upWaqi7/LYKWCQdlTeeVfol9UAm8Ke4LVWuhcwSM3v6W9h5HN3Ygc69fkESOQ0 azwoCh55aHt4/ozN4+q2/XhFVaYO0U0yPkNcEqGaH9nn4Ssj9EO4FuNXa0CZjnvW5yKzIlJXr3GUn v0vo8dDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpYp4-00000006BLg-0OIL; Tue, 04 Mar 2025 20:25:02 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpYnU-00000006BCU-3hw8; Tue, 04 Mar 2025 20:23:26 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1741119802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U2sqEAxGJv2uGZqDwGrSnxcuM3qMt5QnCoz/T7iEsGY=; b=WNPh3e5psK966rm8ClScI8cegZulUjpiLwARCd4gpgUwa6Zx6B1/pufdZQy6A+HJHxL2vI dRT/9TzI6o24gv79nwK6r6q4uEhck3xgSAzyO15jYeukAy2cwig1FWFJfRV8Lp64xwLJF+ miqoRz6zokio8gKJzZFyQhlPKPyTLr9JUkWAF8goplg75vvp+q7piNvWsxCoHoSviskbVe 4U0fUGu2Sp3NVOpcETTE/39mSmEu3REBFj9EGJ5Qu/biUJaHkYMJoEFpgSmps3Nrf453nF s1GDjeIDJbNheYF8ATNdjkCLHZDCDBc2/5XKEP4pVcR0PLiwTn/naS1h3cp0dQ== Date: Tue, 04 Mar 2025 21:23:21 +0100 From: Dragan Simic To: Arnd Bergmann Cc: Ulf Hansson , Heiko Stuebner , Sebastian Reichel , Arnd Bergmann , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pmdomain: rockchip: add regulator dependency In-Reply-To: <20250304142803.689201-1-arnd@kernel.org> References: <20250304142803.689201-1-arnd@kernel.org> Message-ID: <57dc1e1b8a3f1134c5eed050a81de1b7@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_122325_073602_13D897C8 X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Arnd, On 2025-03-04 15:27, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build: > > drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit > declaration of function 'devm_of_regulator_get'; did you mean > 'devm_regulator_get'? [-Wimplicit-function-declaration] > 653 | pd->supply = devm_of_regulator_get(pmu->dev, > pd->node, "domain"); > | ^~~~~~~~~~~~~~~~~~~~~ > | devm_regulator_get > drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to > 'struct regulator *' from 'int' makes pointer from integer without a > cast [-Wint-conversion] > 653 | pd->supply = devm_of_regulator_get(pmu->dev, > pd->node, "domain"); > | ^ > > Add a Kconfig dependency. > > Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support") > Signed-off-by: Arnd Bergmann > --- > drivers/pmdomain/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pmdomain/rockchip/Kconfig > b/drivers/pmdomain/rockchip/Kconfig > index 7e4f9b628f0b..218d43186e5b 100644 > --- a/drivers/pmdomain/rockchip/Kconfig > +++ b/drivers/pmdomain/rockchip/Kconfig > @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS > bool "Rockchip generic power domain" > depends on PM > depends on HAVE_ARM_SMCCC_DISCOVERY > + depends on REGULATOR > select PM_GENERIC_DOMAINS > help > Say y here to enable power domain support. Looking good to me, thanks for this patch. Reviewed-by: Dragan Simic