From: marc_gonzalez@sigmadesigns.com (Marc Gonzalez)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] thermal: tango: Fix module autoload
Date: Fri, 14 Oct 2016 17:27:30 +0200 [thread overview]
Message-ID: <5800F962.8040605@sigmadesigns.com> (raw)
In-Reply-To: <1476455702-21748-3-git-send-email-javier@osg.samsung.com>
On 14/10/2016 16:35, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/thermal/tango_thermal.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/thermal/tango_thermal.ko | grep alias
> alias: of:N*T*Csigma,smp8758-thermalC*
> alias: of:N*T*Csigma,smp8758-thermal
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/thermal/tango_thermal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c
> index 201304aeafeb..4e67795cb6ce 100644
> --- a/drivers/thermal/tango_thermal.c
> +++ b/drivers/thermal/tango_thermal.c
> @@ -107,6 +107,7 @@ static const struct of_device_id tango_sensor_ids[] = {
> },
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, tango_sensor_ids);
Thanks for fixing it :-)
Acked-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Regards.
next prev parent reply other threads:[~2016-10-14 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 14:34 [PATCH 0/3] thermal: Fix module autoload for drivers Javier Martinez Canillas
2016-10-14 14:35 ` [PATCH 2/3] thermal: tango: Fix module autoload Javier Martinez Canillas
2016-10-14 15:27 ` Marc Gonzalez [this message]
2016-11-17 11:50 ` [PATCH 0/3] thermal: Fix module autoload for drivers Javier Martinez Canillas
2016-11-17 14:53 ` Eduardo Valentin
2016-11-17 14:58 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5800F962.8040605@sigmadesigns.com \
--to=marc_gonzalez@sigmadesigns.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox