From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30F55CD1284 for ; Tue, 2 Apr 2024 06:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dfLC5eB9IXUFYiF4w3KUdE+oZyQBkAwZK6QGXc829z8=; b=cjckdVOnDQ7wRE A0mBwWVmEgbjA6HYcAgQIYbvxQ7a0Y+69s7hrOvh+ljbcf9FRPS26QnyTcsnnYrd73g5Va9IDPqen YqNTEMX5W9Vkt32Bae6IrHRwuKKkTX2Uazh/j2uBGpp6/plLsBdYd7eFxnE02O6+lYkz+PMhju4gK pxwMq+N4UbHOM3Ui46HZW3JAW4Bw65oij7BUpxI5eOvG8IOrkQ6QNBCIu/VfbxFxq4eiYTKg2sPHN KG4ypEn52+iyIZB8Jh1fiv4YvNDah3cxFdCAe89kfD0Q0AWKQzibt/EXz3yqYUXMdlVkguH3zZhcY J78ojqpE4P1ThgnWxfyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrXa4-00000009txu-0Sy1; Tue, 02 Apr 2024 06:25:12 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrXa0-00000009txM-46GZ for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 06:25:10 +0000 Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4322mnmp029837; Tue, 2 Apr 2024 08:24:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=zvO9fT/3hnruxI2Qb+TcMhuCOsE3oJ9aHpPaLeaL1p4=; b=pz +r7Hw5/o9A561LptCu9IMRsqSF9k/YcJLYGgmvjHWz5XsGzcD80zy7UOtDAH2XAH BiULVaaqiNVeQSXsUoZx+1bX2cReN2C42TaeVqBAtOHoFkvmBdoBjKbYaM6ZbKHB 7QeQ5nCW7SHzNleUIHmXgL/xqmPTW3NRgQUIwchhgVgD7KKICAqYNDUkJ2B4fFLk UH46I8r4QUfLk+Q/m2MjeH2tLhAsNUWVg4VuSaPvQapRJBj0OOWUd1vGzb7Q8nBN KyDIS0zW0uQ9XmE7o6cNm701135ezPO4n5ua/wmi8F8usC2WKavQlvMv0vQlnW+E csDo1V1sNWA/NUlplsPQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3x6wsu78b5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Apr 2024 08:24:44 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 526374002D; Tue, 2 Apr 2024 08:24:38 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5759520F2C5; Tue, 2 Apr 2024 08:23:25 +0200 (CEST) Received: from [10.201.21.128] (10.201.21.128) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 2 Apr 2024 08:23:24 +0200 Message-ID: <5805e6e7-76a4-4a0f-abd0-823aed023daf@foss.st.com> Date: Tue, 2 Apr 2024 08:23:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] dt-bindings: net: dwmac: Document STM32 property st,ext-phyclk Content-Language: en-US To: Krzysztof Kozlowski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , Marek Vasut CC: , , , , References: <20240328140803.324141-1-christophe.roullier@foss.st.com> <20240328140803.324141-2-christophe.roullier@foss.st.com> <46b065d1-82d7-4a15-9de2-1e0bdd2a9085@linaro.org> From: Christophe ROULLIER In-Reply-To: <46b065d1-82d7-4a15-9de2-1e0bdd2a9085@linaro.org> X-Originating-IP: [10.201.21.128] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-02_02,2024-04-01_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_232509_503944_CA3C19D2 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/30/24 19:40, Krzysztof Kozlowski wrote: > On 28/03/2024 15:08, Christophe Roullier wrote: >> The Linux kernel dwmac-stm32 driver currently supports three DT >> properties used to configure whether PHY clock are generated by >> the MAC or supplied to the MAC from the PHY. >> >> Originally there were two properties, st,eth-clk-sel and >> st,eth-ref-clk-sel, each used to configure MAC clocking in >> different bus mode and for different MAC clock frequency. >> Since it is possible to determine the MAC 'eth-ck' clock >> frequency from the clock subsystem and PHY bus mode from >> the 'phy-mode' property, two disparate DT properties are >> no longer required to configure MAC clocking. >> >> Linux kernel commit 1bb694e20839 ("net: ethernet: stmmac: simplify phy modes management for stm32") >> introduced a third, unified, property st,ext-phyclk. This property >> covers both use cases of st,eth-clk-sel and st,eth-ref-clk-sel DT >> properties, as well as a new use case for 25 MHz clock generated >> by the MAC. >> >> The third property st,ext-phyclk is so far undocumented, >> document it. >> >> Below table summarizes the clock requirement and clock sources for >> supported PHY interface modes. >> __________________________________________________________________________ >> |PHY_MODE | Normal | PHY wo crystal| PHY wo crystal |No 125Mhz from PHY| >> | | | 25MHz | 50MHz | | >> >> --------------------------------------------------------------------------- >> | MII | - | eth-ck | n/a | n/a | >> | | | st,ext-phyclk | | | >> >> --------------------------------------------------------------------------- >> | GMII | - | eth-ck | n/a | n/a | >> | | | st,ext-phyclk | | | >> >> --------------------------------------------------------------------------- >> | RGMII | - | eth-ck | n/a | eth-ck | >> | | | st,ext-phyclk | | st,eth-clk-sel or| >> | | | | | st,ext-phyclk | >> >> --------------------------------------------------------------------------- >> | RMII | - | eth-ck | eth-ck | n/a | >> | | | st,ext-phyclk | st,eth-ref-clk-sel | | >> | | | | or st,ext-phyclk | | >> >> --------------------------------------------------------------------------- >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Christophe Roullier > Can you please start testing patches *before* sending them? Yes sorry, when I removed patch with phy-supply property (1/2), I had conflict merge and I did not pay attention that my commit was modified :-( > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel