public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: make arrays containing machine compatible strings const
Date: Wed, 18 Feb 2015 21:38:19 +0100	[thread overview]
Message-ID: <5808332.37GVWYAetI@wuerfel> (raw)
In-Reply-To: <1424289705-11786-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Wednesday 18 February 2015 21:01:45 Uwe Kleine-K?nig wrote:
> The definition
> 
>         static const char *axxia_dt_match[] __initconst = {
>                 ...
> 
> defines a changable array of constant strings. That is you must not do:
> 
>         *axxia_dt_match[0] = 'k';
> 
> but
> 
>         axxia_dt_match[0] = "different string";
> 
> is fine. So the annotation __initconst is wrong and yields a compiler
> error when other really const variables are added with __initconst.
> 
> As the struct machine_desc member dt_compat is declared as
> 
>         const char *const *dt_compat;
> 
> making the arrays const is the better alternative over changing all
> annotations to __initdata.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> 


Applied to fixes branch, thanks!

	Arnd

  reply	other threads:[~2015-02-18 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 20:01 [PATCH] ARM: make arrays containing machine compatible strings const Uwe Kleine-König
2015-02-18 20:38 ` Arnd Bergmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-09-11 21:19 Uwe Kleine-König
2014-09-24  5:01 ` Olof Johansson
2014-09-24 17:32   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5808332.37GVWYAetI@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox