From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B1BFC05027 for ; Tue, 14 Mar 2023 20:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f7owsYi1DJIK69EDqGuva77SPWI8VUFjuIcbM/GsIu0=; b=gUdW/TuAl8GOOo DtZMXNB5HDYdOyYK7SeoCxMSwsmbibBQFV0NKo3mn/FOC66oLauj5kxJgXrQw8rHZZYNDrLUUN38b ySpceHUGQrTJTuz0FUKAIV6bKnF7poLqOYE7uCeS6xYVkRex1HXFDlykTvxmkqKe2Lf6Qsxv2Rr9R dFJHjlCxOw91uG9j1o4pgEv2zqT4gNazEKdsDO2To3NsUZVi/BO/99ky4UDhHZ8JkB3t8KMB70vwM uUZcCue9cndeOnpMVw0psN6lHjLZkM9eXAQcMZ7HJI/yfz630sVkn+Iy/X9YmwKQ7zL3p2qeCs/qr hNNUSXrGQ+gYsRmbpSqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcB05-00BRsX-1s; Tue, 14 Mar 2023 20:12:01 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcB02-00BRrQ-2W for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 20:12:00 +0000 Received: by mail-ed1-x52c.google.com with SMTP id r11so15301065edd.5 for ; Tue, 14 Mar 2023 13:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678824715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Psn+ZNsvz+f0rmdAxM3umOGfhwT8TclOdJfGLvd1awU=; b=kn2N25+ZV2LJk+6Q8gXk5Piw+tlJzE3G6tcycy73tBvEv6yTaWxMc6PPO8SWiJ1kUX IO1XuElrqYEmiQ20elOKMnRL+wuTZw21TgzEI1/KSyvc0TxxUzqJhfgGrkkDpmGfgsTu ymJjKCF5p29DlEvQJCYPO/lYkb2Vnylj3aV0L/Ca/EyUCs2Ieiaf/7rGYVCHakUztSud AiaHcnueqiHNtzRXfSPMj4/+LQq5jrhXzAgj+d6I9L030W9RuZqSQOYzG6xMv7wIsun0 FJj09/5ufbcVBiO66Di7L/snpOVUYWYREkAZKfiyQNI9Os6i20yTbkZQffoP4SvDRdHN vosg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678824715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Psn+ZNsvz+f0rmdAxM3umOGfhwT8TclOdJfGLvd1awU=; b=hUXFszFiYSAYRNP9/7Xdjamqys6ygoEwR9vKOmxbZwmhvscihy+uWWnUnU+aEJYk4C oTa6c16LkBYpexJ1geYw/QYN6hfX53X8EJ7+kLFiv0hpCZ18ms5AIRsuuMYcbfHMo+sD pz3JkHeMPPazXHk/qVgqnAKN1eC74nSgf5rp0yuLmqCDpssqbvBXvROvrhbLy0uH+dYl /AehpOWwmXHeojYBmSeJcjVxDJlZ5Xe+4EzV1IqUV+RZ9ncFroglooSDKAii+E2QyGOc mDIRojPiO/rt3SI8tzK/pC8uiujBhDWvZ/tIfpxAls73oRb/2eOrGde87czyOeSEbZzp 8mqA== X-Gm-Message-State: AO0yUKVW+mhgmXpr9Xe759OaM6S+JR2W0JBwjrN6M5fZKyyy6KF5/hC7 O+PlHEj2+XCMT3tfx1gsYik= X-Google-Smtp-Source: AK7set81Sdi8Ag2OLXzypBycmwWBYTYONBGYNe393ehQSP6TWWFhDRJaFujDkZqUi3eH6EGl8ZgfWg== X-Received: by 2002:a17:907:2097:b0:8af:1a8c:f13f with SMTP id pv23-20020a170907209700b008af1a8cf13fmr4045889ejb.71.1678824715561; Tue, 14 Mar 2023 13:11:55 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id n10-20020a50c20a000000b004fb542dd8cdsm1520471edf.29.2023.03.14.13.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 13:11:55 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Mark Brown , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 74/87] spi: sun4i: Convert to platform remove callback returning void Date: Tue, 14 Mar 2023 21:11:54 +0100 Message-ID: <5811350.MhkbZ0Pkbq@jernej-laptop> In-Reply-To: <20230303172041.2103336-75-u.kleine-koenig@pengutronix.de> References: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> <20230303172041.2103336-75-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_131158_821415_FCDFEC15 X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 03. marec 2023 ob 18:20:28 CET je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- Acked-by: Jernej Skrabec Best regards, Jernej > drivers/spi/spi-sun4i.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c > index 6000d0761206..994d0fb50e68 100644 > --- a/drivers/spi/spi-sun4i.c > +++ b/drivers/spi/spi-sun4i.c > @@ -516,11 +516,9 @@ static int sun4i_spi_probe(struct platform_device > *pdev) return ret; > } > = > -static int sun4i_spi_remove(struct platform_device *pdev) > +static void sun4i_spi_remove(struct platform_device *pdev) > { > pm_runtime_force_suspend(&pdev->dev); > - > - return 0; > } > = > static const struct of_device_id sun4i_spi_match[] =3D { > @@ -536,7 +534,7 @@ static const struct dev_pm_ops sun4i_spi_pm_ops =3D { > = > static struct platform_driver sun4i_spi_driver =3D { > .probe =3D sun4i_spi_probe, > - .remove =3D sun4i_spi_remove, > + .remove_new =3D sun4i_spi_remove, > .driver =3D { > .name =3D "sun4i-spi", > .of_match_table =3D sun4i_spi_match, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel