From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A20D7C27C4F for ; Tue, 18 Jun 2024 06:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j0CT5+u8v+Tt5ly5F8d6KLAmQFfq4ACni1Ma8+3IMes=; b=dtpyPuH9Bt2EBIMhUSv2oZZxcx iVTQUYxSftTpopEnWd7T9wv5LtcJa+30/pm2ZKKA6RQNAO+LfrtgbyOlb78BS69VUlpx82Gmu7BGe suO/XvU2nwr2BmA95pOD3wSh4F2yjC48fkBkHbOPlNFb3MC0XT234/z+8FzqRDKPDlsR8r3UbqD99 xzARvrrdRlVyLHtwuKxJtpgoi8xV3R7aZADVzKLFBaXvggkxeVy5a0L76dKOzxORuMstW79Fo3Vds sqB4Izux+dk49nAFGQjbmM4vvf1zf1P5DtAUgo2zCGeaUE52n3bZHRejJiC0U9oRjoNw84Giih8in YcV1/qHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJS8E-0000000DlGU-3aHt; Tue, 18 Jun 2024 06:15:50 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJS8B-0000000DlF5-31QH for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2024 06:15:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1718691347; x=1750227347; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=j0CT5+u8v+Tt5ly5F8d6KLAmQFfq4ACni1Ma8+3IMes=; b=YoN3t/kYSdV/TAnOOuJFoPREVrLOtU4a/g46wFWtOz2vnBCQQxewq43Q hYJ+wqKG3njbniRsMRHVysTIj+7WO2NYjAcOT8bB3/ePlCoTkwmuMdPwP UbEqfz3DNnOSCVyXgj3ioCr7I1k8wsRvgnFlZ/7kzK86/QGJg22Zrh03B awBudcGQYFFyW5rqfW4MH9OAwrR3Vqh3C12QhcNPKrXkhvG0k1QzXxRH1 OrwBNI2HaPM2jIVT9PJY2AQqCiLEcX5TvBcUi9NIVdsw3/iSP2eFsBUoa tEZDJtl5BWKVffqqURu1eb4GR/55oJhsVPzg40R0q1WL5RME/XsUyB8TV Q==; X-CSE-ConnectionGUID: uSJ4tK8CTSuWQAuRdEbI8A== X-CSE-MsgGUID: h3c3S3bTTlqWutSMcG/7qw== X-IronPort-AV: E=Sophos;i="6.08,246,1712613600"; d="scan'208";a="37439566" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 18 Jun 2024 08:15:45 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 70990165E7E; Tue, 18 Jun 2024 08:15:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1718691340; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=j0CT5+u8v+Tt5ly5F8d6KLAmQFfq4ACni1Ma8+3IMes=; b=aay66l+rtmKWsmSR8PlojeyltfrnzJEs4Ojsh0PwJU1Qw0Hd5biwloAj5kYTFP2wfInCif BSBRBzYq3NOP+iO3toNNNhJYaV3VHGieJsAvCWePli5t/fhKDFz3A5oj3sZRgVIreHYBxT E6esHFpiFfZyenRu+WLY5jjs/ksYP5Cqng1DVM8nbpIn+asucWmCziml3AG762nLFoaMqf CpXiTMOZ7D/pYCG7+UhbxxcIk0/HU+X/Y5lJ0HEGhX5N4Ys6Vm7jScokiYloabfnjoD96h WKpPjzf/f/cKL7XSca6KYLQZ2e9Wfp9Zfwiom7UOneetaC6M6rR2zjn8LyNrBA== From: Alexander Stein To: linux-arm-kernel@lists.infradead.org, Adam Ford Cc: aford@beaconembedded.com, marex@denx.de, Adam Ford , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Marco Felsch , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location Date: Tue, 18 Jun 2024 08:15:41 +0200 Message-ID: <5814494.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240617223952.1899201-1-aford173@gmail.com> References: <20240617223952.1899201-1-aford173@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_231548_276987_0DC8CC7C X-CRM114-Status: GOOD ( 14.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adam, Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford: > The pgc_mlmix shows a power-domain@24, but the reg value is > IMX8MP_POWER_DOMAIN_MLMIX which is set to 4. >=20 > The stuff after the @ symbol should match the stuff referenced > by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4. Taking a look this mismatch seems to be also true for: * IMX8MP_POWER_DOMAIN_VPUMIX * IMX8MP_POWER_DOMAIN_VPU_G1 * IMX8MP_POWER_DOMAIN_VPU_G2 * IMX8MP_POWER_DOMAIN_VPU_VC8000E Would you mind fixing them as well? Despite that, for this patch: Reviewed-by: Alexander Stein Thanks and best regards, Alexander > Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain") > Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node") >=20 > Signed-off-by: Adam Ford >=20 > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/= dts/freescale/imx8mp.dtsi > index b92abb5a5c53..3576d2b89b43 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 { > reg =3D ; > }; > =20 > + pgc_mlmix: power-domain@4 { > + #power-domain-cells =3D <0>; > + reg =3D ; > + clocks =3D <&clk IMX8MP_CLK_ML_AXI>, > + <&clk IMX8MP_CLK_ML_AHB>, > + <&clk IMX8MP_CLK_NPU_ROOT>; > + assigned-clocks =3D <&clk IMX8MP_CLK_ML_CORE>, > + <&clk IMX8MP_CLK_ML_AXI>, > + <&clk IMX8MP_CLK_ML_AHB>; > + assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL1_800M>, > + <&clk IMX8MP_SYS_PLL1_800M>, > + <&clk IMX8MP_SYS_PLL1_800M>; > + assigned-clock-rates =3D <800000000>, > + <800000000>, > + <300000000>; > + }; > + > pgc_audio: power-domain@5 { > #power-domain-cells =3D <0>; > reg =3D ; > @@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 { > reg =3D ; > clocks =3D <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>; > }; > - > - pgc_mlmix: power-domain@24 { > - #power-domain-cells =3D <0>; > - reg =3D ; > - clocks =3D <&clk IMX8MP_CLK_ML_AXI>, > - <&clk IMX8MP_CLK_ML_AHB>, > - <&clk IMX8MP_CLK_NPU_ROOT>; > - assigned-clocks =3D <&clk IMX8MP_CLK_ML_CORE>, > - <&clk IMX8MP_CLK_ML_AXI>, > - <&clk IMX8MP_CLK_ML_AHB>; > - assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL1_800M>, > - <&clk IMX8MP_SYS_PLL1_800M>, > - <&clk IMX8MP_SYS_PLL1_800M>; > - assigned-clock-rates =3D <800000000>, > - <800000000>, > - <300000000>; > - }; > }; > }; > }; >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/