* Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
2024-06-17 22:39 [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location Adam Ford
@ 2024-06-17 23:21 ` Marek Vasut
2024-06-18 6:15 ` Alexander Stein
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2024-06-17 23:21 UTC (permalink / raw)
To: Adam Ford, linux-arm-kernel
Cc: aford, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan,
Marco Felsch, Alexander Stein, devicetree, imx, linux-kernel
On 6/18/24 12:39 AM, Adam Ford wrote:
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
>
> The stuff after the @ symbol should match the stuff referenced
> by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.
>
> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Thanks !
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
2024-06-17 22:39 [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location Adam Ford
2024-06-17 23:21 ` Marek Vasut
@ 2024-06-18 6:15 ` Alexander Stein
2024-06-18 12:07 ` Adam Ford
2024-06-18 6:33 ` Peng Fan
2024-06-27 7:46 ` Shawn Guo
3 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2024-06-18 6:15 UTC (permalink / raw)
To: linux-arm-kernel, Adam Ford
Cc: aford, marex, Adam Ford, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Peng Fan, Marco Felsch, devicetree, imx,
linux-kernel
Hi Adam,
Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford:
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
>
> The stuff after the @ symbol should match the stuff referenced
> by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.
Taking a look this mismatch seems to be also true for:
* IMX8MP_POWER_DOMAIN_VPUMIX
* IMX8MP_POWER_DOMAIN_VPU_G1
* IMX8MP_POWER_DOMAIN_VPU_G2
* IMX8MP_POWER_DOMAIN_VPU_VC8000E
Would you mind fixing them as well?
Despite that, for this patch:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Thanks and best regards,
Alexander
> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index b92abb5a5c53..3576d2b89b43 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
> reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
> };
>
> + pgc_mlmix: power-domain@4 {
> + #power-domain-cells = <0>;
> + reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> + clocks = <&clk IMX8MP_CLK_ML_AXI>,
> + <&clk IMX8MP_CLK_ML_AHB>,
> + <&clk IMX8MP_CLK_NPU_ROOT>;
> + assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> + <&clk IMX8MP_CLK_ML_AXI>,
> + <&clk IMX8MP_CLK_ML_AHB>;
> + assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> + <&clk IMX8MP_SYS_PLL1_800M>,
> + <&clk IMX8MP_SYS_PLL1_800M>;
> + assigned-clock-rates = <800000000>,
> + <800000000>,
> + <300000000>;
> + };
> +
> pgc_audio: power-domain@5 {
> #power-domain-cells = <0>;
> reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
> @@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
> reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
> };
> -
> - pgc_mlmix: power-domain@24 {
> - #power-domain-cells = <0>;
> - reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> - clocks = <&clk IMX8MP_CLK_ML_AXI>,
> - <&clk IMX8MP_CLK_ML_AHB>,
> - <&clk IMX8MP_CLK_NPU_ROOT>;
> - assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> - <&clk IMX8MP_CLK_ML_AXI>,
> - <&clk IMX8MP_CLK_ML_AHB>;
> - assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> - <&clk IMX8MP_SYS_PLL1_800M>,
> - <&clk IMX8MP_SYS_PLL1_800M>;
> - assigned-clock-rates = <800000000>,
> - <800000000>,
> - <300000000>;
> - };
> };
> };
> };
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
2024-06-18 6:15 ` Alexander Stein
@ 2024-06-18 12:07 ` Adam Ford
0 siblings, 0 replies; 6+ messages in thread
From: Adam Ford @ 2024-06-18 12:07 UTC (permalink / raw)
To: Alexander Stein
Cc: linux-arm-kernel, aford, marex, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Peng Fan, Marco Felsch, devicetree, imx,
linux-kernel
On Tue, Jun 18, 2024 at 1:15 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Hi Adam,
>
> Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford:
> > The pgc_mlmix shows a power-domain@24, but the reg value is
> > IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
> >
> > The stuff after the @ symbol should match the stuff referenced
> > by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.
>
> Taking a look this mismatch seems to be also true for:
> * IMX8MP_POWER_DOMAIN_VPUMIX
> * IMX8MP_POWER_DOMAIN_VPU_G1
> * IMX8MP_POWER_DOMAIN_VPU_G2
> * IMX8MP_POWER_DOMAIN_VPU_VC8000E
>
> Would you mind fixing them as well?
I can do that. I'll send out out later tonight.
adam
>
> Despite that, for this patch:
> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Thanks and best regards,
> Alexander
>
> > Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> > Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index b92abb5a5c53..3576d2b89b43 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
> > reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
> > };
> >
> > + pgc_mlmix: power-domain@4 {
> > + #power-domain-cells = <0>;
> > + reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> > + clocks = <&clk IMX8MP_CLK_ML_AXI>,
> > + <&clk IMX8MP_CLK_ML_AHB>,
> > + <&clk IMX8MP_CLK_NPU_ROOT>;
> > + assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> > + <&clk IMX8MP_CLK_ML_AXI>,
> > + <&clk IMX8MP_CLK_ML_AHB>;
> > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> > + <&clk IMX8MP_SYS_PLL1_800M>,
> > + <&clk IMX8MP_SYS_PLL1_800M>;
> > + assigned-clock-rates = <800000000>,
> > + <800000000>,
> > + <300000000>;
> > + };
> > +
> > pgc_audio: power-domain@5 {
> > #power-domain-cells = <0>;
> > reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
> > @@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
> > reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> > clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
> > };
> > -
> > - pgc_mlmix: power-domain@24 {
> > - #power-domain-cells = <0>;
> > - reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> > - clocks = <&clk IMX8MP_CLK_ML_AXI>,
> > - <&clk IMX8MP_CLK_ML_AHB>,
> > - <&clk IMX8MP_CLK_NPU_ROOT>;
> > - assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> > - <&clk IMX8MP_CLK_ML_AXI>,
> > - <&clk IMX8MP_CLK_ML_AHB>;
> > - assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> > - <&clk IMX8MP_SYS_PLL1_800M>,
> > - <&clk IMX8MP_SYS_PLL1_800M>;
> > - assigned-clock-rates = <800000000>,
> > - <800000000>,
> > - <300000000>;
> > - };
> > };
> > };
> > };
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
2024-06-17 22:39 [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location Adam Ford
2024-06-17 23:21 ` Marek Vasut
2024-06-18 6:15 ` Alexander Stein
@ 2024-06-18 6:33 ` Peng Fan
2024-06-27 7:46 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2024-06-18 6:33 UTC (permalink / raw)
To: Adam Ford, linux-arm-kernel@lists.infradead.org
Cc: aford@beaconembedded.com, marex@denx.de, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Marco Felsch,
Alexander Stein, devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
> Subject: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
>
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
>
> The stuff after the @ symbol should match the stuff referenced by 'reg'
> so reorder the pgc_mlmix so it to appear as power-domain@4.
>
> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power
> domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Regards,
Peng.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
2024-06-17 22:39 [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location Adam Ford
` (2 preceding siblings ...)
2024-06-18 6:33 ` Peng Fan
@ 2024-06-27 7:46 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2024-06-27 7:46 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, marex, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Peng Fan, Marco Felsch, Alexander Stein,
devicetree, imx, linux-kernel
On Mon, Jun 17, 2024 at 05:39:51PM -0500, Adam Ford wrote:
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
>
> The stuff after the @ symbol should match the stuff referenced
> by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.
>
> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread