From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B71C5517A for ; Wed, 11 Nov 2020 12:28:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C42C207BB for ; Wed, 11 Nov 2020 12:28:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c9t2U+cr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rgp4iBF7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C42C207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fGLEUB8kV/Aqe5Q14e/QcVbXJKzbCDvae+06osHAkGk=; b=c9t2U+crc7TPpKcVKsT9lK10P wnhckmkvbQu2nlPO4MuOPfdmeLYuXGdBQNa92PcSW5ioatzS6jrI21yC6hVTiY1t/cIZrXvfNO1DM h8Zp0xSrdcs62P4j3O42IoV7Tvz6AMbFaWdCMssdyClf9kmI5Z2EWyQwySxlFrPdSYgYjsqI9HKZR BcOWeWCQ8oYtOWwgWuLTXIrc5gXOEL36nfHDaEeRPtR72l8sdjZBWG6RdupNHAucEhmJ71a1ymDaU LycHqmSAEBoA7G16oDSM3UP9pj9dsxnObjbP2kAkl1XWxHsDiD/dGkSCOdY2h/YMD5ZPstfzMuwTI HbKl8qG6g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcpEG-00071D-By; Wed, 11 Nov 2020 12:28:00 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcpED-00070H-9f for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 12:27:58 +0000 Received: by mail-lj1-x241.google.com with SMTP id v20so1852012ljk.8 for ; Wed, 11 Nov 2020 04:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W5WHawdyiRL/UDPwiBG0yjJUaw2ChXCIaDxzqyGijTM=; b=rgp4iBF7QIwpfxVeWcUQxYv5Jkp6Xu9bjSj0N7rpmVxTxLaHXoguSDfNMidnDczwUM VcKGr0eRkofLJ5ta55sg5miFXEdgXXCR85onduPj33m81gi2Pbk6OaJrFnuUxBn8Vo0+ Ph7+SIiGnaCk0tGPbsl9hQ+pJVG1POv+OJBemTeM0zUrDPvnzXpyXeDOYLvAmClP3DXv Jf6oakkXu8+MAPBp+BZ98KPO8nLq/b9V5dQ+2qguSrPT/NC94DP5PhMYkHzTFOOwiZRh XFEkbxNseJGfqjKeQ7EkgnTrSZybzeRtwtSF2FWQ6R9es6+p/YhENrnK2q28wvg9WY8p Cpsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W5WHawdyiRL/UDPwiBG0yjJUaw2ChXCIaDxzqyGijTM=; b=rXqf1yyuIsN/MaioJt648FhoLuuMAO6X0r+qnUnVx6m0Fk++G4IsHtep0VrUc7tX1E /tOmYhXc3c+MMsTvyQmaXjRe3NkzZ8MTPTXjOeQLKr+juhaiD2ccs3sSXne7Zyop03hn yGH8sA8e0j6bQ1DiBzena2lpLepq73d0fsk+PUg5wwgRichyk7hXpLSAbBSZYdoS9fQZ aizUusKFANtBUtTnWs3CUybOQPf3U9taATSm9t0rYcKsahVwtNRNgj/vCJ+v3RWLqpLN pO1L4+crljgztkDigKaMRINuBf0toKJuoy8NT7p2xa6STfgszgRIrDsfZGdvzp5MxP+a ZjAg== X-Gm-Message-State: AOAM5324nCwrY5jAbaVeYYySoGMJNF7jFupDio2xrh60hfN6ASB+OxHG mJKCW9e95WeAm52l2AqBQo4= X-Google-Smtp-Source: ABdhPJyOLm7Uoq0JuJlCCWiprf07q96YUVZNNXHwv5N+mB52A4/YKQP4CeUn7zVBWJjWmngXoqwnEg== X-Received: by 2002:a2e:9a43:: with SMTP id k3mr10978389ljj.69.1605097675775; Wed, 11 Nov 2020 04:27:55 -0800 (PST) Received: from elitebook.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id x6sm206676lfn.185.2020.11.11.04.27.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 04:27:54 -0800 (PST) Subject: Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node To: Florian Fainelli , Vladimir Oltean References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-6-f.fainelli@gmail.com> <20201110221221.4sxx5h3346no7y3y@skbuf> <3e87038f-9e2e-676c-a000-0e6c0e8b6ae4@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <581c3e62-9d2e-f684-b035-46aeb7a52816@gmail.com> Date: Wed, 11 Nov 2020 13:27:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_072757_365669_EFF78E4C X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Scott Branden , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , netdev@vger.kernel.org, open list , Vivien Didelot , Rob Herring , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , Ray Jui , Jakub Kicinski , Kurt Kanzenbach , "David S. Miller" , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.11.2020 02:48, Florian Fainelli wrote: > On 11/10/2020 2:13 PM, Florian Fainelli wrote: >> On 11/10/20 2:12 PM, Vladimir Oltean wrote: >>> On Mon, Nov 09, 2020 at 07:31:08PM -0800, Florian Fainelli wrote: >>>> Provide an empty 'ports' container node with the correct #address-cells >>>> and #size-cells properties. This silences the following warning: >>>> >>>> arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: >>>> ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed: >>>> 'ports' is a required property >>>> 'ethernet-ports' is a required property >>>> From schema: >>>> Documentation/devicetree/bindings/net/dsa/b53.yaml >>>> >>>> Signed-off-by: Florian Fainelli >>>> --- >>>> arch/arm/boot/dts/bcm5301x.dtsi | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi >>>> index 807580dd89f5..89993a8a6765 100644 >>>> --- a/arch/arm/boot/dts/bcm5301x.dtsi >>>> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >>>> @@ -489,6 +489,10 @@ srab: ethernet-switch@18007000 { >>>> status = "disabled"; >>>> >>>> /* ports are defined in board DTS */ >>>> + ports { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + }; >>> >>> This look a bit 'lone wolf' here. Not sure how much time you intend to >>> spend on this, but FWIW, others prefer to declare all ports in the SoC >>> DTSI with status = "disabled", and just enable the ones used per-board, >>> and add labels and PHY handles also per-board. Example: fsl-ls1028a.dtsi >>> and fsl-ls1028a-rdb.dts. >> >> That's a good suggestion, I could do that. > > There is quite a bit of variation between designs and how the ports are > assigned and it would end up being quite verbose, so I will punt that > for now. I agree with Florian, boards (vendors) use ports really randomly so pretty much every device needs that defined from the scratch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel