From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 2/3] ACPI: Add support for ResourceSource/IRQ domain mapping
Date: Fri, 11 Nov 2016 21:26:42 +0800 [thread overview]
Message-ID: <5825C712.5050009@linaro.org> (raw)
In-Reply-To: <60c1d53146c0aebd3a05095823229224@codeaurora.org>
On 11/10/2016 11:02 PM, agustinv at codeaurora.org wrote:
> Hey Hanjun,
>
> On 2016-11-09 21:36, Hanjun Guo wrote:
>> Hi Marc, Rafael, Lorenzo,
>>
>> Since we agreed to add a probe deferral if we failed to get irq
>> resources which mirroring the DT does (patch 1 in this patch set),
>> I think the last blocker to make things work both for Agustin and
>> me [1] is this patch, which makes the interrupt producer and consumer
>> work in ACPI, we have two different solution for one thing, we'd happy
>> to work together for one solution, could you give some suggestions
>> please?
>>
>> [1]:
>> https://mail-archive.com/linux-kernel at vger.kernel.org/msg1257419.html
>>
>> Agustin, I have some comments below.
>>
>> On 2016/10/29 4:48, Agustin Vega-Frias wrote:
>>> This allows irqchip drivers to associate an ACPI DSDT device to
>>> an IRQ domain and provides support for using the ResourceSource
>>> in Extended IRQ Resources to find the domain and map the IRQs
>>> specified on that domain.
>>>
>>> Signed-off-by: Agustin Vega-Frias <agustinv@codeaurora.org>
>>> ---
>>> drivers/acpi/Makefile | 1 +
>>> drivers/acpi/irqdomain.c | 119
>>> +++++++++++++++++++++++++++++++++++++++++++++++
>>
>> Could we just reuse the gsi.c and not introduce a new
>> file, probably we can change the gsi.c to irqdomain.c
>> or something similar, then reuse the code in gsi.c.
>
> I was thinking just that after we chatted off-list.
Great.
> I might revisit and see what I come up with given that we already have
> a device argument and we could pass the IRQ source there.
Sorry, I'm little confused here, why we "already have a device
argument"? in drivers/acpi/resource.c, it just use NULL as device
and we can't pass dev directly for the API is using now, could
you explain more?
Thanks
Hanjun
next prev parent reply other threads:[~2016-11-11 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 20:48 [PATCH V6 0/3] irqchip: qcom: Add IRQ combiner driver Agustin Vega-Frias
2016-10-28 20:48 ` [PATCH V6 1/3] ACPI: Retry IRQ conversion if it failed previously Agustin Vega-Frias
2016-10-28 20:48 ` [PATCH V6 2/3] ACPI: Add support for ResourceSource/IRQ domain mapping Agustin Vega-Frias
2016-11-10 2:36 ` Hanjun Guo
2016-11-10 15:02 ` agustinv at codeaurora.org
2016-11-10 17:58 ` Lorenzo Pieralisi
2016-11-11 13:33 ` Hanjun Guo
2016-11-12 3:01 ` agustinv at codeaurora.org
2016-11-12 14:38 ` Hanjun Guo
2016-11-11 13:26 ` Hanjun Guo [this message]
2016-10-28 20:48 ` [PATCH V6 3/3] irqchip: qcom: Add IRQ combiner driver Agustin Vega-Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5825C712.5050009@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).