From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.
Date: Fri, 11 Nov 2016 21:55:03 +0800 [thread overview]
Message-ID: <5825CDB7.40606@linaro.org> (raw)
In-Reply-To: <20161021112120.GC16630@leverpostej>
On 10/21/2016 07:21 PM, Mark Rutland wrote:
> On Fri, Oct 21, 2016 at 12:14:01PM +0100, Mark Rutland wrote:
>> On Thu, Oct 20, 2016 at 05:58:17PM +0100, Mark Rutland wrote:
>>> On Thu, Sep 29, 2016 at 02:17:13AM +0800, fu.wei at linaro.org wrote:
>>>> + arch_timer_ppi[PHYS_NONSECURE_PPI] = acpi_gtdt_map_ppi(PHYS_NONSECURE_PPI);
>>>> + arch_timer_ppi[VIRT_PPI] = acpi_gtdt_map_ppi(VIRT_PPI);
>>>> + arch_timer_ppi[HYP_PPI] = acpi_gtdt_map_ppi(HYP_PPI);
>>>> + /* Always-on capability */
>>>> + arch_timer_c3stop = acpi_gtdt_c3stop();
>>>
>>> ... I think we should check the flag on the relevant interrupt, though
>>> that's worth clarifying.
>>
>> I see I misread the spec; this is part of the common flags.
>>
>> Please ignore this point; sorry for the noise.
>
> Actually, I misread the spec this time around; the flag *can* differ per
> interrupt for the sysreg/cp15 timer, but not for the MMIO timers where
> the flag is in a common field.
>
> So please *do* consider the above.
Sorry, misread the email as well...
Check the spec again and it's per interrupt flag.
Thanks
Hanjun
next prev parent reply other threads:[~2016-11-11 13:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 18:17 [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei at linaro.org
2016-09-28 18:17 ` [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei at linaro.org
2016-10-20 14:45 ` Mark Rutland
2016-10-26 8:31 ` Fu Wei
2016-10-26 10:51 ` Mark Rutland
2016-10-26 10:54 ` Fu Wei
2016-09-28 18:17 ` [PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei at linaro.org
2016-10-20 15:09 ` Mark Rutland
2016-10-26 8:26 ` Fu Wei
2016-09-28 18:17 ` [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei at linaro.org
2016-10-20 15:32 ` Mark Rutland
2016-10-26 8:28 ` Fu Wei
2016-09-28 18:17 ` [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver fu.wei at linaro.org
2016-10-20 16:37 ` Mark Rutland
2016-10-26 11:10 ` Fu Wei
2016-10-26 12:11 ` Marc Zyngier
2016-10-26 13:41 ` Fu Wei
2016-11-11 13:43 ` Hanjun Guo
2016-11-11 13:46 ` Hanjun Guo
2016-11-11 13:58 ` Hanjun Guo
2016-11-11 15:32 ` Mark Rutland
2016-09-28 18:17 ` [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei at linaro.org
2016-10-20 16:58 ` Mark Rutland
2016-10-21 11:14 ` Mark Rutland
2016-10-21 11:21 ` Mark Rutland
2016-10-26 8:54 ` Fu Wei
2016-11-11 13:55 ` Hanjun Guo [this message]
2016-09-28 18:17 ` [PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei at linaro.org
2016-10-21 11:19 ` Mark Rutland
2016-09-28 18:17 ` [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT fu.wei at linaro.org
2016-10-21 11:32 ` Mark Rutland
2016-10-26 15:24 ` Fu Wei
2016-10-26 15:46 ` Mark Rutland
2016-10-26 16:07 ` Fu Wei
2016-09-28 18:17 ` [PATCH v14 8/9] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei at linaro.org
2016-09-28 18:17 ` [PATCH v14 9/9] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei at linaro.org
2016-09-30 0:40 ` [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Xiongfeng Wang
2016-10-05 17:26 ` Fu Wei
2016-10-20 14:31 ` Mark Rutland
2016-10-20 14:57 ` Lorenzo Pieralisi
2016-10-20 15:17 ` Mark Rutland
2016-10-26 8:24 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5825CDB7.40606@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).