From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56487C433EF for ; Sun, 5 Jun 2022 20:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B1FqCeYjBKPApPccUa4s7xbgYqCz4uRtDY5nrkxVH80=; b=OM2tPqPrg4V69L ZtcQRL4ByDxZrv2SxE28Bevo1cY1jmzFujTao6Ot8te0pFIqs7yryvkfGwyLPwmj92pabpyRM2UxP k4D6WN39bWDe6D0SaaxV7GhgOCTOuPSJUKyCbPs29v/DyBdM6xTJwPcKZYBLHW+bkGaP47AVf7dyO 7V7b8XLbH+IaZanMdJVyXKN8JaTZi7gRjrNPtI1Jc5AA4TyfRSRoVHJ1YbKXVi/A57KWPhL293Okx 5U0tvAimaPiNe/Y1onhFhC5AVq5ebQdZ6oiH8f5x0BiN8HLqbjNmO3RdiWmIs7VvVZBMXv84cj7fV PzxDnkc0pWkNqiLsLLRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxwmV-00FIFX-HX; Sun, 05 Jun 2022 20:23:27 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxwmS-00FIF6-8b for linux-arm-kernel@lists.infradead.org; Sun, 05 Jun 2022 20:23:25 +0000 Received: by mail-ej1-x62c.google.com with SMTP id q21so25431621ejm.1 for ; Sun, 05 Jun 2022 13:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=syDJi88yIFylEVum47mqcHZv+RTHJr0HACQpGPz7nFg=; b=UkdnJF7U/pehTnhldJ0iRVMzejB11Pwz4Nh6FtdzdqI7LZG4RriamDrXXxtEvidn4P RTY9zO7h022njdZW8eeUj0iinKe/b/CgKrWUQG3GegxQh2P9ZeqbM7W+B0XECBxhmWtQ aBNOkDMyKXYqYuWvAtcb2G1ciFjjdavXh3Ll6PV3Rns/37mLuoIne9Jp8TbGEWOJTlfx H+9T0HErvS9klcadxd2WMlR1/TI3gM0hr7gtZRLzyRC/5wyKhyDD3osNCeayoJKPijCI kK8sHqqdZTeIhqM5DsCL6vk0Er6Ntcp7e487O7BmZth3c0ITx3qhJ758UeLk/pav265k U69g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=syDJi88yIFylEVum47mqcHZv+RTHJr0HACQpGPz7nFg=; b=5TH68RyQDZXby2iiNPbo0EHWK5UIHcrf1XWFXmC2LEyXY6dqaL6yhO0ov2u3pZOPxt 2iVW2AdHhfH4KU+bqAr5pmZKZSyO8PNTSomfiUUGLZeS29jT0++BZsI1HfDHTUxlh0dP rC3ivarYIqKQHkBGdCSvbctJXXthyUCrD4qL90IyquuyOmbMWLsQwVuRpAJU2mlgkXad BA4fIAWp+yIRcx0/HMWE5wIjJFALPouKyKCT14u+1LHGFspJWksGP3Zr39FBJkk5Sa1B ppBIpHUwhAvT1TODd6NIdMNQUzyWD+YAUoyZ7CqjfpaPMWT6HbamifZmuSkPdJ9wYiXa KGYQ== X-Gm-Message-State: AOAM531kzD6fbD48sR7pFiX6ozjRFCBJQoI+M981k+S1F8zS/4KaHPoG cDLZftRpooWB0fXhMkwir9g= X-Google-Smtp-Source: ABdhPJx3SAJQ47i6a+JSGjvv9dNZLjFQAuaIZnoyyym7cAW0Id1txRWDbdUrlqHzWh9rkQnzTDpv2A== X-Received: by 2002:a17:906:3ed5:b0:6f5:108c:a45 with SMTP id d21-20020a1709063ed500b006f5108c0a45mr18253665ejj.623.1654460600393; Sun, 05 Jun 2022 13:23:20 -0700 (PDT) Received: from jernej-laptop.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id a22-20020aa7d916000000b0042dd4f9c464sm7226427edr.84.2022.06.05.13.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 13:23:19 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard@kernel.org, wens@csie.org, airlied@linux.ie, daniel@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, megi@xff.cz, Roman Stratiienko Cc: Roman Stratiienko Subject: Re: [PATCH v2] drm/sun4i: Enable output signal premultiplication for DE2/DE3 Date: Sun, 05 Jun 2022 22:23:18 +0200 Message-ID: <5826286.lOV4Wx5bFT@jernej-laptop> In-Reply-To: <20220605094018.9782-1-r.stratiienko@gmail.com> References: <20220605094018.9782-1-r.stratiienko@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_132324_373555_D3832A3B X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 05. junij 2022 ob 11:40:18 CEST je Roman Stratiienko napisal(a): > Otherwise alpha value is discarded, resulting incorrect pixel > apperance on the display. > > This also fixes missing transparency for the most bottom layer. Can you explain that a bit more? Also, BSP driver never enables this bit. What are we doing differently? > > Test applications and videos w/ w/o this patch are available at [1]. > > [1]: https://github.com/GloDroid/glodroid_tests/issues/1 As stated in other emails, commit messages should not contain external links (per patch rules). Best regards, Jernej > Signed-off-by: Roman Stratiienko > > --- > Changelog: > > V2: Added code hunk missing in v1 > --- > drivers/gpu/drm/sun4i/sun8i_mixer.c | 5 +++-- > drivers/gpu/drm/sun4i/sun8i_mixer.h | 1 + > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c > b/drivers/gpu/drm/sun4i/sun8i_mixer.c index 6b1711a9a71f..ba2932aaed08 > 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c > @@ -320,8 +320,9 @@ static void sun8i_mixer_mode_set(struct sunxi_engine > *engine, else > val = 0; > > - regmap_update_bits(engine->regs, SUN8I_MIXER_BLEND_OUTCTL(bld_base), > - SUN8I_MIXER_BLEND_OUTCTL_INTERLACED, val); > + val |= SUN8I_MIXER_BLEND_OUTCTL_PREMULTIPLY; > + > + regmap_write(engine->regs, SUN8I_MIXER_BLEND_OUTCTL(bld_base), val); > > DRM_DEBUG_DRIVER("Switching display mixer interlaced mode %s\n", > interlaced ? "on" : "off"); > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h > b/drivers/gpu/drm/sun4i/sun8i_mixer.h index ebfc276b2464..bc12c95af6f3 > 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h > @@ -65,6 +65,7 @@ > #define SUN8I_MIXER_BLEND_ROUTE_PIPE_MSK(n) (0xf << ((n) << 2)) > #define SUN8I_MIXER_BLEND_ROUTE_PIPE_SHIFT(n) ((n) << 2) > > +#define SUN8I_MIXER_BLEND_OUTCTL_PREMULTIPLY BIT(0) > #define SUN8I_MIXER_BLEND_OUTCTL_INTERLACED BIT(1) > > #define SUN50I_MIXER_BLEND_CSC_CTL_EN(ch) BIT(ch) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel