From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9574BC54EBC for ; Sun, 8 Jan 2023 20:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rvvccdm15utvRchDwl4GRR0H/H3b/0oO8d/zaX/G7f0=; b=ZrXUIEBPExbCVl rvX7b18XUnRw9axoAef9ylbqQLaQsGqJXTLQLdB5ZRRq+l8OLLgvUwdY7fSS8Xgb/d/EHinxcbd1R v70AQP6YIP7xKRxnzWf/QIrcG6TUQwaUHZ0fmhvqlCkw9G9JFM3XR0InHXEW+omcq8g5x2qZzSZJM HG4ZVQZu9s0LXWwDL2IADvkTGTP9wfHXUuJFgYcDuJNdDLYc8UhzfVdYKag7Q5jcAHZ8CR2xENQrm NBteIFRDkt7n30pYPY44a/QV+PqkIlEh1q1O5lxeQMifSW4tWuE/zDGQ0eDq84h8gYq+ofF4whLwr OOFgpQ+JTDp4hm8IqybQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEceR-00FiqT-Kp; Sun, 08 Jan 2023 20:52:19 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEceM-00FioV-NV for linux-arm-kernel@lists.infradead.org; Sun, 08 Jan 2023 20:52:16 +0000 Received: by mail-ed1-x52a.google.com with SMTP id v10so8609292edi.8 for ; Sun, 08 Jan 2023 12:52:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/W1ZH7okdp3bC5pjHi5v6nQazt9WUGWbkW62SJcD8hQ=; b=CZSi5VCe45fYPvoueF3Xz9/2f8RQXo4zyAt34wYxgvnxVuDjBRRzHICHSsCVFL9qvD y0k+0LPoVdQjSsrczYbF/yitqgcOmTgTpEhjZtjt3K0/vdqY5X6LE/vA8Fahyg8LBmDb JgHj7ZOPWTu5jVphQgd2X6yMgiB49QeVi3N0e+QyysPEGlgHC2MSxjtVjIIvUA/FAPRj S2/zFCg6UTJiLPOnA34xzSUTpD7z1bpfhFvFx175/mX+wgOxWh3adhrMU+ehQ0Yfx+qm 4zBi2y/2PuqdbZfQq8N2IMW2hGoNSPkVsIURkr3reDhJWPsvh63lvhO3Fate3WhzcCbZ oqTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/W1ZH7okdp3bC5pjHi5v6nQazt9WUGWbkW62SJcD8hQ=; b=qYb6mtSOe5qtLziETiE0OCu4O9mCmAkjJcEPJj2e/HZrZzRGExaS0UylZ+/nh52Sfx 3vFbY54qw6ROMwaSAAFLeEmbxcAguVbVH6MgMjGsr6k3MOJSVa4NjfKHpF1GWrcBwioj fRjjyN47j/MxzBdhhp6sitExvdtDrDvQ19chuG6vD5y6HNvtIQWGRI1yu4TIyoFxZ2qV i7uOcceY6omktrUwCYoryy6VRz0mZnJPnji7IGYlz/S6dBFLSlqlkJA2FnseM5peebNf dv3zGMdOWMit6YIMLXrGfi4Zg5+MM2tuxxVs5m/7S0sw2v70AoQuVSo06CxN3LElDj6L qjEw== X-Gm-Message-State: AFqh2kqtOVp5eE5qQzaEEk4J6xg1ey1LAXKndaMSxmVHKZu5xXVFno3S mhwolKU0wwNcT5VqjkylNws= X-Google-Smtp-Source: AMrXdXthkxdR5S3Vx/C5pVKc8nmwQsnxhLxbv5FwkjZ/fyeqvLUsh+ZvJxXis6Q2Ef7PtQwkRWND5A== X-Received: by 2002:a05:6402:104d:b0:486:ac69:b9e4 with SMTP id e13-20020a056402104d00b00486ac69b9e4mr36935941edu.4.1673211133033; Sun, 08 Jan 2023 12:52:13 -0800 (PST) Received: from jernej-laptop.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id k26-20020a508ada000000b00487fc51c532sm3016451edk.33.2023.01.08.12.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 12:52:12 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Srinivas Kandagatla , Chen-Yu Tsai , Samuel Holland Cc: Samuel Holland , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, stable@vger.kernel.org, Heiko Stuebner Subject: Re: [PATCH v2 1/2] nvmem: sunxi_sid: Always use 32-bit MMIO reads Date: Sun, 08 Jan 2023 21:52:11 +0100 Message-ID: <5829449.MhkbZ0Pkbq@jernej-laptop> In-Reply-To: <20230101183316.43642-2-samuel@sholland.org> References: <20230101183316.43642-1-samuel@sholland.org> <20230101183316.43642-2-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230108_125214_993265_389495C9 X-CRM114-Status: GOOD ( 13.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 01. januar 2023 ob 19:33:15 CET je Samuel Holland napisal(a): > The SID SRAM on at least some SoCs (A64 and D1) returns different values > when read with bus cycles narrower than 32 bits. This is not immediately > obvious, because memcpy_fromio() uses word-size accesses as long as > enough data is being copied. > > The vendor driver always uses 32-bit MMIO reads, so do the same here. > This is faster than the register-based method, which is currently used > as a workaround on A64. And it fixes the values returned on D1, where > the SRAM method was being used. > > The special case for the last word is needed to maintain .word_size == 1 > for sysfs ABI compatibility, as noted previously in commit de2a3eaea552 > ("nvmem: sunxi_sid: Optimize register read-out method"). > > Cc: stable@vger.kernel.org > Fixes: 07ae4fde9efa ("nvmem: sunxi_sid: Add support for D1 variant") > Tested-by: Heiko Stuebner > Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel