linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vladimir.murzin@arm.com (Vladimir Murzin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 06/11] ARM: tlbflush: drop dependency on CONFIG_SMP
Date: Tue, 22 Nov 2016 13:36:57 +0000	[thread overview]
Message-ID: <583449F9.6060804@arm.com> (raw)
In-Reply-To: <20161122100345.GV1041@n2100.armlinux.org.uk>

On 22/11/16 10:03, Russell King - ARM Linux wrote:
> On Tue, Nov 22, 2016 at 09:26:03AM +0000, Vladimir Murzin wrote:
>> It can be referenced in UP case as well.
> 
> What's missing is an explanation of why you want this change.
> Exposing the local_* stuff doesn't make sense for UP.

It comes from:

arch/arm/mach-mvebu/pmsu.c: In function 'armada_370_xp_pmsu_idle_enter':
arch/arm/mach-mvebu/pmsu.c:291:2: error: implicit declaration of function 'local_flush_tlb_all' [-Werror=implicit-function-declaration]
  local_flush_tlb_all();
  ^

make[1]: *** [arch/arm/mach-mvebu/pmsu.o] Error 1

and

arch/arm/mach-imx/pm-imx5.c: In function 'mx5_suspend_enter':
arch/arm/mach-imx/pm-imx5.c:227:3: error: implicit declaration of function 'local_flush_tlb_all' [-Werror=implicit-function-declaration]

   local_flush_tlb_all();
   ^
cc1: some warnings being treated as errors
make[1]: *** [arch/arm/mach-imx/pm-imx5.o] Error 1

Maybe there are other users, please, let me know if you want me to count them
all.

Cheers
Vladimir

> 
>> Cc: Russell King <linux@armlinux.org.uk>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>>  arch/arm/include/asm/tlbflush.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/include/asm/tlbflush.h b/arch/arm/include/asm/tlbflush.h
>> index def9e57..d9a6e2e 100644
>> --- a/arch/arm/include/asm/tlbflush.h
>> +++ b/arch/arm/include/asm/tlbflush.h
>> @@ -641,7 +641,7 @@ static inline void update_mmu_cache(struct vm_area_struct *vma,
>>  
>>  #endif
>>  
>> -#elif defined(CONFIG_SMP)	/* !CONFIG_MMU */
>> +#else /* !CONFIG_MMU */
>>  
>>  #ifndef __ASSEMBLY__
>>  
>> -- 
>> 1.7.9.5
>>
> 

  reply	other threads:[~2016-11-22 13:36 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  9:25 [RFC PATCH 00/11] Allow NOMMU for MULTIPLATFORM Vladimir Murzin
2016-11-22  9:25 ` [RFC PATCH 01/11] ARM: NOMMU: define stubs for fixup Vladimir Murzin
2016-11-22  9:48   ` Russell King - ARM Linux
2016-11-22  9:54     ` Vladimir Murzin
2016-11-22  9:25 ` [RFC PATCH 02/11] ARM: ep93xx: select ARM_PATCH_PHYS_VIRT for MMU builds only Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 03/11] ARM: omap: do not select HIGHMEM explicitly Vladimir Murzin
2016-11-22  9:51   ` Russell King - ARM Linux
2016-11-23 15:49     ` Tony Lindgren
2016-11-23 16:08       ` Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 04/11] PCI: tegra: limit to MMU build only Vladimir Murzin
2016-11-22  9:31   ` Arnd Bergmann
2016-11-22  9:40     ` Vladimir Murzin
2016-11-22  9:54       ` Arnd Bergmann
2016-11-22  9:58         ` Vladimir Murzin
2016-11-22 11:26         ` Thierry Reding
2016-11-25 10:49           ` Vladimir Murzin
2016-11-22 16:15   ` Stephen Warren
2016-11-22 21:16     ` Arnd Bergmann
2016-11-22 22:27       ` Stephen Warren
2016-11-22 22:52         ` Arnd Bergmann
2016-11-22  9:26 ` [RFC PATCH 05/11] ARM: move arm_heavy_mb to MMU/noMMU neutral place Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 06/11] ARM: tlbflush: drop dependency on CONFIG_SMP Vladimir Murzin
2016-11-22 10:03   ` Russell King - ARM Linux
2016-11-22 13:36     ` Vladimir Murzin [this message]
2016-11-24 17:41       ` Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 07/11] ARM: sleep: allow it to be build for R-class Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 08/11] ARM: NOMMU: define debug_ll_io_ini Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 09/11] ARM: NOMMU: define SECTION_xxx macros Vladimir Murzin
2016-11-22 10:07   ` Russell King - ARM Linux
2016-11-22 11:50     ` Vladimir Murzin
2016-11-22 11:54       ` Russell King - ARM Linux
2016-11-22 17:03         ` Vladimir Murzin
2016-11-24 17:38           ` Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 10/11] ARM: NOMMU: define __arm_ioremap_exec and pci_ioremap functions Vladimir Murzin
2016-11-22  9:26 ` [RFC PATCH 11/11] ARM: Allow ARCH_MULTIPLATFORM to be selected for NOMMU Vladimir Murzin
2016-11-22 10:17   ` Arnd Bergmann
2016-11-22 16:57     ` Vladimir Murzin
2016-11-23 15:48       ` Afzal Mohammed
2016-11-23 16:07         ` Vladimir Murzin
2016-11-24 17:28           ` Afzal Mohammed
2016-11-24 17:33             ` Vladimir Murzin
2016-11-24 18:09               ` Afzal Mohammed
2016-11-23 19:16         ` Russell King - ARM Linux
2016-11-24 17:25           ` Afzal Mohammed
2016-11-24 17:35             ` Russell King - ARM Linux
2016-11-24 18:07               ` Afzal Mohammed
2016-11-24 18:45                 ` Russell King - ARM Linux
2016-11-25 11:20                   ` Vladimir Murzin
2016-11-23 15:55       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=583449F9.6060804@arm.com \
    --to=vladimir.murzin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).