public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board
Date: Wed, 30 Nov 2016 17:36:03 +0900	[thread overview]
Message-ID: <583E8F73.2060804@samsung.com> (raw)
In-Reply-To: <1480481337-3941-1-git-send-email-sw0312.kim@samsung.com>

Dear Seung-Woo,

I think that this patch looks good to me.
But, When I tested this patch on my TM2 board,
the flash turn off after some millisecond automatically.

It is strange situation. Unfortunately, I don't know the cause.
I think that we better to check this issue for more time.

Best Regards,
Chanwoo Choi

On 2016? 11? 30? 13:48, Seung-Woo Kim wrote:
> From: Ingi Kim <ingi2.kim@samsung.com>
> 
> This patch adds Kinetic ktd2692 flash led device node for TM2 board.
> 
> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> Change from v1:
> - gpio active value is set with defined macro instead of value.
> ---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> index f21bdc2..0d454aa 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> @@ -58,6 +58,19 @@
>  		reg = <0x0 0x20000000 0x0 0xc0000000>;
>  	};
>  
> +	camera-flash {
> +		compatible = "kinetic,ktd2692";
> +		ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>;
> +		aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>;
> +
> +		flash-led {
> +			label = "ktd2692-flash";
> +			led-max-microamp = <300000>;
> +			flash-max-microamp = <1500000>;
> +			flash-max-timeout-us = <1835000>;
> +		};
> +	};
> +
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  
> 

  reply	other threads:[~2016-11-30  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30  4:27 [PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim
2016-11-30  4:48 ` [PATCH v2] " Seung-Woo Kim
2016-11-30  8:36   ` Chanwoo Choi [this message]
2016-11-30  8:44     ` Seung-Woo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=583E8F73.2060804@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox