From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42221C433EF for ; Mon, 1 Nov 2021 07:45:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B15B60F46 for ; Mon, 1 Nov 2021 07:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B15B60F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=86V6Pvbki+LKNFmEmyII40fA1d/wg8VUW6uPf4gFvnI=; b=Il2fmSTz90NMwa iQkW5SS6MeMWytmeHQwEe1JtOBzPyyf/D3Zm73/DT5ulU+DDShlyGDdYHbkEUuHHc5Hf97ySURZ0T 790ignQ3t6gM4QI3s4ktii1TOnUXCFsShgoVUgCV+y7mycH7+J8UUsacyErADtARHPOik32CA7/2/ G2k4UVx7fZ7ABMhIqXv1bC7LQgXb15pBnehraz5R0r7Bm+X+f0QUuK7C9ts/IxAYd8333TE5JWUiB Tdax7qRBp5OWirsFWwBW3Iq6ZHqE6o+41JM7eMhCrWohAgIWPyc3sXHSp38TQWTkDfn9ee/C8EpO7 EO08a/rRXdL6ENRZGMkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhRyM-00FZZa-42; Mon, 01 Nov 2021 07:43:14 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhRyI-00FZYt-MP for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 07:43:12 +0000 Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 6EF093F1A9 for ; Mon, 1 Nov 2021 07:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1635752583; bh=P5EmjtVy3Q/Sl5vMD4AJleTfAces0kc83H/qtiLZpsA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MHmXSzixwMX8dP7YEOfv5sR2S6oyrOlPS+iCKi0g9QGtSXa4+r5HcplnReoBeG8IX 8ugAKcFdudHbmIl9mlW+krXiun5lXRd7Gkv9rCEycl4yIGHIS9vjab3ZGj01CEWi7O ICtfi0rITmxxVPko6qkZ+uJzFSy03TxBqu5gbvYIN1UWw0f9JNjICQ0bArwRHQx9tG 6iZ1GTw7UmIORM0o0SjwKGwfJQW/YcQ49m/gEPl9oN+jmPEOWRbKnzXD2uCXhW91b1 anvJv7Poji9CLEm2uUMoCW/DC4N1xFTmwEuIpzFE/6Ed1S3+p0bWOHfvTb+f9+isPY zNWONUE4wd+zA== Received: by mail-lj1-f198.google.com with SMTP id v13-20020a2e2f0d000000b0021126b5cca2so5742470ljv.19 for ; Mon, 01 Nov 2021 00:43:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P5EmjtVy3Q/Sl5vMD4AJleTfAces0kc83H/qtiLZpsA=; b=CCAOI7mgFtYeoZcUJwnz/Ux5G1ZBsmH1LOGSGrlSlZCpi+DdMGvLeenA/cD03aUK1k QSlwBPMP+eK158nOiZpfF2U0NWSZMAV2Tdcy5kY8looUttl+FoftlbRjZnMV60edA5La UEJAVsstF7k+LOweBPXhu1geWiSDajYp/fjJZ2hH5kfpNEklXbCYP//n7wCtHM8VfpiY iQvfXahaJiFYHgKCOGhiP3tWNnsddYpfviKjp2KZgAcRxG8rgNMwfDIVw2mYJrHZv4s5 LsMKJIHghtw9QcRRYStSfgEc0S0PQkntpbRfrg2YtRyksTkomYFIEtRry5Ua+MNcofcg MbVg== X-Gm-Message-State: AOAM5307FdTP8rkVnzRKbl5+pNWTMFNATkuY/oXCGwib19jicvA+nLnJ AvoTtnHVAWwoGgzq/kyEvq6ZDpMHyWFZxslmZ3CzWHZ+BWBPxLDHpZd4fK3VXkwN2CQvXS3+WEQ W5jND9/cxbSXvOp90c+4lIlXOjyfKPD2xHjqDWP59flwoxVO+hALX X-Received: by 2002:a05:6512:238b:: with SMTP id c11mr9464902lfv.55.1635752582849; Mon, 01 Nov 2021 00:43:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTBjlYgNdZWvFuAyG8+5ovVAueMERrhBzZVtiW+PwhADTBkkpZV9sYnRKo8Z5LK8UPUARFcg== X-Received: by 2002:a05:6512:238b:: with SMTP id c11mr9464886lfv.55.1635752582666; Mon, 01 Nov 2021 00:43:02 -0700 (PDT) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id bn28sm1612869ljb.117.2021.11.01.00.43.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 00:43:01 -0700 (PDT) Message-ID: <583fac88-0b6d-43a9-dbec-e1e89d3c6ad8@canonical.com> Date: Mon, 1 Nov 2021 08:43:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 1/2] soc: samsung: exynos-chipid: print entire PRO_ID reg when probing Content-Language: en-US To: Henrik Grimler Cc: chanho61.park@samsung.com, semen.protsenko@linaro.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20211031165645.1182368-1-henrik@grimler.se> <878a4657-c68a-743e-7c89-bf69b416b824@canonical.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_004310_983644_4FE88AC6 X-CRM114-Status: GOOD ( 22.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/10/2021 22:29, Henrik Grimler wrote: > Hi, > > On Sun, Oct 31, 2021 at 09:35:20PM +0100, Krzysztof Kozlowski wrote: >> On 31/10/2021 17:56, Henrik Grimler wrote: >>> Older Exynos socs has one reg PRO_ID containing both product id and >>> revision information. Newer Exynos socs has one Product_ID reg with >>> product id, and one CHIPID_REV reg with revision information. >>> >>> In commit c072c4ef7ef0 ("soc: samsung: exynos-chipid: Pass revision >>> reg offsets") the driver was changed so that the revision part of >>> PRO_ID is masked to 0 when printed during probing. This can give a >>> false impression that the revision is 0, so lets change so entire >>> PRO_ID reg is printed again. >>> >>> Signed-off-by: Henrik Grimler >>> --- >>> Has been tested on exynos4412-i9300, which is compatible with >>> exynos4210-chipid, and on an exynos8895 device compatible with >>> exynos850-chipid. >>> --- >> >> Hi, >> >> Thanks for the patch. >> >> I miss here however the most important information - why do you need it? >> The answer to "why" should be in commit msg. > > In dmesg we currently print something like: > > Exynos: CPU[EXYNOS4412] PRO_ID[0xe4412000] REV[0x11] Detected > > where PRO_ID is given in datasheet as: > > [31:12] Product ID > [9:8] Package information > [7:4] Main Revision Number > [3:0] Sub Revision Number > > By printing PRO_ID[0xe4412000] it gives the impression that Package > information, Main Revision Number and Sub Revision Number are all 0. > >> The change was kind of intentional and accepted, because revision ID is >> printed next to the product ID. Printing revision ID with product ID >> could be confusing... > > Sure, I see the reason for only printing the product id. Would you > accept a patch write Product_ID instead of PRO_ID in the printed > message? So that we print: > > Exynos: CPU[EXYNOS4412] Product_ID[0xe4412000] REV[0x11] Detected > > There's then less room for confusion regarding the revision, since > Product_ID should contain only the Product ID, unlike PRO_ID which > should contain both Product ID and revision info. Yes, let it be then: Exynos: CPU[EXYNOS4412] ProductID[0xe4412000] Rev[0x11] detected Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel