From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhongjiang@huawei.com (zhong jiang) Date: Fri, 16 Dec 2016 17:10:05 +0800 Subject: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE In-Reply-To: <1481725151-20549-3-git-send-email-zhongjiang@huawei.com> References: <1481725151-20549-1-git-send-email-zhongjiang@huawei.com> <1481725151-20549-3-git-send-email-zhongjiang@huawei.com> Message-ID: <5853AF6D.20305@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/12/14 22:19, zhongjiang wrote: > From: zhong jiang > > when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the > fuctions should not be use. therefore, we add the dependency. > > Signed-off-by: zhong jiang > --- > arch/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 969ef88..694ca73 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS > > config ARCH_WANT_HUGE_PMD_SHARE > def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > + depends on HUGETLB_PAGE > > config ARCH_HAS_CACHE_LINE_SIZE > def_bool y Hi, I still think it is a issue. Perhaps above changelog is unclear. Further explain is as follows. when hugetlb_pages is disable and arch_want_huge_pmd_share is enable, we maybe call huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not exported. is it right ?? Thanks zhongjiang