From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6CC4EB64DD for ; Mon, 14 Aug 2023 10:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rp+OOwk7jMwy3enn2kJ5F3Vxx70Hc8WU0FcxrbVj9KE=; b=Kphgqvgt2JcZ+6 7l59QmNcwgmjFoH3qwRS8SCACV5gnFBiBi6ng3w3jp0zlitSD41FhTGvA5z0uNtR2J74xUjKMjvPM obYCLuG+i2xmknYjoGh/UeFPvk89FiyePlP1HBM6YBXJCP/ZjWC8Hw+u/u4d1nDpO3JJKIzB6qB1Z 7+AdX8WboBB+s2kSAH8oKohhxqhE4q+0YM2CLt4AlaMv3acFPvfZ5fHmRUt0zMR1nqqVDSEAygP33 vJ/QawERdZAHQRDqzQJNkh96kEtzFxwNMtkumv24NQWJTdi+jkTbDG0Gu+iIaMORoeMJHO+kBiYcB gPRNWcbrNmJkXbcdlemA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVUoX-00Gljb-21; Mon, 14 Aug 2023 10:28:45 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVUoT-00GlgB-2v for linux-arm-kernel@lists.infradead.org; Mon, 14 Aug 2023 10:28:43 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51e2a6a3768so5632621a12.0 for ; Mon, 14 Aug 2023 03:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692008919; x=1692613719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FD+dZC6ILC0zBFJ75+s8TCoV5USuF9fK+77Nw8Aje0w=; b=KWdqfZ62xxlrvlMKf2qpi7YAx2rbvFG/rCy6KhPTmVZphJsw4o2qpe1XzHr2ulW9ig dJocY4tSGDsDN8BwwO1YOQawk66HkEn80/HhW/9hlO6rOow7AfWW5ejsrLhaPH16P9kI wf7SMRXGkVgrdLwcNcHzBNB7TdGjz+ahTGskjF0PqMlDTx7kItkd0xOLzJyi1Kjn74TF IZ3bJUC1Dq/EpL3zzYFza3Qn5PV29G9w5keslAkAtcSJCAw/AkZGh8bevjk/lcV5+KDs IWxarqq5J8fQu8ZYSNrror9GhedNj152iiEaVa+GX1N6T82hz+c11S0hNGGo6iqScOVF mMNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692008919; x=1692613719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FD+dZC6ILC0zBFJ75+s8TCoV5USuF9fK+77Nw8Aje0w=; b=KXwqWmd0yFJ0792ePI9ESuIbRSY8CsZYS+7oTEdYWpExA6UpyJbT8mvaOlGksx+e/n kD9PPKYB7vc6ySfFczF/VCMOtYvF3bcdbR4f7KOfRq3hf5OsaT+4G6UqiBkM90CELSp0 eWXig0NxQb2rGbEIrzJrpCMiJqcv0Yn7WZ2sA5iYFesoSf34diB33xUFcxuV8TTblGta o14VO4vxPN80R0YT9PWlsPq/mis1vS4XqdvY0iz0EEPZIzE8x09JsdByIL9MnozFBTc/ VDmZcmKPDUj0tVHVB55laRg3OO8zmXSuSzdtWYycQyYnuNHuuTrvvzoUHFRVTfjOwKKk 8RrQ== X-Gm-Message-State: AOJu0Ywumier1wXsogtnxhZUM8dov3v34abTkbJepsgcxgze4yfU/Ny8 P4tFdUoM5nQp0yl8G7BZQ3E= X-Google-Smtp-Source: AGHT+IGLLfnjCAgn+nWhTlM7HypGsXCTlLNpZzQ1NwgZFCaXqFMayOU8fjnnL5sKdfMF6InnHfyjDw== X-Received: by 2002:a17:906:1da1:b0:99b:c2d4:ddd8 with SMTP id u1-20020a1709061da100b0099bc2d4ddd8mr6745353ejh.31.1692008919572; Mon, 14 Aug 2023 03:28:39 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id w14-20020a1709060a0e00b0099b5a71b0bfsm5490638ejf.94.2023.08.14.03.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 03:28:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Krzysztof Kozlowski , Martin Botka Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller Date: Mon, 14 Aug 2023 12:28:36 +0200 Message-ID: <5856748.MhkbZ0Pkbq@jernej-laptop> In-Reply-To: References: <20230814-sid-h616-v2-0-0267749b4471@somainline.org> <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_032841_946264_AE693347 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 14. avgust 2023 ob 10:21:49 CEST je Martin Botka napisal(a): > On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski > > wrote: > > On 14/08/2023 08:38, Martin Botka wrote: > >> Add binding for the SID controller found in H616 SoC > >> > >> Signed-off-by: Martin Botka > >> --- > >> > >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> | 1 + > >> | > >> 1 file changed, 1 insertion(+) > >> > >> diff --git > >> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> index 296001e7f498..2ec0a1b8f803 100644 > >> --- > >> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> +++ > >> > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> @@ -27,6 +27,7 @@ properties: > >> - const: allwinner,sun50i-a64-sid > >> > >> - const: allwinner,sun50i-h5-sid > >> - const: allwinner,sun50i-h6-sid > >> > >> + - const: allwinner,sun50i-h616-sid > > > > It does not look like you tested the DTS against bindings. Please run > > `make dtbs_check` (see > > Documentation/devicetree/bindings/writing-schema.rst or > > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sour > > ces-with-the-devicetree-schema/ for instructions). > > > > Best regards, > > Krzysztof > > Yea completely forgot. Sorry for that. > > Will send v3 tomorrow with proper binding patch using items with enums Don't. You have cca. 1 month time now, since you missed at least window for DT changes for 6.6. Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel