From: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <andersson@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <konradybcio@kernel.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<p.zabel@pengutronix.de>, <richardcochran@gmail.com>,
<geert+renesas@glider.be>, <dmitry.baryshkov@linaro.org>,
<angelogioacchino.delregno@collabora.com>,
<neil.armstrong@linaro.org>, <arnd@arndb.de>,
<nfraprado@collabora.com>, <quic_anusha@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<quic_srichara@quicinc.com>, <quic_varada@quicinc.com>
Subject: Re: [PATCH v8 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions
Date: Mon, 28 Oct 2024 13:15:40 +0530 [thread overview]
Message-ID: <5862062c-8c52-421d-94b3-6b6000b53616@quicinc.com> (raw)
In-Reply-To: <lyafg7jwbwoe3j7voecgd5tnhrb65utc3vkc5qqxoqug3qd47m@iudkp4w2mrso>
On 10/25/2024 5:30 PM, Krzysztof Kozlowski wrote:
> On Fri, Oct 25, 2024 at 09:25:17AM +0530, Manikanta Mylavarapu wrote:
>> From: Devi Priya <quic_devipriy@quicinc.com>
>>
>> Add NSSCC clock and reset definitions for ipq9574.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>> ---
>> Changes in V8:
>> - Replace bias_pll_cc_clk, bias_pll_ubi_nc_clk with CMN_PLL
>> NSS_1200MHZ_CLK and PPE_353MHZ_CLK
>> - Remove bias_pll_nss_noc_clk because it's not required.
>> - Drop R-b tag
>
> That's not really a change waranting re-review.
>
> I wished you did not create here dependency, skipped the header and just
> use some number for the clock. Having dependencies does not help anyone:
> neither you to get this merged, nor us to see that it was tested.
>
> Please confirm that this patch was fully tested.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
>
Yes, it's fully tested.
Thanks & Regards,
Manikanta.
next prev parent reply other threads:[~2024-10-28 7:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 3:55 [PATCH v8 0/7] Add NSS clock controller support for IPQ9574 Manikanta Mylavarapu
2024-10-25 3:55 ` [PATCH v8 1/7] clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574 Manikanta Mylavarapu
2024-10-25 3:55 ` [PATCH v8 2/7] dt-bindings: clock: gcc-ipq9574: Add definition for GPLL0_OUT_AUX Manikanta Mylavarapu
2024-10-25 3:55 ` [PATCH v8 3/7] clk: qcom: gcc-ipq9574: Add support for gpll0_out_aux clock Manikanta Mylavarapu
2024-10-25 3:55 ` [PATCH v8 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions Manikanta Mylavarapu
2024-10-25 12:00 ` Krzysztof Kozlowski
2024-10-28 7:45 ` Manikanta Mylavarapu [this message]
2024-10-25 3:55 ` [PATCH v8 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574 Manikanta Mylavarapu
2024-10-25 5:51 ` Dmitry Baryshkov
2024-10-28 6:25 ` Manikanta Mylavarapu
2024-12-30 14:48 ` Konrad Dybcio
2025-02-06 7:01 ` Manikanta Mylavarapu
2024-10-25 3:55 ` [PATCH v8 6/7] arm64: dts: qcom: ipq9574: Add nsscc node Manikanta Mylavarapu
2024-10-25 23:31 ` kernel test robot
2024-10-26 10:05 ` Konrad Dybcio
2024-10-28 7:42 ` Manikanta Mylavarapu
2024-10-29 9:25 ` Philip Li
2024-10-25 3:55 ` [PATCH v8 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574 Manikanta Mylavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5862062c-8c52-421d-94b3-6b6000b53616@quicinc.com \
--to=quic_mmanikan@quicinc.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox