From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B946C433EF for ; Wed, 22 Sep 2021 09:52:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB4CA61107 for ; Wed, 22 Sep 2021 09:52:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB4CA61107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PLyWEXRriRyfCEG90Wm4YZoRGz7zaMF2fbqBTASfzbE=; b=utcCcCYk4ton3e6jjUraxNPkZ/ zy8oVL5OT6p+aom7kAAM1Fh90/kT1cMzRafPAoqyBIV4sD7SapheBPj24iZ81g/srhhT4MvuwURvn YrEjXY/Hk1700xbnMbwDbwIgDs9ezZuvhwTS1Ic+UXVL7xAnaPQozV5lzZArPyfjxcweSi+ZOFW0B PbQH5aqfMnwDdotIn3AvwZJKLPqne+HztyIRESBe0V2jKlqngFeVCHkzEBubnwKrGuiFv999UNvhl NTbq/b9vIwduIdFo6aNad6vSarr+6DlVOR0QUpZ+rhEwfto5RdrE4ocRDWlX8ILlUyEwKKAIBCcI/ 1txWKHww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSyty-007eIA-5C; Wed, 22 Sep 2021 09:50:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSytt-007eH5-PD for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 09:50:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6734A11B3; Wed, 22 Sep 2021 02:50:47 -0700 (PDT) Received: from [10.163.73.113] (unknown [10.163.73.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A90C3F719; Wed, 22 Sep 2021 02:50:43 -0700 (PDT) Subject: Re: [PATCH v2 13/17] coresight: trbe: Add a helper to determine the minimum buffer size To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, maz@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, james.morse@arm.com, leo.yan@linaro.org, mike.leach@linaro.org, mathieu.poirier@linaro.org, will@kernel.org, lcherian@marvell.com, coresight@lists.linaro.org References: <20210921134121.2423546-1-suzuki.poulose@arm.com> <20210921134121.2423546-14-suzuki.poulose@arm.com> From: Anshuman Khandual Message-ID: <586a307e-a51d-d176-b9f9-fc730278317e@arm.com> Date: Wed, 22 Sep 2021 15:21:49 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210921134121.2423546-14-suzuki.poulose@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_025049_931217_BE27CD72 X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/21/21 7:11 PM, Suzuki K Poulose wrote: > For the TRBE to operate, we need a minimum space available to collect > meaningful trace session. This is currently a few bytes, but we may need > to extend this for working around errata. So, abstract this into a helper > function. > > Cc: Anshuman Khandual > Cc: Mike Leach > Cc: Mathieu Poirier > Cc: Leo Yan > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-trbe.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index 797d978f9fa7..3373f4e2183b 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -277,6 +277,11 @@ trbe_handle_to_cpudata(struct perf_output_handle *handle) > return buf->cpudata; > } > > +static u64 trbe_min_trace_buf_size(struct perf_output_handle *handle) > +{ > + return TRBE_TRACE_MIN_BUF_SIZE; > +} Assuming that struct perf_output_handle could provide all the required support for a variable minimum trace buffer length. Reviewed-by: Anshuman Khandual > + > /* > * TRBE Limit Calculation > * > @@ -447,7 +452,7 @@ static unsigned long trbe_normal_offset(struct perf_output_handle *handle) > * have space for a meaningful run, we rather pad it > * and start fresh. > */ > - if (limit && (limit - head < TRBE_TRACE_MIN_BUF_SIZE)) { > + if (limit && ((limit - head) < trbe_min_trace_buf_size(handle))) { > trbe_pad_buf(handle, limit - head); > limit = __trbe_normal_offset(handle); > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel