From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30F88C2BA1A for ; Fri, 21 Jun 2024 09:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7tocwp9lNfOnGFlQhgrKD+Lp7CcVz+tHpAKPZsWSJzg=; b=QOcVuqcfieWttJ43f9luo4xCU3 eLJNEh+8/cmOe+VxKKMoZpJvgdxekMFUMfH7Nfb0WhsiQgOpe6HEQJH0H+o723YVF7HA/m8ju3t4k ItnYhsl+2HgZeBIE2TUiFzcEGpuUAUxIkli0PkMuw+zlX29tE5Wi997YjO8G5XaiWkflUXxgGIYXw iyWR6C/fgJ2zqDkYBD9ITFbdBFoehWCLZMO5rSj1/zn46Vnyr6/ibefGRiiu+O9Q5htMuVjF3YfHX Pc/nTYMYAVSjWxmBs2OESJ4LJwA6Azf52m1O3MyAqKmw/UjCxOA1AHKNDps4hLjtjxxU0EeX+ksWf fF8JMtYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKahW-00000008a7a-1O5K; Fri, 21 Jun 2024 09:36:58 +0000 Received: from out-183.mta1.migadu.com ([95.215.58.183]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKahS-00000008a5t-1Xqo for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 09:36:56 +0000 X-Envelope-To: daniel@makrotopia.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1718962608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7tocwp9lNfOnGFlQhgrKD+Lp7CcVz+tHpAKPZsWSJzg=; b=UTGblEpVdd3T+psQYU9COc2q3jV5L5PhuGGv2162hEoex83pduUNObt1D5UEm/fv7Jj39H cgAwnVpYY54HNcEc7qlPAM6jZ6Ullzwc6AQ4ltqbeeyOJYvuRSLFWsdXtPknfR8ZPQdtkq 6g44YJSyOaDW8mAL+EdmTlOwzzog1LMdMLho/hYfSqHpwPj/I66Bxc6x/s0gnmNPdis+Y1 VYBwo4Kpkw+msHIBUTxd9Dygl1SIgx1QZWIyWytFO73/7YptRo//l8XkyrvdPjZ1Yv1mP7 KjrYoFl4Y1h8FJveU68MBYGwtSJ3GBQozEwb+NlcqOFR8Yrr8GsRJ8ItLGoWNg== X-Envelope-To: aurelien@aurel32.net X-Envelope-To: olivia@selenic.com X-Envelope-To: herbert@gondor.apana.org.au X-Envelope-To: robh@kernel.org X-Envelope-To: krzk+dt@kernel.org X-Envelope-To: conor+dt@kernel.org X-Envelope-To: heiko@sntech.de X-Envelope-To: p.zabel@pengutronix.de X-Envelope-To: ukleinek@debian.org X-Envelope-To: sebastian.reichel@collabora.com X-Envelope-To: linux.amoon@gmail.com X-Envelope-To: dsimic@manjaro.org X-Envelope-To: s.hauer@pengutronix.de X-Envelope-To: martin@kaiser.cx X-Envelope-To: ardb@kernel.org X-Envelope-To: linux-crypto@vger.kernel.org X-Envelope-To: devicetree@vger.kernel.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: linux-rockchip@lists.infradead.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: daniel@makrotopia.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Diederik de Haas To: Daniel Golle , Aurelien Jarno , Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Sebastian Reichel , Anand Moon , Dragan Simic , Sascha Hauer , Martin Kaiser , Ard Biesheuvel , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Daniel Golle Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x Date: Fri, 21 Jun 2024 11:36:45 +0200 Message-ID: <5870442.3KgWVfgXFx@bagend> Organization: Connecting Knowledge In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2326598.u92GhurISB"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_023654_634049_1DE9F3A9 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --nextPart2326598.u92GhurISB Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Diederik de Haas Cc: Daniel Golle Date: Fri, 21 Jun 2024 11:36:45 +0200 Message-ID: <5870442.3KgWVfgXFx@bagend> Organization: Connecting Knowledge MIME-Version: 1.0 On Friday, 21 June 2024 03:25:30 CEST Daniel Golle wrote: > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index d8543b5557ee..57c8103500ea > 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -1855,6 +1855,15 @@ usb2phy1_otg: otg-port { > }; > }; > > + rng: rng@fe388000 { > + compatible = "rockchip,rk3568-rng"; > + reg = <0x0 0xfe388000 0x0 0x4000>; > + clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>; > + clock-names = "core", "ahb"; > + resets = <&cru SRST_TRNG_NS>; > + reset-names = "reset"; > + }; > + > pinctrl: pinctrl { > compatible = "rockchip,rk3568-pinctrl"; > rockchip,grf = <&grf>; > -- I had placed the node between ``sdhci: mmc@fe310000`` and ``i2s0_8ch: i2s@fe400000`` which I think is the proper order. Cheers, Diederik --nextPart2326598.u92GhurISB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZnVJrQAKCRDXblvOeH7b biBSAQCMa4hNIGCHuiNhbaI8GKE6K+tGfAz4PV8PCWjZL2SX8gEAp/afD39PReUl 9q2MBI5TXF+g0+JU6oBWjxcSlvzXcAw= =IJaH -----END PGP SIGNATURE----- --nextPart2326598.u92GhurISB--