From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9798D18135 for ; Mon, 14 Oct 2024 17:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zzIm24xlDu8WPNe3MkSQzgf924XbQr4l2WzaBR9dWtM=; b=B5lxD7qGkxLd3WJl7SyX8v0yoJ Iu1bnEUFqSP1nobph7Z99J7XYuFiiBZQwICWVDNwuVOdYiaD7Z5hOBPmF9OuBqGT0QufX8sl+Ceva 7nT3OSvu54C1O4Bu3KI59azfA8F1wI7hnLiTu2ZnWCfAqg34qKDHQl1XLtTExMBgy7nZiDVhjFqMk zckkEWVlgmIXK66r2RhmF2dzLZFwe+GIl3DGf4fZiwiJiwBEp0uVbexESey7xmguxO1UoC1akrOlr yR77V0f6EJ5LPzL3fi6PZoX1N9vRhZcd30LhK1ZPnjwgLsKsrbEQzCK3bPuQk5y1CaMPBbs84K5aC YNsNz3NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0Onb-000000062YO-1vmP; Mon, 14 Oct 2024 17:24:03 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0OlB-000000062A9-46lO for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2024 17:21:35 +0000 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2e2a97c2681so3249067a91.2 for ; Mon, 14 Oct 2024 10:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1728926492; x=1729531292; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=zzIm24xlDu8WPNe3MkSQzgf924XbQr4l2WzaBR9dWtM=; b=bZ6N+dQuFvpLxduYdFIdgdCVZowmwHVwVwE8jJtV/l3/lvhrS1oOkw+9R4kxZIiQnT JpQwBFK2tTwj0R3o432bw98V0WbejnGl3B/qFAv8sDWEsGZSYrMok7fpUPqjpGUa7xZn 7zBjN4+Im6O9C2wBnYT7VpC4HaO1hIFjV6hQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728926492; x=1729531292; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zzIm24xlDu8WPNe3MkSQzgf924XbQr4l2WzaBR9dWtM=; b=WttYm+i5BNVzukb4+OJ99yCxWswAPN+0B+Opg5n+svqtIk67hniTvQ4vjPh0WwK9Bq 2BP79lJjhJNE01SGrLpaS7iyN8KmjuvMmQ0s0YqHCxnHJlJ+P9Bia0eEsr2uIgQoqki0 Dhdn/ziZoa/yvY/6/nGoJG9d4UTpthCimyY+cFAQ0cCnPvsEDB3uTPWS8Cp6pIEn4saL G73SOlWR6jIvZoBzKSpEND/YxEuqXYmPfOe6Cls0Av2ltoWnmcWwq+DDJ95KhbA9bhh7 mfWZGEs/O3eaNffO2biTMYK/Civ2WyBDuK5dBP5hkJabwNq/FWMP+irfaldArqUzJGTZ sqQA== X-Forwarded-Encrypted: i=1; AJvYcCVuLphL1hPSdDCbE52FoDObhBXY96H5I4rhKoHrFsYQIxZNuTLuRYj4CMsWQBWkaJ+eecCn+fNiSRFIoyAE7KOA@lists.infradead.org X-Gm-Message-State: AOJu0YxgPzlV4sq9Gpal5zd9ZUp/uFMaLiB8GNIY2AOIUdSHh0EklhAa OjiUy3XRPxLONDevIPb6KC3CjBDP+eRoxv+n8OIKVfru1s/s/fR0un0gAvISInp5cH/osIXxxi2 Eag== X-Google-Smtp-Source: AGHT+IEILBnXLecSRXgZyFdiiBIZeZG70tJo3X0ijBb8mPdEd2TkWBNRiIzOR2wpGsSRTa0EOfRvHA== X-Received: by 2002:a17:90a:eb01:b0:2e2:8d33:f79d with SMTP id 98e67ed59e1d1-2e2f0ae8d45mr14291214a91.19.1728926492370; Mon, 14 Oct 2024 10:21:32 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2a5712738sm11610417a91.31.2024.10.14.10.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 10:21:29 -0700 (PDT) Message-ID: <58725446-d069-40a2-859f-0dd9ec6c3c98@broadcom.com> Date: Mon, 14 Oct 2024 10:21:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: arm_scmi: Queue in scmi layer for mailbox implementation To: Sudeep Holla , Cristian Marussi Cc: Justin Chen , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com, bcm-kernel-feedback-list@broadcom.com References: <20241009192637.1090238-1-justin.chen@broadcom.com> <50f4d2d6-dead-4053-834f-134d2df0d6bd@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_102134_055729_57E43C7C X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/24 02:55, Sudeep Holla wrote: > On Sun, Oct 13, 2024 at 10:26:49AM +0100, Cristian Marussi wrote: >> On Fri, Oct 11, 2024 at 12:15:07PM -0700, Justin Chen wrote: >>> >>> Yes, I see the implementation. Looks like it returns the position in the >>> ring buffer. I also confirmed with CONFIG_DEBUG_MUTEXES which triggers a >>> warning. >>> >>> What about this? >>> if (ret >= 0) >>> ret = 0 >>> else >>> mutex_unlock(&smbox->chan_lock); >>> >>> A bit easier to read IMO. >> >> Oh yes much better definitely...or, maybe, even more simply to read: >> >> ... >> >> mutex_lock(&smbox->chan_lock); >> ret = mbox_send_message(smbox->chan, xfer); >> if (ret < 0) { >> mutex_unlock(&smbox->chan_lock); >> return ret; >> } >> >> return 0; >> } >> >> .... up to You...not sure what Sudeep prefers... >> > > I like this better. Also I was hoping Justin would send v3 soonish, I want > to send PR for fixes soon. So I have gone ahead and fixed all your comments > myself. I had seen the doxygen one from builder already and had fixed it up > last week when I added this to -next. > Here's his v3: https://lore.kernel.org/all/20241014160717.1678953-1-justin.chen@broadcom.com/ we are on the other side of the pond ;) -- Florian