From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D234C25B77 for ; Mon, 20 May 2024 20:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PpQY9wga8sWalq6UMcbxCswyOdZm1s9W0Z3Mx7vVDco=; b=uecSxMqtwjwwOl q2zGbr3S69UDVuBhc3y3e+vEMNrquq1OwhEDI8XfSvtQ33pTAXlaqWc8AqaXPgnxf1/7NkLUfmezY s8CzbkAkyh18EXkRNe+hn3carS+qEAKZTCfkY5qW6B9tNwby1oG8cVRe4wes9Y1HgoNGBh8HY5wF4 d0UF4JGNfm+QeOr6S4HNe5Zp2J7VTmqGS6q1CRgqKE6X4wYGIfcVsRAFYx8V6BewLOHjQKiP8gYTE CBekTytgY9TWyxlGFT4TFepRC+NGdt7OiJJqQ62IaABsoICvQTycbxQZN4MQ/HV7Z+gvGJ1IMWlqG nE6euwPRB1/s/u4aCoHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s99k4-0000000FUks-41pq; Mon, 20 May 2024 20:36:20 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s99k2-0000000FUjf-1i3J for linux-arm-kernel@lists.infradead.org; Mon, 20 May 2024 20:36:19 +0000 Received: from [10.137.186.190] (unknown [131.107.159.62]) by linux.microsoft.com (Postfix) with ESMTPSA id EACFB205421D; Mon, 20 May 2024 13:36:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EACFB205421D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1716237376; bh=XdydB7zjUjYezj9ReQeRzLuYYU1bVLh5sU+DZTi2Y5g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pexG1JSdUuURsSLjO/6WhipEb+tmTM4SWikJZFoOTk4zC9rXqU/I4I7r5xLcpxKC0 TV/VHCWd/hYWGI5TQrQo/hQc+JpKk4sFzc1oOTnfwSsU9/2mScLtgPGX9CcIxkuCmq PGe6Xm702lEEo4Klhcm0K/ncemEUcxHt34buPKtk= Message-ID: <587482fa-b747-42e8-b581-01132475211c@linux.microsoft.com> Date: Mon, 20 May 2024 13:36:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] arm64/hyperv: Support DeviceTree To: Krzysztof Kozlowski , arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, mhklinux@outlook.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Cc: ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev References: <20240514224508.212318-1-romank@linux.microsoft.com> <20240514224508.212318-2-romank@linux.microsoft.com> <1766fc9a-1d10-4c93-a9db-a7e0db8b01e7@linaro.org> <267ef0e2-2384-44bd-81f9-f33dda7bb9d2@linux.microsoft.com> <6f7ae5e6-d20f-4980-9b6e-25ba6d7b5558@linaro.org> Content-Language: en-US From: Roman Kisel In-Reply-To: <6f7ae5e6-d20f-4980-9b6e-25ba6d7b5558@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240520_133618_690855_82EF2DF3 X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/19/2024 11:45 PM, Krzysztof Kozlowski wrote: > On 15/05/2024 19:33, Roman Kisel wrote: >>>> static bool hyperv_initialized; >>>> @@ -27,6 +30,29 @@ int hv_get_hypervisor_version(union hv_hypervisor_version_info *info) >>>> return 0; >>>> } >>>> >>>> +static bool hyperv_detect_fdt(void) >>>> +{ >>>> +#ifdef CONFIG_OF >>>> + const unsigned long hyp_node = of_get_flat_dt_subnode_by_name( >>>> + of_get_flat_dt_root(), "hypervisor"); >>> >>> Why do you add an ABI for node name? Although name looks OK, but is it >>> really described in the spec that you depend on it? I really do not like >>> name dependencies... >> >> Followed the existing DeviceTree's of naming and approaches in the >> kernel to surprise less and "invent" even less. As for the spec, the > > I am sorry, but there is no approved existing approach of adding ABI for > node names. There are exceptions or specific cases, but that's not > "invent less" approach. ABI is defined by compatible. I should check on the compatible instead of adding a node that is not mentioned in the DeviceTree spec as I understand. Appreciate your help! > > Best regards, > Krzysztof > -- Thank you, Roman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel