From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 25 Jan 2017 09:35:50 +0900 Subject: [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init In-Reply-To: <1485293599-23581-1-git-send-email-martin@kaiser.cx> References: <1485293599-23581-1-git-send-email-martin@kaiser.cx> Message-ID: <5887F2E6.7060205@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Martin, On 2017? 01? 25? 06:33, Martin Kaiser wrote: > These functions are called only by other __init functions. > Compiling for s3c2410 with CONFIG_DEBUG_SECTION_MISMATCH=y, > I get warnings like > > WARNING: vmlinux.o(.text+0x198350): > Section mismatch in reference from the function s3c2410_clk_sleep_init() > to the (unknown reference) .init.data:(unknown) > > Marking the s3c...._clk_sleep() functions as __init fixes this. > > Signed-off-by: Martin Kaiser > --- > drivers/clk/samsung/clk-s3c2410.c | 4 ++-- > drivers/clk/samsung/clk-s3c2412.c | 4 ++-- > drivers/clk/samsung/clk-s3c2443.c | 4 ++-- > drivers/clk/samsung/clk-s3c64xx.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) Looks good to me. Reviewed-by: Chanwoo Choi [snip] -- Best Regards, Chanwoo Choi Samsung Electronics