From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC010C4167B for ; Mon, 4 Dec 2023 04:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pm6EjmacGV6LNfai1NRNVKPtxrYymg5UEj8MidgHHzc=; b=B091vwV8LoR9wj aWkEyVx3CLtxqtF3pn0ASB4724sFnAEc8OJ0gm11vXtWEyAI81RPiEVFT4ahovHRKIe6J82hh2jDj Re1k0yvoamM343+E4346h0ftJqy+6URVGk4FG/MhM7n2xX1B17EtDX9DMQYBwWMT83onUndUJS7w3 FSMDItEV3ELHH+36w2ZWJs8q5jMcUYjL6MAEFK/gaF39hSLa9ofFiCBvE6W/gs0R5YzEdMpEsMFCi H5FMNQIUuw63xAJeeWhmr8zjNKaxlYMaAPsTB621dQYfECEz7dHfl8O3RnFiXgiTdqaHxjKOYjYYS MDfIlDnSljqc+s9tkz6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA0Xr-002ygi-1m; Mon, 04 Dec 2023 04:26:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA0Xn-002yg7-2O for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 04:26:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 265A1165C; Sun, 3 Dec 2023 20:27:39 -0800 (PST) Received: from [10.162.41.8] (a077893.blr.arm.com [10.162.41.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63D513F762; Sun, 3 Dec 2023 20:26:48 -0800 (PST) Message-ID: <58882cab-89ce-4554-aee4-24e70d82fc09@arm.com> Date: Mon, 4 Dec 2023 09:56:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/7] coresight: replicator: Move ACPI support from AMBA driver to platform driver Content-Language: en-US To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, Lorenzo Pieralisi , Mike Leach , James Clark , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com References: <20231201062053.1268492-1-anshuman.khandual@arm.com> <20231201062053.1268492-2-anshuman.khandual@arm.com> <20231201123515.gntwvhsxd5nzojn7@bogus> From: Anshuman Khandual In-Reply-To: <20231201123515.gntwvhsxd5nzojn7@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231203_202655_865031_84634210 X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/1/23 18:05, Sudeep Holla wrote: > On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote: >> Add support for the dynamic replicator device in the platform driver, which >> can then be used on ACPI based platforms. This change would now allow >> runtime power management for repliacator devices on ACPI based systems. >> >> The driver would try to enable the APB clock if available. Also, rename the >> code to reflect the fact that it now handles both static and dynamic >> replicators. >> >> Cc: Lorenzo Pieralisi >> Cc: Sudeep Holla > > Except the minor nit below which may apply also for few other patches > in the series > > Acked-by: Sudeep Holla # For ACPI related changes > Tested-by: Sudeep Holla # Boot and driver probe only > > [...] > >> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c >> index b6be73034996..64de0bee02ec 100644 >> --- a/drivers/hwtracing/coresight/coresight-replicator.c >> +++ b/drivers/hwtracing/coresight/coresight-replicator.c >> @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); >> struct replicator_drvdata { >> void __iomem *base; >> struct clk *atclk; >> + struct clk *pclk; > > [minor nit] Perhaps can be documented as well ? Sure, will add the following comment above the structure. @pclk: optional clock for the core parts of the replicator. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel