From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03212C4332F for ; Fri, 10 Nov 2023 07:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bUmnNvVTDxLL0SX24lz7d3KDmsagrcLyschuib0jXPw=; b=fp92kNK7A8VcUzuPsvM7eG7BWV fKrSryIo9BS3XKhWKYVF45helbxcq26vUXdv1o70RxkyEBvWJv19reh7zYtU2cn1MB80szyFFCoiH 3S2Og8sqn9d++P2kYNGH8T8OWgqnz854cb61/Ff92O6YR+rmS0yH9vK91tLjdPFWSMmHTHQCFwlqr oROeyZQabLU5qOgsmHXIBMqVdCCfx+KXXh1NCMmy7TquET6zCc8JnRGF5DYsmbpB6TvPUI+FLtZKc /9hEkqg1ryxEMpx29DzG49t0zqr+se39yPG2SLJh58I7ClB6X47UYxNXubSiDejav3hSm09eTOzgf lKuALz7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1MJB-0082p9-1u; Fri, 10 Nov 2023 07:52:05 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1MJ9-0082nd-0X for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 07:52:04 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4083ac51d8aso12910345e9.2 for ; Thu, 09 Nov 2023 23:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699602719; x=1700207519; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=emsT2msKceFt3PV2O7Tp50pasdkiiAdF3O2L4Y3FXfM=; b=nUb0+HRUJFyNjB3rjNGv7gcF0fYRsXzFMjcdO9jeTU95EQOT/fpWJBeSwmpTOp0oVS 7PuW18qZdwxRD/bWNIrnrymIr0S/unD3T9ZlnuYytyig7onXiYSfQLY67NimI5N7SLH0 2od8yqynjzrwKixjf5uQ7ZdUW48ODi91TpbXYTbPFg20UIov3VRwwnKz4P0wkVFJj8pF x9NegQbIYh7s+vhKRawfEXNt+mD3g+nEQhPxH/qEqyvc5laM2NOpbqsDszRqsjtDT2gy jA/Huohf/9LudX8y5skiBV8TnQTzqQtLA87zfnd0r7rWf+0Jf8JBbwvB2KytiCkBXTbT M/jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699602719; x=1700207519; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=emsT2msKceFt3PV2O7Tp50pasdkiiAdF3O2L4Y3FXfM=; b=EZJQ/9tQTTNb2b7ne61/HoTI5KwKyAdZxuiF4F3qmmm76zAD7sCxx7hZ3rW0jK1Xvz uMH/UILZawDxdj/V+cRcHAodJ/zU47MPvKFUu2qPcvub8qnhk/2PU/aI8Qdx9UM3RlMM Mj2Wm5HlPaX8dD3MfTNnOdupNx7CL/fGWAHdh//b7VpeIt9XkX2SoKkEVegzezKGfJVt bLWY6Te7gJUoSEveIze3nVB745TAfPCWxEaDE1cxdyxfYvuSJPmfVcqa7fR9zTlGo1fF BhZ008KXUjR5B3ZeAyHzPMGgRxjmmP+uy+oyVi5qC4vpgeJ6oT6U2SzqAKqNAJQ9OogP vqxg== X-Gm-Message-State: AOJu0Yyttf6b7djyDzz3i0IM9h4tp9zO9fj+ONaf3wLtj7PAl23rCYPc ywrGfnmxB0GOQhTo5Ju8G1t9aA== X-Google-Smtp-Source: AGHT+IGw+PCkMA6bHWqEEuoAwJ5a3yEHlqxE3b+F0LZFd3qRiaZ2W3inoKUaaR7waw3M3gHHAzI3FA== X-Received: by 2002:a5d:6dc5:0:b0:32d:8094:f4c8 with SMTP id d5-20020a5d6dc5000000b0032d8094f4c8mr5497228wrz.19.1699602719377; Thu, 09 Nov 2023 23:51:59 -0800 (PST) Received: from [192.168.7.189] (679773502.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id i5-20020adff305000000b0031c52e81490sm1333879wro.72.2023.11.09.23.51.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 23:51:58 -0800 (PST) Message-ID: <589daf80-727e-460f-a41e-2481b199c805@linaro.org> Date: Fri, 10 Nov 2023 08:51:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v8 04/12] dt-bindings: phy: amlogic,g12a-mipi-dphy-analog: drop unneeded reg property and example Content-Language: en-US, fr To: Conor Dooley Cc: Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , David Airlie , Daniel Vetter , Jagan Teki , Nicolas Belin , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20231109-amlogic-v6-4-upstream-dsi-ccf-vim3-v8-0-81e4aeeda193@linaro.org> <20231109-amlogic-v6-4-upstream-dsi-ccf-vim3-v8-4-81e4aeeda193@linaro.org> <20231109-sterility-unsoiled-e43771c61894@spud> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20231109-sterility-unsoiled-e43771c61894@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_235203_205540_0F87C893 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/11/2023 19:04, Conor Dooley wrote: > On Thu, Nov 09, 2023 at 10:00:05AM +0100, Neil Armstrong wrote: >> Now this bindings is referred from amlogic,meson-gx-hhi-sysctrl.yaml and is >> documented as a subnode of a simple-mfd, drop the invalid reg property. > > I'd expect a note here tbh about how removing reg & relying on being a > subnode of the simple-mfd is safe to do. It looks like your driver > was added at the same time as this binding & it was always documented as > being a child of the simple-mfd system controller, so I'd kinda expect > to see a Fixes tag on this patch.. > > Am I missing something? No you're totally right, I'll reword the commit message and add a Fixes tags. Thanks, Neil > >> >> Also drop the unnecessary example, the top level bindings example should >> be enough. >> >> Signed-off-by: Neil Armstrong >> --- >> .../bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml | 12 ------------ >> 1 file changed, 12 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml >> index c8c83acfb871..81c2654b7e57 100644 >> --- a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml >> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml >> @@ -16,20 +16,8 @@ properties: >> "#phy-cells": >> const: 0 >> >> - reg: >> - maxItems: 1 >> - >> required: >> - compatible >> - - reg >> - "#phy-cells" >> >> additionalProperties: false >> - >> -examples: >> - - | >> - phy@0 { >> - compatible = "amlogic,g12a-mipi-dphy-analog"; >> - reg = <0x0 0xc>; >> - #phy-cells = <0>; >> - }; >> >> -- >> 2.34.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel