From: mathias.nyman@linux.intel.com (Mathias Nyman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
Date: Tue, 7 Mar 2017 17:10:59 +0200 [thread overview]
Message-ID: <58BECD83.9000205@linux.intel.com> (raw)
In-Reply-To: <1488857543-9384-1-git-send-email-chunfeng.yun@mediatek.com>
On 07.03.2017 05:32, Chunfeng Yun wrote:
> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
> so checks the Maximum Primary Stream Array Size in the hcc_params
> register after adding primary hcd.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 9066ec9..6ac73a6 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> goto power_off_phys;
> }
>
> - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> - xhci->shared_hcd->can_do_streams = 1;
> -
> ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> if (ret)
> goto put_usb3_hcd;
>
> + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> + xhci->shared_hcd->can_do_streams = 1;
> +
> ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> if (ret)
> goto dealloc_usb2_hcd;
>
Thanks.
Looks like streams check has never worked for Mediatek xHC hosts,
Do you know if this has caused any issues?
looks like it should go usb-linus and maybe stable kernels as well.
-Mathias
next prev parent reply other threads:[~2017-03-07 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 3:32 [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd Chunfeng Yun
2017-03-07 3:32 ` [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct Chunfeng Yun
2017-03-07 11:02 ` Thierry Reding
2017-03-07 15:12 ` Mathias Nyman
2017-03-07 15:10 ` Mathias Nyman [this message]
2017-03-08 0:51 ` [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd Chunfeng Yun
2017-03-08 11:08 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58BECD83.9000205@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).