From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D571C433DF for ; Mon, 24 Aug 2020 14:21:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A812206F0 for ; Mon, 24 Aug 2020 14:21:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nz9sZxtp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="klG4oPX8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A812206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/vhnOTzlYeaSm4LacjzbSuS7vDYbw7YRsG3JwT40k1c=; b=nz9sZxtpCC6KXJ4XxVtMU+EPP ICIchs/dayqiWkaZWIZeXTI88M59utLo9ICNZONZYae4XzOl5wtkUYCxnxRZv1yXKZIwsrWNliK/B M6ccf6hg3H9FQdyeqyI5kA759LCLMkBKehBK8pn5BHKBre7riH3Qr6viWNUC0iGnrTYqYr/CO8g3v yebZ2ubipQ3w6QW/Q5Pvr/MEiowJnBrqDgNpl8JL7t3/9CioWtGcz5xLy4wQQ5mwNYPKqGsyoJeGp 47b8PGPYZxITlQZXp9HzxTJsOibtZ9GELu0ZBKd/56kZ+M65sTqryMiLqtBNYwxm7/3WBGhjzh2MN 27q1w3gMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kADJq-0000Yx-Lv; Mon, 24 Aug 2020 14:19:30 +0000 Received: from mail.kmu-office.ch ([2a02:418:6a02::a2]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kADJn-0000YN-3M for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 14:19:28 +0000 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 0115A5C3C43; Mon, 24 Aug 2020 16:19:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1598278764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZJ4IdJs7vNZOHX+v4Asmyv1svNA8lWS2xHxhNIw5NQw=; b=klG4oPX8z1HBdwMgPDp2O8SGPWF8a47XixIANUD22HRjeOAsU7wv/v/Qcxu3LA4IgK9Dmo hIiYXrhQDT2hyK8J2tF45euT5alXOcQdQE7WwhHOKJgXs/LCcrJP7ZbQhOwQvYZrcCxlrJ eahw5B5opFddIJvJn/8qXWVpnHUmn9Q= MIME-Version: 1.0 Date: Mon, 24 Aug 2020 16:19:23 +0200 From: Stefan Agner To: Laurent Pinchart Subject: Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings In-Reply-To: <20200823232603.GO6002@pendragon.ideasonboard.com> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-3-laurent.pinchart@ideasonboard.com> <20200823232603.GO6002@pendragon.ideasonboard.com> User-Agent: Roundcube Webmail/1.4.1 Message-ID: <58ad6bef353ee25e5c548c0d950f7e46@agner.ch> X-Sender: stefan@agner.ch X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_101927_370267_9096DBBB X-CRM114-Status: GOOD ( 28.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, =?UTF-8?Q?Guido_G=C3=BCnther?= , dri-devel@lists.freedesktop.org, Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-08-24 01:26, Laurent Pinchart wrote: > Hi Stefan, > > On Fri, Aug 21, 2020 at 04:53:56PM +0200, Stefan Agner wrote: >> On 2020-08-13 03:29, Laurent Pinchart wrote: >> > Additional compatible strings have been added in DT source for the >> > i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. >> > Most of the upstream DT sources use the fsl,imx28-lcdif compatible >> > string, which mostly predates the realization that the LCDIF in the >> > i.MX6 and newer SoCs have extra features compared to the i.MX28. >> >> Agreed, we should add fsl,imx6sx-lcdif for those devices. >> >> But shouldn't we also keep fsl,imx28-lcdif? From what I can tell, the >> devices can be driven by a driver only supporting fsl,imx28-lcdif >> semantics, right? > > Isn't it kept by this patch ? > >> > Update the bindings to add the missing compatible strings, with the >> > correct fallback values. This fails to validate some of the upstream DT >> > sources. Instead of adding the incorrect compatible fallback to the >> > binding, the sources should be updated separately. >> > >> > Signed-off-by: Laurent Pinchart >> > --- >> > .../devicetree/bindings/display/mxsfb.yaml | 18 +++++++++++++----- >> > 1 file changed, 13 insertions(+), 5 deletions(-) >> > >> > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml >> > b/Documentation/devicetree/bindings/display/mxsfb.yaml >> > index 202381ec5bb7..ec6533b1d4a3 100644 >> > --- a/Documentation/devicetree/bindings/display/mxsfb.yaml >> > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml >> > @@ -15,11 +15,19 @@ description: | >> > >> > properties: >> > compatible: >> > - enum: >> > - - fsl,imx23-lcdif >> > - - fsl,imx28-lcdif >> > - - fsl,imx6sx-lcdif >> > - - fsl,imx8mq-lcdif >> > + oneOf: >> > + - enum: >> > + - fsl,imx23-lcdif >> > + - fsl,imx28-lcdif > > Here -----------------^ > > The binding now support any of "fsl,imx23-lcdif", "fsl,imx28-lcdif" or > "fsl,imx6sx-lcdif" alone, or "fsl,imx6sx-lcdif" with another > device-specific compatible string. The driver supports the three base > compatible strings, for V3, V4 and V6 of the IP core. The binding yes, but I mean the device descriptions in the device tree. Since the device can be driven by a older kernel which only knows about the fsl,imx28-lcdif compatible string, we could keep that compatible. >From what I can tell, we can add both safely, e.g. compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif" >From how I read the description this now replaces "fsl,imx28-lcdif" with "fsl,imx6sx-lcdif" for the devices supporting the additional features, e.g.: --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -769,7 +769,7 @@ epdc: epdc@20f4000 { }; lcdif: lcdif@20f8000 { - compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_LCDIF_PIX>, -- Stefan > >> > + - fsl,imx6sx-lcdif >> > + - items: >> > + - enum: >> > + - fsl,imx6sl-lcdif >> > + - fsl,imx6sll-lcdif >> > + - fsl,imx6ul-lcdif >> > + - fsl,imx7d-lcdif >> > + - fsl,imx8mq-lcdif >> > + - const: fsl,imx6sx-lcdif >> > >> > reg: >> > maxItems: 1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel