From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65C77C25B78 for ; Tue, 21 May 2024 15:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06hAIJsX3aWh7T7KC/hxNM2x89Jw9uBCsduW6xyEWkw=; b=vxBM7vp+uxhElq 9LpHfNpfXr/HNF0AMU3qWtGZzrw9yQixhGvulYEU69WVtCdSD+AMozYDthLhWUUzOPsYGSbYXRFT5 As58O8YCAjuQhygyTWO70S545s8xYM1mUgZUDLqifv4V/UwMjXpc5vG5++j16AAwA86o7QwZLlG9g LbRKACKgsm916y0uwLMaXDqMtR5914jxk9NuGkse/df8XH5QmG87MUrK88yMqNpyut14ZAwtFd+ht 750TBuF4+TUW2BWI/g1Mu2ScH9Ga4Q0C1Qgo8i8cw6oQGo39s3vMGcFBY1FzqG7n97fJZaw1+tX10 07sGjJnhqgEmnLTfZKGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9RXl-00000000Mvs-422K; Tue, 21 May 2024 15:36:49 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9RXi-00000000Mtr-49sy for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2024 15:36:48 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4202ca70287so24325425e9.3 for ; Tue, 21 May 2024 08:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716305805; x=1716910605; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=46MBRG1SoxQr9SxFCn07JGJ8jdLms6wT8cP/QcL3Nhw=; b=IL+34bjd2rYTgog9QdSiCmqf1pYEe5QRbDCqSSGfjMtDr/5EXZhJSAEF9bpn4pSxMv hI+9QpRrFJx+6ndh41C2CoiXvMVBNpXID8+bGzMxMABoQh0n2Nuvv6Yr9q4C2tE4E2hl erAkJBGLLpLCSUxKEbuo2W1zh0NxVRRnZNKQCHf4aw8czzp1dLzulb4+tbSMaRTLQqEW KPVcvueC17t4Kqzf1DFPQx9gw9++84Y30eIdvvr4+m9+6E0oWVD3SBalybJDeWbRpFaK KfZc1YAAtoXnmTvp8vf+lFanQzC9nLtZq16RBN+WfJekXTQ7f2DCUdacw2hm+YFxIfku 85wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716305805; x=1716910605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=46MBRG1SoxQr9SxFCn07JGJ8jdLms6wT8cP/QcL3Nhw=; b=QEoY53LWisWILp7WgCJR2nYzVylzMEoyorIR1v75syjPQqhNeAv4jhcNPGRC4Hr7aa JGxLJ90wgO6wlQ6HCZuaU+uP9MBB2j6a4FQ4Pc/gkmbXtqncfw+iZFaFdUYxLR9APxwY wQJnWMecLd/xuQU+ZORE9FNu94yUDa4q4cPssveZ4j45RXZGuUwoGzZvzGuB8+iMrQ7Q Uj3B2KutpSSsBD/b5OCWEVsS9yPFq6S+vgFOdmj8rCppPih4gkxZdEbh8CrRXPW4vXoZ cYpgotUkLenV/L64pli9C0m+cWVpCvsAJqQL41h3V45iqgDz/bZhgQrQvruJcN67gZHP uujg== X-Forwarded-Encrypted: i=1; AJvYcCVdZ7VzN2YfA1jpbhswrRaTw8haj3Gnh2UyMHjMECEkuDf9IqM6qxYQYTZs0mCZYCncLViUP6ZtnpnuOeLOQJT76BR77P7zJuwgFncoA1MVzhqpyrc= X-Gm-Message-State: AOJu0Ywi85TqMp1vHP2WYYmMHvzEkdBkMp65VLtu2wPMN7i6wBnLWLh+ XBhcG4/7D7DFlLzChHJlZr0w9spwC7nV8J+eZAAGpYQKsWth/5s= X-Google-Smtp-Source: AGHT+IFi6H7xCiBQJNeJFOntXvHJMi8HPJVCQ5T8EDXf2/2DlOHcElz5RxvKkaL/QDJl/17ygKhYrg== X-Received: by 2002:a05:600c:1c9e:b0:420:29dd:84e3 with SMTP id 5b1f17b1804b1-42029dd8829mr162105465e9.26.1716305804872; Tue, 21 May 2024 08:36:44 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:a828:7263:6693:6f6a? ([2a02:810b:f40:4600:a828:7263:6693:6f6a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42010940845sm391038675e9.35.2024.05.21.08.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 08:36:44 -0700 (PDT) Message-ID: <58ddfc8f-1995-4f41-9d63-35a00c6f92b9@gmail.com> Date: Tue, 21 May 2024 17:36:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/10] drm/bridge: add common api for inno hdmi To: keith , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, xingyu.wu@starfivetech.com, p.zabel@pengutronix.de, jack.zhu@starfivetech.com, shengyang.chen@starfivetech.com Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240521105817.3301-1-keith.zhao@starfivetech.com> <20240521105817.3301-3-keith.zhao@starfivetech.com> Content-Language: en-US From: Alex Bee In-Reply-To: <20240521105817.3301-3-keith.zhao@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240521_083647_067701_64890AA9 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Keith, thanks a lot for working on this. See some general remarks below Am 21.05.24 um 12:58 schrieb keith: > Add INNO common api so that it can be used by vendor > drivers which implement vendor specific extensions to Innosilicon HDMI. > > Signed-off-by: keith > --- > MAINTAINERS | 2 + > drivers/gpu/drm/bridge/Kconfig | 2 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/innosilicon/Kconfig | 6 + > drivers/gpu/drm/bridge/innosilicon/Makefile | 2 + > .../gpu/drm/bridge/innosilicon/inno-hdmi.c | 587 ++++++++++++++++++ > .../gpu/drm/bridge/innosilicon/inno-hdmi.h | 97 +++ > include/drm/bridge/inno_hdmi.h | 69 ++ > 8 files changed, 766 insertions(+) > create mode 100644 drivers/gpu/drm/bridge/innosilicon/Kconfig > create mode 100644 drivers/gpu/drm/bridge/innosilicon/Makefile > create mode 100644 drivers/gpu/drm/bridge/innosilicon/inno-hdmi.c > create mode 100644 drivers/gpu/drm/bridge/innosilicon/inno-hdmi.h > create mode 100644 include/drm/bridge/inno_hdmi.h > .... > + drm_encoder_helper_add(encoder, pdata->helper_private); > + > + hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD; > + > + drm_connector_helper_add(&hdmi->connector, > + &inno_hdmi_connector_helper_funcs); > + > + drmm_connector_init(drm, &hdmi->connector, > + &inno_hdmi_connector_funcs, > + DRM_MODE_CONNECTOR_HDMIA, > + hdmi->ddc); > + I really don't want to anticipate bridge maintainer's feedback, but new bridge drivers must not contain connector creation. That must happen somewhere else. Also I'm neither seeing any drm_brige struct nor drm_bridge_funcs, which are both essential for a bridge driver. I don't think moving a part of a driver to .../drm/bridge/ makes it a bridge driver. Regeards, Alex > + drm_connector_attach_encoder(&hdmi->connector, encoder); > + > + return 0; > +} > + .... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel