From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9912C04EB8 for ; Wed, 5 Dec 2018 03:26:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 452C820878 for ; Wed, 5 Dec 2018 03:26:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p53YgiZk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="iINiaOVc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 452C820878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vHzEQnCCnLH9Q35pvrNzXf53BI+w19ont12ejOA3pTU=; b=p53YgiZkXe4LUcAM9186AITsk Q2amQ0/+N6gBhu1UsFwUeTnhoJP5en6D1OiqOcJ1SiFmLIOGYPoS3hhaBLL8NSXgGxSd5VRhOTsKH iupQTe6X+veVwLBf6IfUFon/YER4VTu27GmkxWM5+GLXdZ71gzKDcI93JdooiJgFWSJUm6NQdolNl 0nQsTIF7OYDRhYeUXUpOffrmEuTAWu4olH0F8IF6zsr4BBPe0Cw0s996fPdIjGxC9bBryX1lByrS8 ChLK903ZXRBPRCJMVdyWCcReoAaa50Kzqx3eonyySVUqBYMmhlhT2yBwgUEzcZKxl3SrXeMgK60Bf K8eB8fdsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUNp2-00077q-RY; Wed, 05 Dec 2018 03:26:00 +0000 Received: from hqemgate14.nvidia.com ([216.228.121.143]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUNp0-00077H-D8 for linux-arm-kernel@lists.infradead.org; Wed, 05 Dec 2018 03:25:59 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 04 Dec 2018 19:25:46 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 04 Dec 2018 19:25:47 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 04 Dec 2018 19:25:47 -0800 Received: from [10.19.108.132] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 5 Dec 2018 03:25:45 +0000 Subject: Re: [PATCH 12/19] cpufreq: tegra124: extend to support Tegra210 To: Dmitry Osipenko , Thierry Reding , Peter De Schrijver , Jonathan Hunter References: <20181204092548.3038-1-josephl@nvidia.com> <20181204092548.3038-13-josephl@nvidia.com> From: Joseph Lo Message-ID: <58e13709-79e6-66cc-2858-a51b393da05a@nvidia.com> Date: Wed, 5 Dec 2018 11:25:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1543980346; bh=Zu/iOZ55KNBSOn8UjTX4Y5yu+c+BGbMZ2a/Y0Y1AXs8=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=iINiaOVcWjGz2J766u3HCfb4Xwx3Dc1FYzCdMZZFTlVtQ7m/tl/J0HU1mDl31MKem 3tUo6EVKj0Z+qQAABV3IP4IfVGusA+DgN8x5Sy8y0BI6bK5z7InoTKjlqHH2OvSdqn OF0oC3Qkb7jf2dZxsiin3hSxnH22E9moZXMR+jOk21/71JXTnX0xQrrWnLuj2P1fDW ILVisrklQedm1p4kq2q5i02EJcpxiaSDFpgh4J861e4tA77gB68b6T2/0bHkqRDNhJ gblOQdrDVGzkT56qmRJ/PFb8saX3ZayytMzHx6TNzJCkhc9+xasvpWzy9UUfzKDZ5y QXk3gLCwjMgOA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181204_192558_456687_732686E9 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Viresh Kumar , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/4/18 7:22 PM, Dmitry Osipenko wrote: > On 04.12.2018 12:25, Joseph Lo wrote: >> Tegra210 uses the same methodology as Tegra124 for CPUFreq controlling >> that based on DFLL clock. So extending this driver to support Tegra210. >> >> Cc: Viresh Kumar >> Cc: linux-pm@vger.kernel.org >> Signed-off-by: Joseph Lo >> --- >> drivers/cpufreq/tegra124-cpufreq.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c >> index 448d00763d00..1af955fb715c 100644 >> --- a/drivers/cpufreq/tegra124-cpufreq.c >> +++ b/drivers/cpufreq/tegra124-cpufreq.c >> @@ -159,7 +159,8 @@ static int __init tegra_cpufreq_init(void) >> int ret; >> struct platform_device *pdev; >> >> - if (!of_machine_is_compatible("nvidia,tegra124")) >> + if (!(of_machine_is_compatible("nvidia,tegra124") || >> + of_machine_is_compatible("nvidia,tegra210"))) >> return -ENODEV; >> >> /* >> > > Seems that's not enough, you also need to blacklist "nvidia,tegra210" in the drivers/cpufreq/cpufreq-dt-platdev.c Hi Dmitry, Thanks for reviewing. Actually it's "just" enough, I did check that driver for creating device data for cpufreq-dt driver. It needs to have both OPP v2 property and blacklist to create device data. Because we don't use OPP v2, it will never be true. So it will "just" work in this case. But you are right, add that to blacklist is more clear. I can add one more patch for that in next series. Thanks, Joseph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel