From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45E47C2BBCA for ; Fri, 28 Jun 2024 08:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Subject:Cc:To: From:Date:References:In-Reply-To:Message-Id:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cJIDXDBEaobog5LZrJWoNd7/OqP4XjwMn7T6pbh9or0=; b=eEVy0J4RznHhARFBoKP6PGt6zQ 2sNFzo24P5nYwPICm5oHJAXLJa03Y9JtyQCbdY/uV+q3fk0ci+EKmEw+MaAkuR6IYkxLEmo5puHbI LBMHMpTxKRB88xZH18kvtZ5vwZnFS2fHXZs9V9WEq96vR4xCCAQ34r9g4iH/uEMUVkMPf6xihBp9j pmnDqYpV9OHrP5KgEfuBaBzm/+xJXVSWj5K8S8mIQx4pGtEEvPTWriy4MdUQ6L5OoTk5PQDe93E0C Vj9bnUtbpXRGTQrtUxNC7b937K45fKDn3xDhfM7eKfSvp14PXGpFa1etkwEQVJAaHiR3cZS8s3Eag y6OVFJmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6zd-0000000D4TK-3NqL; Fri, 28 Jun 2024 08:30:05 +0000 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6zT-0000000D4OQ-1Or9 for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 08:29:57 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 6F9461380665; Fri, 28 Jun 2024 04:29:52 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 28 Jun 2024 04:29:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1719563392; x=1719649792; bh=cJIDXDBEao bog5LZrJWoNd7/OqP4XjwMn7T6pbh9or0=; b=oBJVXWremJeesyBI3c9MlLkDPf 3GfLEEmo3atJaxjNyeBLEDY9EDmSBqeVGzZDjkr8tKW0NbbssGC5W7jw49bVn2CF YBTw84zi6M2dGWoLGcCvrtpUOmAotKXoLVYa7Yjt22Ty44JVx+D5/zjvbmWYT3Nx M0nOWXnycbNx/taf8WqJjiUcmg6pU4+oX9Hqm08ZVW6Hcm0ONwG5jEAt6+YiImgZ hPU0kzLGhKhAoVE3G7TV8hvl9IKmfzdHimq0AG2L7P8rjf5bovtaJQ0PdkvQBK7Z KRP7W0omUsJ41DZ/om5hBkipE9iBSnIBI4ZxmGkma0oozyPX+zkpTbeiwcTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719563392; x=1719649792; bh=cJIDXDBEaobog5LZrJWoNd7/OqP4 XjwMn7T6pbh9or0=; b=cxoXI44sel16xBKA7ia0okWbqxUJ1dbJCfbu6e5nKZQ7 YyIz3+ruBZi1Sk4odE/aULrFcj/K+sQ68KkkUNgd6LPyWzew76MOwcFcK38a0aS/ 8SQGaIgjNTl9yFlQjF3zKEaZsrwX5Aml1fchzNKSEBDulx2PcyDeLbbymqZjkUua gG1ziB05TGAflHXzHETarXxWjzCQ2fsf5sQ2wy8NBwAQ2QEqNADC1qUqbGuFiZE/ MYSGlQ+CHU8Xg9wA/sjsh4bcGU/2oOXqegucH5PqBMWHTEtbYziAtzGeIE1zTchm aJeC/kODIccAfMxkbcWRbemQg1MSSh3YrpgPoQCcYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdeigddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id DD5CAB6008D; Fri, 28 Jun 2024 04:29:51 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa MIME-Version: 1.0 Message-Id: <58ec4d44-3393-4b0b-83c4-3f66b0e2de1e@app.fastmail.com> In-Reply-To: <20240628080146.49545-1-andrei.simion@microchip.com> References: <20240628080146.49545-1-andrei.simion@microchip.com> Date: Fri, 28 Jun 2024 10:29:27 +0200 From: "Arnd Bergmann" To: "Andrei Simion" , "Bartosz Golaszewski" , "Rob Herring" , krzk+dt@kernel.org, "Conor Dooley" , "Nicolas Ferre" , "Alexandre Belloni" , "Claudiu Beznea" , "Greg Kroah-Hartman" Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/3] Read MAC address through NVMEM for sama7g5ek Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_012955_797402_1870884A X-CRM114-Status: GOOD ( 11.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2024, at 10:01, Andrei Simion wrote: > This series proposes to add EEPROM support and reading MAC addresses > through NVMEM (via Devicetree) for sama7g5ek: > - Add in DT bindings document the EEPROM compatibles : > "microchip,24aa025e48" and "microchip,24aa025e64" > - Update to the driver to support "microchip,24aa025e48" and > "microchip,24aa025e64" and adjusting offset for those 24AA025E{48, 64}. > - Added the nodes in devicetree for eeproms where are stored EUI-48 MAC, > and update gmac nodes to read the MAC via devicetree through NVMEM. Can you add an explanation about what this is good for? Do you need to work around broken boot loaders that cannot be updated and that happen to store the MAC address in the EEPROM, or are you proposing this as a generic solution that board developers should actually use? As far as I can tell, even with this logic in place, users are better off just having the boot loader read the EEPROM and storing the MAC address in the in-memory dtb as we do on other platforms. Arnd