From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A3AFC6FA8E for ; Thu, 2 Mar 2023 12:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i2PuFfOol8mV9ktTY8WhKQtU1JPOCNoFKX7k2S99A1c=; b=LskUAtq+XuBASU wDsB8jsMWTUfQ0LCrQg24D2Mqr/Oe4DxtT3zhZkKZeKAxQn+b9hMX3v9M6gHoOQHKuSy+2fX7PrEh hnLyAnXZQ5xURIzgLBhzz7iju175FJ2c0He/jZGtdDMYmKOM1edzQ8xDA+h3nN6aaiXzbZt17Gii/ dDiRulQMyjlI7neitDXVw8Ao6ukRzeRTrvzEdTUSzWnGyQAfTATH4jYtW8oycUHYQzFqf2XMlCWva 5kjMp9rfpow20MWW7S15vb9z+eys36U7cOxiSzdmKBgOU9F1gL2f5PJ0Fki6eaESt2HnjB+6zE2zv icdwOSKH7W9Qa6gVaIvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXhvH-00271W-40; Thu, 02 Mar 2023 12:20:35 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXhvD-0026zm-AC for linux-arm-kernel@lists.infradead.org; Thu, 02 Mar 2023 12:20:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1677759631; x=1709295631; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Jc7NCjQNaCgCuZVespPULBgPudxFGzjmmOwhTE6K09E=; b=eBbuwHGaPrqaFf+pMoFnaSRYrjQkhdB/SjR3qr/R9Xw5JiSrVSq7js3I iZBCgLR+NTvSu+WqxkNMI/Q06hcZyCTqGsselJIADVBYd7ItCoSeRlCEI n0K2Lz5tUvOWlRwgLyRkiHhRcB4hy93HT/asr/m7g9kGif1IJxmWi/XQz zj80PV9aj7xjHhIFmfnmbLfhRTLmJckqZ66IaVzuOmTosYPJvskMT58Z0 FX07U8Z419DBCtg3x4v0q7kYNG34N/8VhDOiGde4nhJEWvR1LM4eQ1IPP CacYMzaX0e88rOU5m0ZbiM98sdBt84R9xa65+0BAQQUxKQXnXEjrakLjI A==; X-IronPort-AV: E=Sophos;i="5.98,227,1673910000"; d="scan'208";a="29424524" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Mar 2023 13:20:28 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 02 Mar 2023 13:20:28 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 02 Mar 2023 13:20:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1677759628; x=1709295628; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Jc7NCjQNaCgCuZVespPULBgPudxFGzjmmOwhTE6K09E=; b=hr6dIdZaqnG+kXV825HVvmihOgbDw9v8v7MnX8UEshFR4wXWVNdoyvS9 2U+ZDqeyD5Zx+Fy+Qixi+044k3a3l5PGnYTq36absE2FflZ5b/C16MUT3 g6zUnDhgI4ed3rDzmqtPyhCC8bc30j7401g8WnxeOWyJek0JF4tCPCtTY P9CLuIOsz5xY+TgmsHbiozvolRcVHz/1mtuhLs55i5smVP2dPSYg/Cc00 ffvrbLZaNm+p0mwYPkz00lEa2c5PXev+KrGGXJMYnB4WjJC7DW8e1w1+e PJ6atOgNxl/hR8BeO3IFmHUIO5wY/EJGQGK2ilfcIwTQ9iNrR7Sunf7Li Q==; X-IronPort-AV: E=Sophos;i="5.98,227,1673910000"; d="scan'208";a="29424523" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Mar 2023 13:20:27 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id AFFCF280056; Thu, 2 Mar 2023 13:20:27 +0100 (CET) From: Alexander Stein To: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org Cc: linux-serial@vger.kernel.org, Jiri Slaby , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org, Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Subject: Re: [PATCH] serial: imx: Simplify imx_uart_type Date: Thu, 02 Mar 2023 13:20:25 +0100 Message-ID: <5912297.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230302115547.sacjk4ekwmfev2xz@pengutronix.de> References: <20230302114810.1859500-1-u.kleine-koenig@pengutronix.de> <20230302115547.sacjk4ekwmfev2xz@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230302_042031_774191_3B4DC94E X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Uwe, Am Donnerstag, 2. M=E4rz 2023, 12:55:47 CET schrieb Uwe Kleine-K=F6nig: > * PGP Signed by an unknown key > = > Hello, > = > On Thu, Mar 02, 2023 at 12:48:10PM +0100, Uwe Kleine-K=F6nig wrote: > > There is no point in casting a struct uart_port to a struct imx_port > > just to access the first member of the latter (a struct uart_port). > > = > > This introduces code changes. > = > Please disregard this patch. While the patch is fine as is, I just > noticed a few more functions in this driver that can be simplified > accordingly. I'm about to send out an improved version (with a different > subject, so not called v2). Shouldn't this cast on the other locations be converted into a to_imx_port(= ) = function using container_of as well? Best regards, Alexander > Best regards > Uwe -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel